Skip to contentSkip to conversation

x86emul/fuzzer: re-arrange cleaning

PATCH In review Jan Beulich 2 participants 2 messages Apr 4, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86emul/fuzzer: re-arrange cleaning

The latter of the two commits referenced below converted x86_emulate from a symlinked dir to a real one, holding symlinked files. Yet even before that the split between distclean and clean was suspicious: A similar split, removing symlinks only in distclean, doesn't exist anywhere else in the tree afaics.

Fixes c808475882ef ("tools/fuzz: introduce x86 instruction emulator target")
Fixes 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")

---
The use of FORCE also looks suspicious to me in the rules creating the symlinks. Supposedly that's to deal with the source tree moving, but is that really something we need to care about (and if so, here but not elsewhere)?

tools/fuzz/x86_instruction_emulator/Makefile +1 -1
@@ -60,11 +60,11 @@ all: x86-insn-fuzz-all
 
 .PHONY: distclean
 distclean: clean
-	rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
 
 .PHONY: clean
 clean:
 	rm -f *.a *.o $(DEPS_RM) afl-harness afl-harness-cov *.gcda *.gcno *.gcov
+	rm -rf x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
 
 .PHONY: install
 install: all
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jan Beulich

The latter of the two commits referenced below converted x86_emulate from a symlinked dir to a real one, holding symlinked files. Yet even before that the split between distclean and clean was suspicious: A similar split, removing symlinks only in distclean, doesn't exist anywhere else in the tree afaics.

Fixes c808475882ef ("tools/fuzz: introduce x86 instruction emulator target")
Fixes 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")