w1: netlink: fix spelling mistakes in comments
PATCH 1/1 w1: netlink: fix spelling mistakes in comments
Correct several typos in comments: "appeneded"/"appened" -> "appended", "Direclty" -> "Directly", "compariable" -> "comparable", "duplicats" -> "duplicates".
No functional change.
--- drivers/w1/w1_netlink.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/w1/w1_netlink.c +6 -6
@@ -23,9 +23,9 @@ struct w1_cb_block {u16 maxlen;/* pointers to building up the reply message */ struct cn_msg *first_cn;/* fixed once the structure is populated */ -struct cn_msg *cn;/* advances as cn_msg is appeneded */ -struct w1_netlink_msg *msg;/* advances as w1_netlink_msg is appened */ -struct w1_netlink_cmd *cmd;/* advances as cmds are appened */ +struct cn_msg *cn;/* advances as cn_msg is appended */ +struct w1_netlink_msg *msg;/* advances as w1_netlink_msg is appended */ +struct w1_netlink_cmd *cmd;/* advances as cmds are appended */ struct w1_netlink_msg *cur_msg;/* currently message being processed */ /* copy of the original request follows */ struct cn_msg request_cn;
@@ -49,8 +49,8 @@ struct w1_cb_node {* @block: block to calculate * * Calculates the current message length including possible multiple -* cn_msg and data, excludes the first sizeof(struct cn_msg). Direclty -* compariable to maxlen and usable to send the message. +* cn_msg and data, excludes the first sizeof(struct cn_msg). Directly +* comparable to maxlen and usable to send the message. */ static u16 w1_reply_len (struct w1_cb_block *block) {
@@ -581,7 +581,7 @@ static void w1_cn_callback(struct cn_msg *cn, struct netlink_skb_parms *nsp)int size;int reply_size =sizeof (*cn) + cn->len + slave_len;if (cn->flags &W1_CN_BUNDLE ) { -/* bundling duplicats some of the messages */ +/* bundling duplicates some of the messages */ reply_size +=2 * cmd_count * (sizeof (struct cn_msg ) +sizeof (struct w1_netlink_msg ) +sizeof (struct w1_netlink_cmd ));
Signature · 1 line
2.55.0
Krzysztof Kozlowski
maintainerQuoted 9 lines · Ivy Lopez
Correct several typos in comments: "appeneded"/"appened" -> "appended", "Direclty" -> "Directly", "compariable" -> "comparable", "duplicats" -> "duplicates".
No functional change.
Signed-off-by Ivy Lopez <[email protected]>--- drivers/w1/w1_netlink.c | 12 ++++++------
Did you investigate / fix all such typos in entire w1 subsystem?
Best regards,
Krzysztof
PATCH 1/1 w1: fix spelling mistakes in comments across the subsystem
In reply to Ivy LopezFollowing up on a prior patch that only fixed w1_netlink.c, sweep the rest of the w1 subsystem for the same class of comment typos:
"loosing" -> "losing", "deatch" -> "detach", "messagse" -> "messages", "continusly" -> "continuously", "attribut" -> "attribute", "deactive" -> "deactivate", "determing" -> "determining", "discrepency" -> "discrepancy", "rerurn" -> "return".
No functional change.
--- drivers/w1/masters/ds2482.c | 2 +- drivers/w1/masters/ds2490.c | 4 ++-- drivers/w1/masters/omap_hdq.c | 2 +- drivers/w1/slaves/w1_ds28e17.c | 2 +- drivers/w1/slaves/w1_therm.c | 2 +- drivers/w1/w1.c | 2 +- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_netlink.h | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)
drivers/w1/masters/ds2482.c +1 -1
@@ -421,7 +421,7 @@ static u8 ds2482_w1_set_pullup(void *data, int delay)/* if delay is non-zero activate the pullup, * the strong pullup will be automatically deactivated -* by the master, so do not explicitly deactive it +* by the master, so do not explicitly deactivate it */ if (delay) {/* both waits are crucial, otherwise devices might not be
drivers/w1/masters/ds2490.c +2 -2
@@ -562,7 +562,7 @@ static int ds_write_bit(struct ds_device *dev, u8 bit)/* Set COMM_ICP to write without a readback. Note, this will * produce one time slot, a down followed by an up with COMM_D -* only determing the timing. +* only determining the timing. */ err =ds_send_control (dev,COMM_BIT_IO |COMM_IM |COMM_ICP | (bit ?COMM_D :0 ),0 );
@@ -691,7 +691,7 @@ static void ds9490r_search(void *data, struct w1_master *master,* If the number of devices found is less than or equal to the * search_limit, that number of IDs will be returned. If there are * more, search_limit IDs will be returned followed by a non-zero -* discrepency value. +* discrepancy value. */ struct ds_device *dev = data;int err;
drivers/w1/masters/omap_hdq.c +1 -1
@@ -282,7 +282,7 @@ static int omap_hdq_break(struct hdq_data *hdq_data) }/* -* wait for both INIT and GO bits rerurn to zero. +* wait for both INIT and GO bits return to zero. * zero wait time expected for interrupt mode. */ ret = hdq_wait_for_flag(hdq_data, OMAP_HDQ_CTRL_STATUS,
drivers/w1/slaves/w1_ds28e17.c +1 -1
@@ -101,7 +101,7 @@ static int w1_f19_i2c_busy_wait(struct w1_slave *sl, size_t count) timebases[data->speed] * (data->stretch) * count + W1_F19_BUSY_GRATUITY); -/* Now continusly check the busy flag sent by the DS28E17. */ +/* Now continuously check the busy flag sent by the DS28E17. */ checks =W1_F19_BUSY_CHECKS ;while ((checks--) >0 ) {/* Return success if the busy flag is cleared. */
drivers/w1/slaves/w1_therm.c +1 -1
@@ -355,7 +355,7 @@ static DEVICE_ATTR_RW(alarms);static DEVICE_ATTR_RW (conv_time);static DEVICE_ATTR_RW (features); -static DEVICE_ATTR_RW (therm_bulk_read);/* attribut at master level */ +static DEVICE_ATTR_RW (therm_bulk_read);/* attribute at master level */ /* Interface Functions declaration */
drivers/w1/w1.c +1 -1
@@ -1177,7 +1177,7 @@ int w1_process(void *data)__set_current_state (TASK_INTERRUPTIBLE ); -/* hold list_mutex until after interruptible to prevent loosing +/* hold list_mutex until after interruptible to prevent losing * the wakeup signal when async_cmd is added. */ mutex_unlock (&dev->list_mutex);
drivers/w1/w1_family.c +1 -1
@@ -67,7 +67,7 @@ void w1_unregister_family(struct w1_family *fent) }spin_unlock (&w1_flock); -/* deatch devices using this family code */ +/* detach devices using this family code */ w1_reconnect_slaves (fent,0 );while (atomic_read (&fent->refcnt)) {
drivers/w1/w1_netlink.h +1 -1
@@ -14,7 +14,7 @@/** * enum w1_cn_msg_flags - bitfield flags for struct cn_msg.flags * -* @W1_CN_BUNDLE: Request bundling replies into fewer messagse. Be prepared +* @W1_CN_BUNDLE: Request bundling replies into fewer messages. Be prepared * to handle multiple struct cn_msg, struct w1_netlink_msg, and * struct w1_netlink_cmd in one packet. */
Signature · 1 line
2.55.0
Krzysztof Kozlowski
maintainerRe: [PATCH] w1: fix spelling mistakes in comments across the subsystem
Quoted 8 lines · Ivy Lopez
Following up on a prior patch that only fixed
w1_netlink.c, sweep the rest of the w1 subsystem for the same class of comment typos:
"loosing" -> "losing", "deatch" -> "detach", "messagse" -> "messages", "continusly" -> "continuously", "attribut" -> "attribute", "deactive" -> "deactivate", "determing" -> "determining", "discrepency" -> "discrepancy", "rerurn" -> "return".No functional change.
I don't know how to apply this - getting series it pulls power supply:
Looking up [email protected]
Breaking thread to remove parents of [email protected]
Checking for newer revisions
Grabbing search results from lore.kernel.org
Added from v2: 1 patches
Analyzing 5 messages in the thread
Looking for additional code-review trailers on lore.kernel.org Analyzing 3 code-review messages
Will use the latest revision: v2
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2] power: supply: ds2760_battery: convert to devm-managed
workqueue and pm_notifier
+ Link:
https://patch.msgid.link/[email protected]
+ Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
✗ BADSIG: DKIM/gmail.com
---
Total patches: 1
---
Applying: power: supply: ds2760_battery: convert to devm-managed workqueue and pm_notifier
Patch failed at 0001 power: supply: ds2760_battery: convert to devm-managed workqueue and pm_notifier
error: patch failed: drivers/power/supply/ds2760_battery.c:695
error: drivers/power/supply/ds2760_battery.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Getting only this with (even with -v1 argument):
Looking up [email protected] Checking for newer revisions
Grabbing search results from lore.kernel.org
Added from v2: 1 patches
Analyzing 5 messages in the thread
Looking for additional code-review trailers on lore.kernel.org Analyzing 3 code-review messages
Will use the latest revision: v2
You can pick other revisions using the -vN flag Specified msgid is not present in the series, cannot cherrypick
Something is messed with threading or message IDs of things you post. Also visible here:
https://lore.kernel.org/all/[email protected]/
Please send a v3.
Best regards,
Krzysztof