crypto: ccp - Fix the INIT_EX data file open failure
Subsystems (3)
PATCH v2 1/1 crypto: ccp - Fix the INIT_EX data file open failure
There are 2 common cases when INIT_EX data file might not be opened successfully and fail the sev initialization:
1. In user namespaces, normal user tasks (e.g. VMM) can change their current->fs->root to point to arbitrary directories. While init_ex_path is provided as a module param related to root file system. Solution: use the root directory of init_task to avoid accessing the wrong file.
2. Normal user tasks (e.g. VMM) don't have the privilege to access the INIT_EX data file. Solution: open the file as root and restore permissions immediately.
---
Changelog since v1:
- Added Fixes tag and Reviewed-By tag.
drivers/crypto/ccp/sev-dev.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
drivers/crypto/ccp/sev-dev.c +28 -2
@@ -23,6 +23,7 @@#include <linux/gfp.h> #include <linux/cpufeature.h> #include <linux/fs.h> +#include <linux/fs_struct.h> #include <asm/smp.h>
@@ -170,6 +171,31 @@ static void *sev_fw_alloc(unsigned long len)return page_address (page); } +static struct file *open_file_as_root (const char *filename,int flags,umode_t mode) +{ +struct file *fp; +struct path root; +struct cred *cred; +const struct cred *old_cred; + +task_lock (&init_task); +get_fs_root (init_task.fs, &root); +task_unlock (&init_task); + + cred =prepare_creds (); +if (!cred) +return ERR_PTR (-ENOMEM ); + cred->fsuid =GLOBAL_ROOT_UID ; + old_cred =override_creds (cred); + + fp =file_open_root (&root, filename, flags, mode); +path_put (&root); + +revert_creds (old_cred); + +return fp; +} +static int sev_read_init_ex_file (void ) {struct sev_device *sev = psp_master->sev_data;
@@ -181,7 +207,7 @@ static int sev_read_init_ex_file(void)if (!sev_init_ex_buffer)return -EOPNOTSUPP ; - fp =filp_open (init_ex_path,O_RDONLY ,0 ); + fp =open_file_as_root (init_ex_path,O_RDONLY ,0 );if (IS_ERR (fp)) {int ret =PTR_ERR (fp);
@@ -217,7 +243,7 @@ static void sev_write_init_ex_file(void)if (!sev_init_ex_buffer)return ; - fp =filp_open (init_ex_path,O_CREAT |O_WRONLY ,0600 ); + fp =open_file_as_root (init_ex_path,O_CREAT |O_WRONLY ,0600 );if (IS_ERR (fp)) { dev_err(sev->dev, "SEV: could not open file for write, error %ld\n",
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog
Tom Lendacky
maintainerQuoted 9 lines · Jacky Li
There are 2 common cases when
INIT_EXdata file might not be opened successfully and fail the sev initialization:1. In user namespaces, normal user tasks (e.g. VMM) can change their
current->fs->rootto point to arbitrary directories. Whileinit_ex_pathis provided as a module param related to root file system. Solution: use the root directory ofinit_taskto avoid accessing the wrong file.
Quoted 7 lines
2. Normal user tasks (e.g. VMM) don't have the privilege to access the
INIT_EXdata file. Solution: open the file as root and restore permissions immediately.Fixes 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")Signed-off-by Jacky Li <[email protected]>Reviewed-by Peter Gonda <[email protected]>
Looks good, just a quick question. Should there be any type of access checks before switching credentials? Should we check access to /dev/sev or such? Or is the capability to load the module enough?
Thanks,
Tom
Quoted 7 lines
---
Changelog since v1:
- Added Fixes tag and Reviewed-By tag.drivers/crypto/ccp/sev-dev.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
Quoted 15 lines · Tom Lendacky
Quoted 13 lines · Jacky Li
There are 2 common cases when
INIT_EXdata file might not be opened successfully and fail the sev initialization:1. In user namespaces, normal user tasks (e.g. VMM) can change their
current->fs->rootto point to arbitrary directories. Whileinit_ex_pathis provided as a module param related to root file system. Solution: use the root directory ofinit_taskto avoid accessing the wrong file.2. Normal user tasks (e.g. VMM) don't have the privilege to access the
INIT_EXdata file. Solution: open the file as root and restore permissions immediately.
Quoted 7 lines
Quoted 3 lines
Fixes 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")Signed-off-by Jacky Li <[email protected]>Reviewed-by Peter Gonda <[email protected]>Looks good, just a quick question. Should there be any type of access checks before switching credentials? Should we check access to
/dev/sevor such? Or is the capability to load the module enough?
I thought this was fine because regardless of if an admin sets psp_init_on_probe=true or false, their intention is that people who have rw access to /dev/sev can use the commands which require the PSP to be init. In the case of psp_init_on_probe=false only rw users can cause the file to be created. The case of psp_init_on_probe=true seems a little less clear to me but if a user can modprobe ccp that seems like sufficient privilege to create the file. What do you think, Tom?
Tom Lendacky
maintainerQuoted 24 lines · Peter Gonda
Quoted 15 lines · Tom Lendacky
Quoted 13 lines · Jacky Li
There are 2 common cases when
INIT_EXdata file might not be opened successfully and fail the sev initialization:1. In user namespaces, normal user tasks (e.g. VMM) can change their
current->fs->rootto point to arbitrary directories. Whileinit_ex_pathis provided as a module param related to root file system. Solution: use the root directory ofinit_taskto avoid accessing the wrong file.2. Normal user tasks (e.g. VMM) don't have the privilege to access the
INIT_EXdata file. Solution: open the file as root and restore permissions immediately.Quoted 7 lines
Quoted 3 lines
Fixes 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")Signed-off-by Jacky Li <[email protected]>Reviewed-by Peter Gonda <[email protected]>Looks good, just a quick question. Should there be any type of access checks before switching credentials? Should we check access to
/dev/sevor such? Or is the capability to load the module enough?
Quoted 7 lines
I thought this was fine because regardless of if an admin sets psp_init_on_probe=true or false, their intention is that people who have rw access to
/dev/sevcan use the commands which require the PSP to be init. In the case of psp_init_on_probe=false only rw users can cause the file to be created. The case of psp_init_on_probe=true seems a little less clear to me but if a user can modprobe ccp that seems like sufficient privilege to create the file. What do you think, Tom?
Sorry, lost this in my Inbox... That seems reasonable to me, let me add my ack to the first email.
Thanks,
Tom
Quoted 9 lines · Jacky Li
There are 2 common cases when
INIT_EXdata file might not be opened successfully and fail the sev initialization:1. In user namespaces, normal user tasks (e.g. VMM) can change their
current->fs->rootto point to arbitrary directories. Whileinit_ex_pathis provided as a module param related to root file system. Solution: use the root directory ofinit_taskto avoid accessing the wrong file.
Quoted 7 lines
2. Normal user tasks (e.g. VMM) don't have the privilege to access the
INIT_EXdata file. Solution: open the file as root and restore permissions immediately.Fixes 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")Signed-off-by Jacky Li <[email protected]>Reviewed-by Peter Gonda <[email protected]>
Quoted 7 lines
---
Changelog since v1:
- Added Fixes tag and Reviewed-By tag.drivers/crypto/ccp/sev-dev.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
Herbert Xu
maintainerQuoted 16 lines · Jacky Li
There are 2 common cases when
INIT_EXdata file might not be opened successfully and fail the sev initialization:1. In user namespaces, normal user tasks (e.g. VMM) can change their
current->fs->rootto point to arbitrary directories. Whileinit_ex_pathis provided as a module param related to root file system. Solution: use the root directory ofinit_taskto avoid accessing the wrong file.2. Normal user tasks (e.g. VMM) don't have the privilege to access the
INIT_EXdata file. Solution: open the file as root and restore permissions immediately.Fixes 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")Signed-off-by Jacky Li <[email protected]>Reviewed-by Peter Gonda <[email protected]>
Quoted 6 lines
---
Changelog since v1:
- Added Fixes tag and Reviewed-By tag.drivers/crypto/ccp/sev-dev.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt