CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.cat
PATCH 1/1 CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.cat
From 9ef0701c8f161c8582bd6084e5d2706a0ad92d00 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH] CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.cat
linux-kernel-hardware.cat is not present in the branch expected to be merged in 4.17 window.
--- CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
CodeSamples/formal/herd/Makefile +1 -1
@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)
Signature · 1 line
2.7.4
Quoted 7 lines · Akira Yokosawa
Quoted 1 line
From
9ef0701c8f161c8582bd6084e5d2706a0ad92d00Mon Sep 17 00:00:00 2001From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH] CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.catlinux-kernel-hardware.cat is not present in the branch expected to be merged in 4.17 window.
Good point, but it might be added at some later date. This does raise the question of whether it makes any sense to try to keep up with the Linux-kernel memory model once that model is in mainline. ;-)
Thanx, Paul
Quoted 21 lines
Signed-off-by Akira Yokosawa <[email protected]>--- CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)CodeSamples/formal/herd/Makefile +1
-1@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)Signature · 1 line
2.7.4
Quoted 10 lines · Paul E. McKenney
Quoted 7 lines · Akira Yokosawa
Quoted 1 line
From
9ef0701c8f161c8582bd6084e5d2706a0ad92d00Mon Sep 17 00:00:00 2001From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH] CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.catlinux-kernel-hardware.cat is not present in the branch expected to be merged in 4.17 window.
Good point, but it might be added at some later date.
Let me rephrase the change log. How about the following reasoning.
The target "run-herd7" doesn't depend on linux-kernel-hardware.cat. So remove it from the dependency list.
This change also makes the target compatible with memory-consistency-model branch[1] intended to be in Linux 4.17 window at the moment.
NOTE: They say https://github.com/aparri/memory-model.git won't be updated any more.
NOTE: We can add a target to run litmus tests with linux-kernel-hardware.cat once it is added in mainline or a prospective branch.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git lkmm
Quoted 3 lines
This does raise
the question of whether it makes any sense to try to keep up with the Linux-kernel memory model once that model is in mainline. ;-)
You mean litmus tests used in perfbook and their explanation?
Thanks, Akira
Quoted 25 lines
Thanx, Paul
Quoted 21 lines
Signed-off-by Akira Yokosawa <[email protected]>--- CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)CodeSamples/formal/herd/Makefile +1
-1@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)Signature · 1 line
2.7.4
Quoted 10 lines · Akira Yokosawa
Quoted 9 lines · Paul E. McKenney
Quoted 7 lines · Akira Yokosawa
Quoted 1 line
From
9ef0701c8f161c8582bd6084e5d2706a0ad92d00Mon Sep 17 00:00:00 2001From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH] CodeSamples/formal/herd: Remove dependency to linux-kernel-hardware.catlinux-kernel-hardware.cat is not present in the branch expected to be merged in 4.17 window.
Quoted 8 lines
Quoted 1 line
Good point, but it might be added at some later date.
Let me rephrase the change log. How about the following reasoning.
The target "run-herd7" doesn't depend on linux-kernel-hardware.cat. So remove it from the dependency list.
This change also makes the target compatible with memory-consistency-model branch[1] intended to be in Linux 4.17 window at the moment.
What I get for looking at patches too early in the morning! For some reason I got the idea that you were removing linux-kernel-hardware.cat itself.
Quoted 7 lines
NOTE: They say https://github.com/aparri/memory-model.git won't be updated any more.
NOTE: We can add a target to run litmus tests with linux-kernel-hardware.cat once it is added in mainline or a prospective branch.
[1]
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitlkmm
This would be quite good, but let's wait until it gets to mainline.
But yes, please do update the change log as above and I will be happy to apply the result.
Quoted 5 lines
Quoted 3 lines
This does raise
the question of whether it makes any sense to try to keep up with the Linux-kernel memory model once that model is in mainline. ;-)You mean litmus tests used in perfbook and their explanation?
I mean the models themselves in CodeSamples/formal/herd/memory-model. Except that yes, this is a symbolic link. So clearly not a problem at all.
Never mind!!! Like I said, too early this morning! :-/
Thanx, Paul
Quoted 28 lines
Thanks, Akira
Quoted 25 lines
Thanx, Paul
Quoted 21 lines
Signed-off-by Akira Yokosawa <[email protected]>--- CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)CodeSamples/formal/herd/Makefile +1
-1@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)Signature · 1 line
2.7.4
PATCH v2 1/1 CodeSamples/formal/herd: Remove dependency on linux-kernel-hardware.cat
In reply to Akira YokosawaFrom 8ba8747211c2793fae6d280833190bbe74486198 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH v2] CodeSamples/formal/herd: Remove dependency on linux-kernel-hardware.cat
The target "run-herd7" doesn't depend on linux-kernel-hardware.cat. So remove it from the dependency list.
This change also makes the target compatible with the provisional memory-consistency model branch [1] intended to be merged into Linux mainline.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git lkmm
---
Changes in v2:
Rephrase change log to clarify the intention of the change.
--
CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
CodeSamples/formal/herd/Makefile +1 -1
@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)
Signature · 1 line
2.7.4
Re: [PATCH v2] CodeSamples/formal/herd: Remove dependency on linux-kernel-hardware.cat
Quoted 11 lines · Akira Yokosawa
Quoted 1 line
From
8ba8747211c2793fae6d280833190bbe74486198Mon Sep 17 00:00:00 2001From: Akira Yokosawa <[email protected]>
Date: Tue, 20 Feb 2018 00:09:53 +0900
Subject: [PATCH v2] CodeSamples/formal/herd: Remove dependency on linux-kernel-hardware.catThe target "run-herd7" doesn't depend on linux-kernel-hardware.cat. So remove it from the dependency list.
This change also makes the target compatible with the provisional memory-consistency model branch [1] intended to be merged into Linux mainline.
Quoted 3 lines
[1]
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitlkmmSigned-off-by Akira Yokosawa <[email protected]>
Applied and pushed, thank you!
Thanx, Paul
Quoted 24 lines
---
Changes in v2:
Rephrase change log to clarify the intention of the change.
--CodeSamples/formal/herd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)CodeSamples/formal/herd/Makefile +1
-1@@ -31,7 +31,7 @@ LKMM_DIR := memory-model LKMM_FILES := linux-kernel.bell linux-kernel.cat linux-kernel.cfg \ - linux-kernel.def linux-kernel-hardware.cat lock.cat + linux-kernel.def lock.cat LKMM_LIST := $(addprefix $(LKMM_DIR)/,$(LKMM_FILES)) HERD_DIR := $(shell pwd) HERD7_CMD := $(shell which herd7)Signature · 1 line
2.7.4