Skip to contentSkip to conversation

Integer types

DISCUSSION Jeff Sipek 3 participants 4 messages Dec 31, 2005 – Jan 1, 2006

lore
Share & tools
lore

Jeff Sipek

author
#0 lore raw

What's the prefered integer type for kernel code?

* u8, u16, ...
* uint8_t, uint16_t, ...
* u_int8_t, t_int16_t, ...

Thanks,
Josef "Jeff" Sipek.

#1 lore raw
Quoted 7 lines · Jeff Sipek

What's the prefered integer type for kernel code?

* u8, u16, ...
* uint8_t, uint16_t, ...
* u_int8_t, t_int16_t, ...

From the above list, the first ones. See

http://article.gmane.org/gmane.linux.kernel/259313. Please note that there's also __le32 and __be32 for variables that have fixed byte ordering.

Pekka

#2 lore raw
Quoted 8 lines · Pekka Enberg
Quoted 3 lines

* u8, u16, ...
* uint8_t, uint16_t, ...
* u_int8_t, t_int16_t, ...

From the above list, the first ones. See
http://article.gmane.org/gmane.linux.kernel/259313. Please note that there's also __le32 and __be32 for variables that have fixed byte ordering.

As ever, however, be aware that our esteemed leader is fickle. Especially when he's wrong, as he was on that occasion.

The bit about namespace pollution is a red herring -- that's a good enough reason for using '__u8', '__u16' etc. in those headers which are user-visible and which mustn't require standard types, but it's no excuse for the existence of the 'u8', 'u16' forms in code and headers which _aren't_ user-visible.

The reason for the existence of the 'uXX' form is because once upon a time, the kernel was buildable with compilers which predated the C99 standard types. It remains for historical reasons and because some people (especially Linus) have some kind of emotional attachment to it.

The choice of whether to use 'uXX' or to use the proper standard 'uintXX_t' types is to a large extent a matter of the individual developer's taste. If you're writing large chunks of your own code, then do as you see fit; if you're modifying existing code, then use what's there already.

Signature · 1 line
dwmw2
#3 lore raw

Hi,

Quoted 8 lines · Pekka Enberg
Quoted 8 lines
Quoted 3 lines

* u8, u16, ...
* uint8_t, uint16_t, ...
* u_int8_t, t_int16_t, ...

From the above list, the first ones. See
http://article.gmane.org/gmane.linux.kernel/259313. Please note that there's also __le32 and __be32 for variables that have fixed byte ordering.

Quoted 2 lines · David Woodhouse

As ever, however, be aware that our esteemed leader is fickle. Especially when he's wrong, as he was on that occasion.

Maybe so but some maintainers do require them. So as for the original question, I would still recommend the u8 ones as they are most likely merged as is.

Pekka