Skip to contentSkip to conversation

net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

PATCH Applied Heiner Kallweit 2 participants 2 messages Feb 2, 2023 – Feb 4, 2023

Subsystems (4)
Networking Network drivers Arm/Amlogic Meson SoC support Ethernet PHY
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH v2 1/1 net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

Jerome provided the information that also the GXL internal PHY doesn't support MMD register access and EEE. MMD reads return 0xffff, what results in e.g. completely wrong ethtool --show-eee output. Therefore use the MMD dummy stubs.

v2:
- Change Fixes tag to the actually offending commit. As 4.9 is EOL this fix will apply on all stable versions.

Fixes d853d145ea3e ("net: phy: add an option to disable EEE advertisement")
Suggested-by Jerome Brunet <[email protected]>
Signed-off-by Heiner Kallweit <[email protected]>
---
 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad7..fbf5f2416 100644
@@ -261,6 +261,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	}, {
 		PHY_ID_MATCH_EXACT(0x01803301),
 		.name		= "Meson G12A Internal PHY",
Signature · 7 lines
2.39.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
CI Applied
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 2 Feb 2023 21:45:36 +0100 you wrote:

Jerome provided the information that also the GXL internal PHY doesn't support MMD register access and EEE. MMD reads return 0xffff, what results in e.g. completely wrong ethtool --show-eee output. Therefore use the MMD dummy stubs.

v2:
- Change Fixes tag to the actually offending commit. As 4.9 is EOL this fix will apply on all stable versions.

[...]

Here is the summary with links:
- [v2,net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

    https://git.kernel.org/netdev/net/c/69ff53e4a4c9

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html