Skip to contentSkip to conversation

flex-native: create a wrapper script for sstate installation

PATCH In review Kevin Tian 2 participants 3 messages Jan 5, 2011 – Jan 6, 2011

lore
Share & tools
lore

Kevin Tian

author
#0 lore raw

PATCH 2/4 flex-native: create a wrapper script for sstate installation

flex-native encodes M4 staging path in its binary, which breaks sstate installation in a new build environment. Use create_wrapper to create a wrapper script which explicitly set M4 environmental variable to the new path

---
 meta/recipes-devtools/flex/flex.inc       |    6 ++++++
 meta/recipes-devtools/flex/flex_2.5.35.bb |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-devtools/flex/flex.inc +6 -0
index 93fa7e8..e5e423e 100644
@@ -11,3 +11,9 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 "
 
 inherit autotools
 
+SYSROOT_PREPROCESS_FUNCS_append_virtclass-native = " flex_path_fixup"
+
+flex_path_fixup() {
+	create_wrapper ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/${bindir}/flex \
+		M4=${STAGING_BINDIR_NATIVE}/m4
+}
meta/recipes-devtools/flex/flex_2.5.35.bb +1 -1
index 4fdce33..28a4f1f 100644
@@ -1,5 +1,5 @@
 require flex.inc
-PR = "r1"
+PR = "r2"
 LICENSE="BSD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=e4742cf92e89040b39486a6219b68067"
 BBCLASSEXTEND = "native"
Signature · 1 line
1.6.0.4
#1 lore raw

Hi Kevin,

Quoted 16 lines · Kevin Tian

flex-native encodes M4 staging path in its binary, which breaks sstate installation in a new build environment. Use create_wrapper to create a wrapper script which explicitly set M4 environmental variable to the new path

---
 meta/recipes-devtools/flex/flex.inc       |    6 ++++++
 meta/recipes-devtools/flex/flex_2.5.35.bb |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-devtools/flex/flex.inc +0 -0
index 93fa7e8..e5e423e 100644

meta/recipes-devtools/flex/flex.inc SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 " · line 19

Quoted 9 lines
meta/recipes-devtools/flex/flex.inc +6 -0
@@ -11,3 +11,9 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 "
 
 inherit autotools
 
+SYSROOT_PREPROCESS_FUNCS_append_virtclass-native = " flex_path_fixup"
+
+flex_path_fixup() {
+	create_wrapper ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/${bindir}/flex \
+		M4=${STAGING_BINDIR_NATIVE}/m4
+}

I was thinking about this a little further and I'd prefer to avoid using the SYSROOT_*PROCESS_FUNCS if at all possible. How about something like:

do_install_append_virtclass-native() {
	create_wrapper ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/${bindir}/flex \
		M4=${STAGING_BINDIR_NATIVE}/m4
}

?

Cheers,

Richard

#2 lore raw
Quoted 34 lines

From: Richard Purdie [mailto:[email protected]]
Sent: Thursday, January 06, 2011 6:14 PM
Hi Kevin,

Quoted 16 lines · Kevin Tian

flex-native encodes M4 staging path in its binary, which breaks sstate installation in a new build environment. Use create_wrapper to create a wrapper script which explicitly set M4 environmental variable to the new path

---
 meta/recipes-devtools/flex/flex.inc       |    6 ++++++
 meta/recipes-devtools/flex/flex_2.5.35.bb |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-devtools/flex/flex.inc +0 -0
index 93fa7e8..e5e423e 100644

meta/recipes-devtools/flex/flex.inc SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 " · line 19

Quoted 9 lines
meta/recipes-devtools/flex/flex.inc +6 -0
@@ -11,3 +11,9 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 "
 
 inherit autotools
 
+SYSROOT_PREPROCESS_FUNCS_append_virtclass-native = " flex_path_fixup"
+
+flex_path_fixup() {
+	create_wrapper ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/${bindir}/flex \
+		M4=${STAGING_BINDIR_NATIVE}/m4
+}

I was thinking about this a little further and I'd prefer to avoid using the SYSROOT_*PROCESS_FUNCS if at all possible. How about something like:

Quoted 5 lines
do_install_append_virtclass-native() {
	create_wrapper ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/${bindir}/flex \
		M4=${STAGING_BINDIR_NATIVE}/m4
}

sure, let me do some quick test.

Thanks
Kevin