Skip to contentSkip to conversation

package/mdevd: fix build with glibc >= 2.43

PATCH In review Bernd Kuhls 2 participants 2 messages Apr 4

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mdevd: fix build with glibc >= 2.43

Buildroot commit 227378b5930b681c79a13476ae60a98753a98a03 bumped glibc to 2.43 causing a build error in mdevd:

src/mdevd/mdevd.c: In function 'act_on_event':
src/mdevd/mdevd.c:797:36: error: assignment of read-only location
'*(const char *)strchr(ud->devname, 10)'
797 | *strchr(ud->devname, '\n') = 0 ;

Add upstream commit to fix the problem.

Fixes:
https://autobuild.buildroot.net/results/92b/92b9b307996a44b66dc3f7f7d35dd74816b62480/

---
 ...-Some-libcs-have-a-char-const-strchr.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/mdevd/0001-Some-libcs-have-a-char-const-strchr.patch
package/mdevd/0001-Some-libcs-have-a-char-const-strchr.patch new file +29 -0
new file mode 100644
index 0000000000..f039d34a05
@@ -0,0 +1,29 @@
+From 4594ed03e4ced04cb914c8fccad1ffab41cc4ee5 Mon Sep 17 00:00:00 2001
+From: Laurent Bercot <[email protected]>
+Date: Wed, 18 Mar 2026 15:45:17 +0000
+Subject:  Some libcs have a char const *strchr()? need to investigate
+
+Upstream: https://git.skarnet.org/cgi-bin/cgit.cgi/mdevd/commit/?id=4594ed03e4ced04cb914c8fccad1ffab41cc4ee5
+
+[Bernd: removed non-related content of the upstream commit]
+Signed-off-by: Bernd Kuhls <[email protected]>
+---
+ src/mdevd/mdevd.c |  2 +-
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/mdevd/mdevd.c b/src/mdevd/mdevd.c
+index aecd5a7..7df3aaf 100644
+--- a/src/mdevd/mdevd.c
++++ b/src/mdevd/mdevd.c
+@@ -794,7 +794,7 @@ static inline int act_on_event (struct uevent_s const *event, unsigned int actio
+       if (ud->devname)
+       {
+         ud->devname += 9 ;
+-        *strchr(ud->devname, '\n') = 0 ;
++        *(char *)strchr(ud->devname, '\n') = 0 ;
+       }
+     }
+     if (!ud->devname) ud->devname = basename(ud->sysdevpath) ;
+-- 
+cgit v1.2.3-70-g09d2
+
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines · Bernd Kuhls

Buildroot commit 227378b5930b681c79a13476ae60a98753a98a03 bumped glibc to 2.43 causing a build error in mdevd:

src/mdevd/mdevd.c: In function 'act_on_event':
src/mdevd/mdevd.c:797:36: error: assignment of read-only location
'*(const char *)strchr(ud->devname, 10)'
797 | *strchr(ud->devname, '\n') = 0 ;

Quoted 6 lines

Add upstream commit to fix the problem.

Fixes:
https://autobuild.buildroot.net/results/92b/92b9b307996a44b66dc3f7f7d35dd74816b62480/

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot