Skip to contentSkip to conversation

be2iscsi: use NULL instead of 0 for pointer

PATCH In review Daeseok Youn 2 participants 3 messages Feb 21, 2014 – Apr 8, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 be2iscsi: use NULL instead of 0 for pointer

Quoted 1 line

From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

sparse says:

drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer

---
 drivers/scsi/be2iscsi/be_cmds.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/be2iscsi/be_cmds.c +3 -3
index 3338391..1ec9793 100644
@@ -24,9 +24,9 @@
 int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)
 {
 	u32 sreset;
-	u8 *pci_reset_offset = 0;
-	u8 *pci_online0_offset = 0;
-	u8 *pci_online1_offset = 0;
+	u8 *pci_reset_offset = NULL;
+	u8 *pci_online0_offset = NULL;
+	u8 *pci_online1_offset = NULL;
 	u32 pconline0 = 0;
 	u32 pconline1 = 0;
 	u32 i;
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw

-----Original Message-----
From: Daeseok Youn [mailto:[email protected]]
Sent: Thursday, February 20, 2014 5:13 PM
To: [email protected]
Cc: Jayamohan Kallickal; [email protected]; [email protected]
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

Quoted 1 line

From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

sparse says:

drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer

---
 drivers/scsi/be2iscsi/be_cmds.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/be2iscsi/be_cmds.c +3 -4
@@ -24,9 +24,9 @@
 int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)  {
 	u32 sreset;
-	u8 *pci_reset_offset = 0;
-	u8 *pci_online0_offset = 0;
-	u8 *pci_online1_offset = 0;
+	u8 *pci_reset_offset = NULL;
+	u8 *pci_online0_offset = NULL;
+	u8 *pci_online1_offset = NULL;
 	u32 pconline0 = 0;
 	u32 pconline1 = 0;
 	u32 i;
--

1.7.9.5

--

#2 lore raw

Hi,

This patch didn't apply. Please check for me.
Thanks.
Daeseok Youn

2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal <[email protected]>:

Quoted 49 lines

-----Original Message-----
From: Daeseok Youn [mailto:[email protected]]
Sent: Thursday, February 20, 2014 5:13 PM
To: [email protected]
Cc: Jayamohan Kallickal; [email protected]; [email protected]
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

sparse says:

drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer

---
 drivers/scsi/be2iscsi/be_cmds.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/be2iscsi/be_cmds.c +3 -4
@@ -24,9 +24,9 @@
 int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)  {
        u32 sreset;
-       u8 *pci_reset_offset = 0;
-       u8 *pci_online0_offset = 0;
-       u8 *pci_online1_offset = 0;
+       u8 *pci_reset_offset = NULL;
+       u8 *pci_online0_offset = NULL;
+       u8 *pci_online1_offset = NULL;
        u32 pconline0 = 0;
        u32 pconline1 = 0;
        u32 i;
--

1.7.9.5

--