Skip to contentSkip to conversation

ubifs: remove SLAB_MEM_SPREAD flag usage

PATCH In review [email protected] 3 participants 4 messages Feb 24, 2024 – Feb 26, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ubifs: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
 fs/ubifs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ubifs/super.c +2 -2
index f780729eec06..8ae7648021a8 100644
@@ -2433,8 +2433,8 @@ static int __init ubifs_init(void)
 
 	ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab",
 				sizeof(struct ubifs_inode), 0,
-				SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT |
-				SLAB_ACCOUNT, &inode_slab_ctor);
+				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
+				&inode_slab_ctor);
 	if (!ubifs_inode_slab)
 		return -ENOMEM;
 
Signature · 1 line
2.40.1
#1 lore raw

----- Ursprüngliche Mail -----

Quoted 9 lines

Von: "chengming zhou" <[email protected]>
An: "richard" <[email protected]>
CC: "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>, "linux-mm" <[email protected]>, [email protected], "roman gushchin" <[email protected]>, "Xiongwei Song" <[email protected]>, "chengming zhou" <[email protected]>, "Chengming Zhou" <[email protected]>
Gesendet: Samstag, 24. Februar 2024 14:52:17
Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

Quoted 6 lines

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Applied.
Next time please add a reference that makes very clear why such a flag is no longer needed.
It took me a few minutes to figure why SLAB_MEM_SPREAD is now a no-op.

Thanks,
//richard

#2 lore raw
Quoted 15 lines · Richard Weinberger

----- Ursprüngliche Mail -----

Quoted 14 lines

Von: "chengming zhou" <[email protected]>
An: "richard" <[email protected]>
CC: "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>, "linux-mm" <[email protected]>, [email protected], "roman gushchin" <[email protected]>, "Xiongwei Song" <[email protected]>, "chengming zhou" <[email protected]>, "Chengming Zhou" <[email protected]>
Gesendet: Samstag, 24. Februar 2024 14:52:17
Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Quoted 7 lines
Quoted 1 line

Applied.
Next time please add a reference that makes very clear why such a flag is no longer needed.
It took me a few minutes to figure why SLAB_MEM_SPREAD is now a no-op.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

Quoted 3 lines

Thanks,
//richard

reviewer Reviewed-by on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 10 lines · 在 2024/2/24 21:52, [email protected] 写道:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
  fs/ubifs/super.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 16 lines
fs/ubifs/super.c +2 -2
index f780729eec06..8ae7648021a8 100644
@@ -2433,8 +2433,8 @@ static int __init ubifs_init(void)
 
  	ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab",
  				sizeof(struct ubifs_inode), 0,
-				SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT |
-				SLAB_ACCOUNT, &inode_slab_ctor);
+				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
+				&inode_slab_ctor);
  	if (!ubifs_inode_slab)
  		return -ENOMEM;