DRM support for addressing >32 bits on 32 bit cores (Radeon DRM driver+TTM)
Subsystems (3)
PATCH 1/1 DRM support for addressing >32 bits on 32 bit cores (Radeon DRM driver+TTM)
Hello,
I was advised to send this stuff here (
https://bugs.freedesktop.org/show_bug.cgi?id=18154 ).
The patches are tested with a P3041 board and a TURKS radeon card. It appears that the radeon driver is already generic enough (so no major changes were needed there), fortunately.
I think esp. the TTM patch is clearly needed, but it may be incomplete...
Signature · 3 lines
Best regards | S pozdravom | Mit freundlichen Grüßen | Cordialement Andrej Krutak
Allow > 32-bit physical addresses in mmio base info text.
drivers/gpu/drm/radeon/radeon_device.c +2 -2
@@ -258,7 +258,7 @@ int radeon_doorbell_init(struct radeon_dif (rdev->doorbell.ptr ==NULL ) {return -ENOMEM ; } -DRM_INFO ("doorbell mmio base: 0x%08X\n" , (uint32_t )rdev->doorbell.base); +DRM_INFO ("doorbell mmio base: 0x%016llX\n" , (uint64_t )rdev->doorbell.base);DRM_INFO ("doorbell mmio size: %u\n" , (unsigned )rdev->doorbell.size); rdev->doorbell.num_pages = rdev->doorbell.size /PAGE_SIZE ;
@@ -1271,7 +1271,7 @@ int radeon_device_init(struct radeon_devif (rdev->rmmio ==NULL ) {return -ENOMEM ; } -DRM_INFO ("register mmio base: 0x%08X\n" , (uint32_t )rdev->rmmio_base); +DRM_INFO ("register mmio base: 0x%016llX\n" , (uint64_t )rdev->rmmio_base);DRM_INFO ("register mmio size: %u\n" , (unsigned )rdev->rmmio_size);/* doorbell bar mapping */
Allow > 32-bit physical addresses for TTM bus placement.
include/drm/ttm/ttm_bo_api.h +1 -1
@@ -82,7 +82,7 @@ struct ttm_placement {*/ struct ttm_bus_placement {void *addr; -unsigned long base; +resource_size_t base;unsigned long size;unsigned long offset;bool is_iomem;
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Andrej Krutak
I was advised to send this stuff here (
https://bugs.freedesktop.org/show_bug.cgi?id=18154 ).
Please send them as Git patches with a proper commit log. Preferably with git send-email, but at least generated by git format-patch.
See Documentation/SubmittingPatches for more details.
Signature · 2 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer