Add Apple Mac System Management Controller GPIOs
Subsystems (7)
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
In reply to Rob HerringQuoted 90 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Quoted 1 line
I'm quite sure Lee is only going to want to apply the mfd bits.
Indeed. I can't seem to make Lee care... All the schemas should really be applied together.
Quoted 9 lines
Quoted 3 lines
Then
what do we do with the other bits? GPIO stuff via the GPIO tree, then wait a cycle before the rest can be merged. Or what?The schemas must be picked up in the same cycle. I don't care so much if subsystem maintainers' trees have warnings if they don't care, but I do care for linux-next. If the subsystem bits aren't picked up, then I'll pick them up if it comes to that.
We can take all the schemas and DT changes via asahi-soc if that works for you. This also lets us move forward with more related DT changes that would apply on top of things already in that branch. Then Lee only has to take the mfd core bits (and possibly the RTKit platform part, or we can figure something else out for that).
- Hector
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
In reply to Rob HerringQuoted 76 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story.
Anyway, I've washed my hands of this farce with this series. I'm not planning to post another version of it. I've had enough of this crap.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 81 lines · Russell King (Oracle)
Quoted 80 lines · Rob Herring
Quoted 78 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
Quoted 7 lines
Quoted 4 lines
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story.
Hm, where do you see a message I told you to always have examples? Maybe in some discussion I mentioned that examples are desired, but not always. There is no point in having example in MFD child device schema if it is already part of the parent MFD binding, where it is actually required for complete picture.
Best regards,
Krzysztof
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 87 lines · Krzysztof Kozlowski
Quoted 86 lines · Russell King (Oracle)
Quoted 84 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Quoted 8 lines
Quoted 2 lines
Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story.
Hm, where do you see a message I told you to always have examples? Maybe in some discussion I mentioned that examples are desired, but not always. There is no point in having example in MFD child device schema if it is already part of the parent MFD binding, where it is actually required for complete picture.
and
For the GPIO macsec binding. So I'm getting contradictory information. First you say that I need an example in the gpio macsec DT binding yaml document.
Now I'm told it should go in the parent.
Make up your bloody minds and stop pissing me about. This is why I've given up trying to get this in.
Getting a consistent message would be nice, but it seems impossible.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 97 lines · Russell King (Oracle)
Quoted 87 lines · Krzysztof Kozlowski
Quoted 86 lines · Russell King (Oracle)
Quoted 84 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Quoted 8 lines
Quoted 2 lines
Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story.
Hm, where do you see a message I told you to always have examples? Maybe in some discussion I mentioned that examples are desired, but not always. There is no point in having example in MFD child device schema if it is already part of the parent MFD binding, where it is actually required for complete picture.
Quoted 3 lines
and
That was independent schema, no references to MFD, thus my comment. If you post such stuff alone without indication it is part of MFD, what do you expect from reviewers?
Quoted 2 lines
Which was comment about MFD, right? It is expected to have example for MFD. I never said it is mandatory for every schema, which you implied in previous mailing.
Quoted 4 lines
For the GPIO macsec binding. So I'm getting contradictory information. First you say that I need an example in the gpio macsec DT binding yaml document.
First you split patches making reviewers life difficult. Then reviewers don't get entire concept and they answer based what they got.
Quoted 2 lines
Now I'm told it should go in the parent.
After posting entire patchset with context you can get better review, yes, that's right.
Quoted 3 lines
Make up your bloody minds and stop pissing me about. This is why I've given up trying to get this in.
I don't think it is constructive to discuss this with you anymore.
Quoted 3 lines
Getting a consistent message would be nice, but it seems impossible.
Best regards,
Krzysztof
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 125 lines · Krzysztof Kozlowski
Quoted 97 lines · Russell King (Oracle)
Quoted 87 lines · Krzysztof Kozlowski
Quoted 86 lines · Russell King (Oracle)
Quoted 84 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Quoted 8 lines
Quoted 2 lines
Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story.
Hm, where do you see a message I told you to always have examples? Maybe in some discussion I mentioned that examples are desired, but not always. There is no point in having example in MFD child device schema if it is already part of the parent MFD binding, where it is actually required for complete picture.
Quoted 3 lines
and
That was independent schema, no references to MFD, thus my comment. If you post such stuff alone without indication it is part of MFD, what do you expect from reviewers?
Quoted 2 lines
Which was comment about MFD, right? It is expected to have example for MFD. I never said it is mandatory for every schema, which you implied in previous mailing.
Quoted 4 lines
For the GPIO macsec binding. So I'm getting contradictory information. First you say that I need an example in the gpio macsec DT binding yaml document.
First you split patches making reviewers life difficult. Then reviewers don't get entire concept and they answer based what they got.
Quoted 2 lines
Now I'm told it should go in the parent.
Quoted 13 lines
After posting entire patchset with context you can get better review, yes, that's right.
Quoted 3 lines
Make up your bloody minds and stop pissing me about. This is why I've given up trying to get this in.
I don't think it is constructive to discuss this with you anymore.
Quoted 3 lines
Getting a consistent message would be nice, but it seems impossible.
In which case you CLEARLY didn't read the cover message to that two patch series.
Again, YOU are giving contradictory information.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 7 lines · Russell King (Oracle)
Quoted 7 lines
Quoted 3 lines
Make up your bloody minds and stop pissing me about. This is why I've given up trying to get this in.
I don't think it is constructive to discuss this with you anymore.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
Getting a consistent message would be nice, but it seems impossible.
In which case you CLEARLY didn't read the cover message to that two patch series.
I have every day 100-200 new patches, so not every cover letter gets enough attention. Your did not say this is part of MFD, just mentioned some build dependency.
Anyway, job of submitter is to make the patch and its context readable to the reviewers.
There is literally nothing about including in parent MFD node in DT. Just take a look:
https://lore.kernel.org/all/[email protected]/
Or maybe you refer to this:
"previously posted before the last merge window."
Yes, so I will go through hundreds of emails from a week or months to satisfy you?
"this driver is dependent on the
Apple SMC driver in order to be buildable and usable."
The only hint... it's about driver, not MFD. Make it obvious for readers, not obvious for you.
"It is expected
that this Apple SMC driver will be merged via Lee's MFD tree."
Maybe there is dependency, maybe not, who the heck knows.
Quoted 1 line
Again, YOU are giving contradictory information.
Best regards,
Krzysztof
Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Quoted 35 lines · Krzysztof Kozlowski
Quoted 7 lines · Russell King (Oracle)
Quoted 7 lines
Quoted 3 lines
Make up your bloody minds and stop pissing me about. This is why I've given up trying to get this in.
I don't think it is constructive to discuss this with you anymore.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
Getting a consistent message would be nice, but it seems impossible.
In which case you CLEARLY didn't read the cover message to that two patch series.
I have every day 100-200 new patches, so not every cover letter gets enough attention. Your did not say this is part of MFD, just mentioned some build dependency.
Anyway, job of submitter is to make the patch and its context readable to the reviewers.
There is literally nothing about including in parent MFD node in DT. Just take a look:
https://lore.kernel.org/all/[email protected]/
Or maybe you refer to this:
"previously posted before the last merge window."
Yes, so I will go through hundreds of emails from a week or months to satisfy you?"this driver is dependent on the
Apple SMC driver in order to be buildable and usable."
Quoted 7 lines
The only hint... it's about driver, not MFD. Make it obvious for readers, not obvious for you.
"It is expected
that this Apple SMC driver will be merged via Lee's MFD tree."Maybe there is dependency, maybe not, who the heck knows.
Everything that needed to be said was said in the cover message.
I'm not going to bother continuing with this thread because there is nothing more to be said. This is getting utterly idiotic.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Lee Jones
maintainerRe: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
In reply to Rob HerringQuoted 85 lines · Rob Herring
Quoted 75 lines · Russell King (Oracle)
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop?
In any case, taking your comment literally,
"dt-bindings: mfd: add for Apple Mac System Management Controller"
makes no sense, so presumably you want something more than that.
In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed.
Quoted 56 lines
Quoted 41 lines
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yamlDocumentation/devicetree/bindings/mfd/apple,smc.yaml new file +29
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area +Documentation/devicetree/bindings/mfd/apple,smc.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/mfd/apple,smc.yaml new file +10
-0+ reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/gpio-macsmc.yamlSo this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.Quoted 3 lines
Quoted 1 line
The GPIO cannot go separate tree and this must be explicitly communicated.
Sigh, getting an order that is sensible is really bloody difficult.
It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices.
Quoted 4 lines
Quoted 1 line
I'm quite sure Lee is only going to want to apply the mfd bits.
Indeed. I can't seem to make Lee care... All the schemas should really be applied together.
I care about drivers. Happy to take the set as a whole if it helps.
Signature · 1 line
Lee Jones [李琼斯]
Rob Herring
maintainerRe: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
In reply to Russell King (Oracle)Quoted 8 lines · Russell King (Oracle)
Add a DT binding for the Apple Mac System Management Controller.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:./Documentation/devicetree/bindings/mfd/apple,smc.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/apple,smc.example.dtb: smc@23e400000: gpio: False schema does not allow {'gpio-controller': True, '#gpio-cells': [[2]]}
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/apple,smc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
PATCH v3 4/7 platform/apple: Add new Apple Mac SMC driver
In reply to Russell King (Oracle)From: Hector Martin <[email protected]>
This driver implements support for the SMC (System Management Controller) in Apple Macs. In contrast to the existing applesmc driver, it uses pluggable backends that allow it to support different SMC implementations, and uses the MFD subsystem to expose the core SMC functionality so that specific features (gpio, hwmon, battery, etc.) can be implemented by separate drivers in their respective downstream subsystems.
The initial RTKit backend adds support for Apple Silicon Macs (M1 et al). We hope a backend for T2 Macs will be written in the future (since those are not supported by applesmc), and eventually an x86 backend would allow us to fully deprecate applesmc in favor of this driver.
--- drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/apple/Kconfig | 34 ++ drivers/platform/apple/Makefile | 7 + drivers/platform/apple/macsmc-rtkit.c | 455 ++++++++++++++++++++++++++ 5 files changed, 499 insertions(+) create mode 100644 drivers/platform/apple/Kconfig create mode 100644 drivers/platform/apple/Makefile create mode 100644 drivers/platform/apple/macsmc-rtkit.c
drivers/platform/Kconfig +2 -0
@@ -15,4 +15,6 @@ source "drivers/platform/olpc/Kconfig" source "drivers/platform/surface/Kconfig" +source "drivers/platform/apple/Kconfig" + source "drivers/platform/x86/Kconfig"
drivers/platform/Makefile +1 -0
@@ -11,3 +11,4 @@ obj-$(CONFIG_OLPC_EC) += olpc/ obj-$(CONFIG_GOLDFISH) += goldfish/ obj-$(CONFIG_CHROME_PLATFORMS) += chrome/ obj-$(CONFIG_SURFACE_PLATFORMS) += surface/ +obj-$(CONFIG_APPLE_PLATFORMS) += apple/
drivers/platform/apple/Kconfig new file +34 -0
@@ -0,0 +1,34 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Apple Platform-Specific Drivers +# + +menuconfig APPLE_PLATFORMS + bool "Apple Mac Platform-Specific Device Drivers" + depends on ARCH_APPLE || X86 || COMPILE_TEST + default ARCH_APPLE + help + Say Y here to get to see options for platform-specific device drivers + for Apple devices. This option alone does not add any kernel code. + + If you say N, all options in this submenu will be skipped and disabled. + +if APPLE_PLATFORMS + +config APPLE_SMC_RTKIT + tristate "Apple SMC RTKit backend" + depends on ARCH_APPLE || (COMPILE_TEST && 64BIT) + depends on APPLE_RTKIT + default ARCH_APPLE + select MFD_MACSMC + help + Build support for the Apple System Management Controller found in + Apple Macs, communicated with via the RTKit backend. This is required + for Apple Silicon Macs. + + Say Y here if you have an Apple Silicon Mac. + + To compile this driver as a module, choose M here: the module will + be called macsmc-rtkit. + +endif
drivers/platform/apple/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for linux/drivers/platform/apple +# Apple Platform-Specific Drivers +# + +obj-$(CONFIG_APPLE_SMC_RTKIT) += macsmc-rtkit.o
drivers/platform/apple/macsmc-rtkit.c new file +455 -0
455 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH v3 5/7 arm64: dts: apple: Add SMC node to t8103 devicetrees
In reply to Russell King (Oracle)From: Hector Martin <[email protected]>
--- arch/arm64/boot/dts/apple/t8103.dtsi | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/apple/t8103.dtsi +27 -0
@@ -336,6 +336,33 @@ wdt: watchdog@23d2b0000 { interrupts = <AIC_IRQ 338 IRQ_TYPE_LEVEL_HIGH>; }; + smc: smc@23e400000 { + compatible = "apple,t8103-smc", "apple,smc"; + reg = <0x2 0x3e400000 0x0 0x4000>, + <0x2 0x3fe00000 0x0 0x100000>; + reg-names = "smc", "sram"; + mboxes = <&smc_mbox>; + + smc_gpio: gpio { + compatible = "apple,smc-gpio"; + gpio-controller; + #gpio-cells = <2>; + }; + }; + + smc_mbox: mbox@23e408000 { + compatible = "apple,t8103-asc-mailbox", "apple,asc-mailbox-v4"; + reg = <0x2 0x3e408000 0x0 0x4000>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 400 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 401 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 402 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 403 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "send-empty", "send-not-empty", + "recv-empty", "recv-not-empty"; + #mbox-cells = <0>; + }; + pinctrl_smc: pinctrl@23e820000 { compatible = "apple,t8103-pinctrl", "apple,pinctrl"; reg = <0x2 0x3e820000 0x0 0x4000>;
Signature · 1 line
2.30.2
PATCH v3 6/7 dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
In reply to Russell King (Oracle)Add the DT binding for the Apple Mac System Management Controller GPIOs.
--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +37 -0
@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller GPIO + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller GPIO block. + +properties: + compatible: + const: apple,smc-gpio + + gpio-controller: true + + '#gpio-cells': + const: 2 + +required: + - compatible + - gpio-controller + - '#gpio-cells' + +additionalProperties: false + +examples: + - | + gpio { + compatible = "apple,smc-gpio"; + gpio-controller; + #gpio-cells = <2>; + };
Signature · 1 line
2.30.2
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
Quoted 14 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yamlDocumentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +0
-0
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#
Does not look like you tested the bindings. Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 14
Quoted 10 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller GPIO + +maintainers: + - Hector Martin <[email protected]> + +description: + Apple Mac System Management Controller GPIO block. +
Best regards,
Krzysztof
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml
Quoted 14 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 10 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#Does not look like you tested the bindings. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions).
Oh ffs. DT bindings are utterly impossible to get correct.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
Quoted 25 lines · Russell King (Oracle)
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yamlQuoted 14 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 10 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#Does not look like you tested the bindings. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions).
Quoted 1 line
Oh ffs. DT bindings are utterly impossible to get correct.
I'd be happy to wrap the bindings up in another cycle & take them via asahi-soc, if you want. That will also allow us to add the nodes to the t6000 DTs which are on that tree for this cycle, and unblock merging the driver bits of this series. Bindings updates are not a hard dependency for drivers, only for the DTs themselves.
That is:
1-2,4 via mfd tree (if Lee agrees to merging the RTKit driver platform bits that way)
3,5-6 via asahi-soc
7 via GPIO (I think)
- Hector
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
In reply to Russell King (Oracle)Quoted 25 lines · Russell King (Oracle)
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yamlQuoted 14 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 10 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#Does not look like you tested the bindings. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions).
Quoted 1 line
Oh ffs. DT bindings are utterly impossible to get correct.
Why? You write, you test and then you see the error. Srsly...
Best regards,
Krzysztof
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
Quoted 26 lines · Krzysztof Kozlowski
Quoted 25 lines · Russell King (Oracle)
Quoted 23 lines · Krzysztof Kozlowski
Quoted 14 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yamlDocumentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +0
-0Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#Does not look like you tested the bindings. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions).
Quoted 3 lines
Quoted 1 line
Oh ffs. DT bindings are utterly impossible to get correct.
Why? You write, you test and then you see the error. Srsly...
It's utterly impossible for me to remember the dependencies. It's utterly impossible for me to remember the make incantation to test this bloody things - especially as I need to limit it otherwise it takes a very long time to test.
The whole bloody thing is just too sodding difficult.
I'm not going to bother with this patch set any more. Too frustrated with this piecemeal approach and the crappy slow tooling and the idiotic incomprehensible error messages it spits out.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
Quoted 27 lines · Russell King (Oracle)
Quoted 26 lines · Krzysztof Kozlowski
Quoted 25 lines · Russell King (Oracle)
Quoted 23 lines · Krzysztof Kozlowski
Quoted 14 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yamlDocumentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +0
-0Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml new file +4
-0@@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#Does not look like you tested the bindings. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions).
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Oh ffs. DT bindings are utterly impossible to get correct.
Why? You write, you test and then you see the error. Srsly...
It's utterly impossible for me to remember the dependencies. It's utterly impossible for me to remember the make incantation to test this bloody things - especially as I need to limit it otherwise it takes a very long time to test.
Then this is where I can help - you can test just one, specific binding or few of them:
make dt_binding_check DT_SCHEMA_FILES=apple,smc-gpio.yaml
make dt_binding_check DT_SCHEMA_FILES=apple,smc
So before you format patches, just do git rebase -i HEAD~7, change to re-word or edit and go one-by-one testing your bisectability. The same we are always doing for regular kernel builds when having a big patchset, right? Each commit must compile, not just the last one in patchset.
Or push each of the commit to a service which can do it for you. For example, for kernel building (not yet ready for DT binding check) I am using something like:
https://github.com/krzk/tools/tree/master/git-build-kernel
Quoted 6 lines
The whole bloody thing is just too sodding difficult.
I'm not going to bother with this patch set any more. Too frustrated with this piecemeal approach and the crappy slow tooling and the idiotic incomprehensible error messages it spits out.
Best regards,
Krzysztof
Rob Herring
maintainerRe: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
In reply to Russell King (Oracle)Quoted 8 lines · Russell King (Oracle)
Add the DT binding for the Apple Mac System Management Controller GPIOs.
Signed-off-by Russell King (Oracle) <[email protected]>--- .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:./Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/gpio/apple,smc-gpio.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
PATCH v3 7/7 gpio: Add new gpio-macsmc driver for Apple Macs
In reply to Russell King (Oracle)From: Hector Martin <[email protected]>
This driver implements the GPIO service on top of the SMC framework on Apple Mac machines. In particular, these are the GPIOs present in the PMU IC which are used to control power to certain on-board devices.
Although the underlying hardware supports various pin config settings (input/output, open drain, etc.), this driver does not implement that functionality and leaves it up to the firmware to configure things properly. We also don't yet support interrupts/events. This is sufficient for device power control, which is the only thing we need to support at this point. More features will be implemented when needed.
To our knowledge, only Apple Silicon Macs implement this SMC feature.
--- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-macsmc.c | 245 +++++++++++++++++++++++++++++++++++++ 3 files changed, 257 insertions(+) create mode 100644 drivers/gpio/gpio-macsmc.c
drivers/gpio/Kconfig +11 -0
@@ -1283,6 +1283,17 @@ config GPIO_LP87565 This driver can also be built as a module. If so, the module will be called gpio-lp87565. +config GPIO_MACSMC + tristate "Apple Mac SMC GPIO" + depends on MFD_MACSMC + default ARCH_APPLE + help + Support for GPIOs controlled by the SMC microcontroller on Apple Mac + systems. + + This driver can also be built as a module. If so, the module will be + called gpio-macsmc. + config GPIO_MADERA tristate "Cirrus Logic Madera class codecs" depends on PINCTRL_MADERA
drivers/gpio/Makefile +1 -0
@@ -83,6 +83,7 @@ obj-$(CONFIG_GPIO_LP873X) += gpio-lp873x.o obj-$(CONFIG_GPIO_LP87565) += gpio-lp87565.o obj-$(CONFIG_GPIO_LPC18XX) += gpio-lpc18xx.o obj-$(CONFIG_GPIO_LPC32XX) += gpio-lpc32xx.o +obj-$(CONFIG_GPIO_MACSMC) += gpio-macsmc.o obj-$(CONFIG_GPIO_MADERA) += gpio-madera.o obj-$(CONFIG_GPIO_MAX3191X) += gpio-max3191x.o obj-$(CONFIG_GPIO_MAX7300) += gpio-max7300.o
drivers/gpio/gpio-macsmc.c new file +245 -0
245 lines not on this page · raw message
Signature · 1 line
2.30.2