Skip to contentSkip to conversation

dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

PATCH Applied Markus Elfring 3 participants 3 messages Sep 22, 2019 – Oct 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 22 Sep 2019 14:32:12 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

---
 drivers/dma/zx_dma.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/dma/zx_dma.c +1 -6
index 9f4436f7c914..6b457e683e70 100644
@@ -754,18 +754,13 @@ static struct dma_chan *zx_of_dma_simple_xlate(struct of_phandle_args *dma_spec,
 static int zx_dma_probe(struct platform_device *op)
 {
 	struct zx_dma_dev *d;
-	struct resource *iores;
 	int i, ret = 0;
 
-	iores = platform_get_resource(op, IORESOURCE_MEM, 0);
-	if (!iores)
-		return -EINVAL;
-
 	d = devm_kzalloc(&op->dev, sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;
 
-	d->base = devm_ioremap_resource(&op->dev, iores);
+	d->base = devm_platform_ioremap_resource(op, 0);
 	if (IS_ERR(d->base))
 		return PTR_ERR(d->base);
 

--
2.23.0

maintainer Applied
#2 lore raw
In reply to Markus Elfring
Quoted 6 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sun, 22 Sep 2019 14:32:12 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Applied, thanks

Signature · 1 line
~Vinod