Skip to contentSkip to conversation

board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15

PATCH Applied Romain Naour 2 participants 3 messages Jan 2, 2022 – Jan 3, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15

Genimage 15 restricted the partition-type option to mbr and hybrid partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

Sync the genimage.cfg with the one used for aarch64_efi_defconfig

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262

Cc Dick Olsson <[email protected]>
Cc Pierre-Jean Texier <[email protected]>
---
 board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
board/qemu/aarch64-sbsa/genimage.cfg +4 -2
index 121ae9f37b..bdf8a89d75 100644
@@ -18,12 +18,14 @@ image disk.img {
 	}
 
 	partition boot {
-		partition-type = 0xEF
 		image = "efi-part.vfat"
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		offset = 32K
+		bootable = true
 	}
 
 	partition root {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext2"
 	}
 }
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Romain, All,

On 2022-01-02 17:54 +0100, Romain Naour spake thusly:

Quoted 5 lines

Genimage 15 restricted the partition-type option to mbr and hybrid partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

Quoted 7 lines

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

Sync the genimage.cfg with the one used for aarch64_efi_defconfig

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262

I've added a link to the Wikipedia page that lists the UUIDs:
https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Quoted 3 lines
Cc Dick Olsson <[email protected]>
Cc Pierre-Jean Texier <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 32 lines
---
 board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
board/qemu/aarch64-sbsa/genimage.cfg +4 -2
index 121ae9f37b..bdf8a89d75 100644
@@ -18,12 +18,14 @@ image disk.img {
 	}
 
 	partition boot {
-		partition-type = 0xEF
 		image = "efi-part.vfat"
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		offset = 32K
+		bootable = true
 	}
 
 	partition root {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext2"
 	}
 }
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hello Yann,

Le 03/01/2022 à 21:43, Yann E. MORIN a écrit :

Quoted 10 lines

Romain, All,

On 2022-01-02 17:54 +0100, Romain Naour spake thusly:

Quoted 7 lines

Genimage 15 restricted the partition-type option to mbr and hybrid partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

Quoted 8 lines
Quoted 5 lines

Sync the genimage.cfg with the one used for aarch64_efi_defconfig

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262

I've added a link to the Wikipedia page that lists the UUIDs:
https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Thanks, useful link!

Best regards,
Romain

Quoted 38 lines
Quoted 4 lines
Cc Dick Olsson <[email protected]>
Cc Pierre-Jean Texier <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 28 lines
---
 board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
board/qemu/aarch64-sbsa/genimage.cfg +4 -2
index 121ae9f37b..bdf8a89d75 100644
@@ -18,12 +18,14 @@ image disk.img {
 	}
 
 	partition boot {
-		partition-type = 0xEF
 		image = "efi-part.vfat"
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		offset = 32K
+		bootable = true
 	}
 
 	partition root {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext2"
 	}
 }
Signature · 1 line
2.31.1
Quoted 5 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot