Skip to contentSkip to conversation

drivers/media/video/cpia_pp.c: don't use _WORK_NAR

PATCH Superseded Oleg Nesterov 2 participants 3 messages Feb 18, 2007 – Feb 19, 2007 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 drivers/media/video/cpia_pp.c: don't use _WORK_NAR

pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is never used ???

drivers/media/video/cpia_pp.c renamed from drivers/media/video/cpia_pp.c~3_cpia_pp +1 -2
@@ -141,7 +141,6 @@ static void cpia_pp_run_callback(struct 
 	cam = container_of(work, struct pp_cam_entry, cb_task);
 	cb_func = cam->cb_func;
 	cb_data = cam->cb_data;
-	work_release(work);
 
 	cb_func(cb_data);
 }
@@ -682,7 +681,7 @@ static int cpia_pp_registerCallback(void
 	if(cam->port->irq != PARPORT_IRQ_NONE) {
 		cam->cb_func = cb;
 		cam->cb_data = cbdata;
-		INIT_WORK_NAR(&cam->cb_task, cpia_pp_run_callback);
+		INIT_WORK(&cam->cb_task, cpia_pp_run_callback);
 	} else {
 		retval = -1;
 	}
Acked-by on v1 3/3
#1 lore raw
Quoted 2 lines · Oleg Nesterov

pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is never used ???

That's a remarkably good point. Did something get deleted since I made my modifications? Perhaps the workqueue stuff in that file should just be deleted entirely.

#2 lore raw
Quoted 8 lines · David Howells
Quoted 2 lines · Oleg Nesterov

pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is never used ???

That's a remarkably good point. Did something get deleted since I made my modifications?

At first I thought the same. But no, it looks unused as well in 2.6.18.

Quoted 2 lines

Perhaps the workqueue stuff in that file should just be
deleted entirely.

I think yes.

Quoted 1 line

Thanks.

Oleg.