rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Signed-off-by Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

Reviewed-by Paul Kocialkowski <[email protected]>

---
Changes for v3.1:
- exclude changes for other dts files, since they handle separately.

 arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi

arch/arm/dts/rk3399-u-boot.dtsi new file +8 -0

new file mode 100644
index 0000000000..f533ed95eb
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
+ */
+
+&sdmmc {
+	u-boot,dm-pre-reloc;
+};

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 2 lines

Signed-off-by Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

Quoted 18 lines · Paul Kocialkowski

Hi,

Quoted 11 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Signed-off-by Jagan Teki <[email protected]>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

Quoted 2 lines

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

[1] https://patchwork.ozlabs.org/patch/1091543/

Hi,

Quoted 23 lines · Jagan Teki

Quoted 20 lines · Paul Kocialkowski

Hi,

Quoted 11 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Signed-off-by Jagan Teki <[email protected]>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

Quoted 3 lines

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

Quoted 30 lines · Paul Kocialkowski

Hi,

Quoted 26 lines · Jagan Teki

Quoted 12 lines · Paul Kocialkowski

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 8 lines

Quoted 2 lines

Signed-off-by Jagan Teki <[email protected]>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Quoted 3 lines

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

It is not like an inter-dependency the previous rk3399-u-boot.dtsi is not included by these files so they would work as before. and now this series would need this change to include rk3399-u-boot.dtsi since the goal here to add binman node to common for all rk3399 dts files.

Hi,

Quoted 32 lines · Jagan Teki

Quoted 30 lines · Paul Kocialkowski

Hi,

Quoted 26 lines · Jagan Teki

Quoted 12 lines · Paul Kocialkowski

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 8 lines

Quoted 2 lines

Signed-off-by Jagan Teki <[email protected]>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Quoted 8 lines

Quoted 3 lines

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

It is not like an inter-dependency the previous rk3399-u-boot.dtsi is not included by these files so they would work as before. and now this series would need this change to include rk3399-u-boot.dtsi since the goal here to add binman node to common for all rk3399 dts files.

Well, what I mean is that the latest series you sent mentions a dependency on the first one, when it really should be the other way
round: you need the rework to make things in your first series work at all, since that dm-pre-reloc is necessary.

We don't want to merge one broken series and then the fix for it later, even if it would still build in all cases. Here there is a clear logical dependency, in the reverse ordre to the one you are describing.

Quoted 44 lines · Paul Kocialkowski

Hi,

Quoted 32 lines · Jagan Teki

Quoted 30 lines · Paul Kocialkowski

Hi,

Quoted 26 lines · Jagan Teki

Quoted 12 lines · Paul Kocialkowski

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 8 lines

Quoted 2 lines

Signed-off-by Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Quoted 8 lines

Quoted 3 lines

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

It is not like an inter-dependency the previous rk3399-u-boot.dtsi is not included by these files so they would work as before. and now this series would need this change to include rk3399-u-boot.dtsi since the goal here to add binman node to common for all rk3399 dts files.

Quoted 8 lines

Well, what I mean is that the latest series you sent mentions a dependency on the first one, when it really should be the other way
round: you need the rework to make things in your first series work at all, since that dm-pre-reloc is necessary.

We don't want to merge one broken series and then the fix for it later, even if it would still build in all cases. Here there is a clear logical dependency, in the reverse ordre to the one you are describing.

I don't understand your point, sorry.

This patch [1] will make use of the new boards added on that series it will not effect existing or previous rk3399 boards. in that case why it is broken patch or series could you elaborate? the existing boards are already supported dm-pre-reloc on their respective devicetree files.

[1] https://patchwork.ozlabs.org/patch/1091534/

Hi,

Quoted 55 lines · Jagan Teki

Quoted 44 lines · Paul Kocialkowski

Hi,

Quoted 32 lines · Jagan Teki

Quoted 30 lines · Paul Kocialkowski

Hi,

Quoted 26 lines · Jagan Teki

Quoted 12 lines · Paul Kocialkowski

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 8 lines

Quoted 2 lines

Signed-off-by Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Quoted 8 lines

Quoted 3 lines

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

It is not like an inter-dependency the previous rk3399-u-boot.dtsi is not included by these files so they would work as before. and now this series would need this change to include rk3399-u-boot.dtsi since the goal here to add binman node to common for all rk3399 dts files.

Quoted 8 lines

Well, what I mean is that the latest series you sent mentions a dependency on the first one, when it really should be the other way
round: you need the rework to make things in your first series work at all, since that dm-pre-reloc is necessary.

We don't want to merge one broken series and then the fix for it later, even if it would still build in all cases. Here there is a clear logical dependency, in the reverse ordre to the one you are describing.

Quoted 7 lines

I don't understand your point, sorry.

This patch [1] will make use of the new boards added on that series it will not effect existing or previous rk3399 boards. in that case why it is broken patch or series could you elaborate? the existing boards are already supported dm-pre-reloc on their respective devicetree files.

On looks like I still didn't really get what you are trying to do. Let's try and recap the situation:

- Currently, we have rk3399 boards with u-boot,dm-pre-reloc in their shared dtsi;

- Your v3.1 adds rk3399-u-boot.dtsi but keeps the u-boot,dm-pre-reloc in each device since rk3399-u-boot won't be included.

- Your new series allows rk3399-u-boot.dtsi to be included automatically, so we can move the per-common-device-dts u-boot,dm-pre- reloc to rk3399-u-boot.dtsi

If that's correct, then it indeed makes sense the way it is proposed. Your commit messages just lack a clear explanation of what is going on here, since it's not quite trivial for anyone but you.

Quoted 66 lines · Paul Kocialkowski

Hi,

Quoted 62 lines · Jagan Teki

Quoted 44 lines · Paul Kocialkowski

Hi,

Quoted 32 lines · Jagan Teki

Quoted 30 lines · Paul Kocialkowski

Hi,

Quoted 26 lines · Jagan Teki

Quoted 12 lines · Paul Kocialkowski

Hi,

Quoted 9 lines · Jagan Teki

u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding.

Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement.

This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes.

Quoted 8 lines

Quoted 2 lines

Signed-off-by Jagan Teki <[email protected]>

Reviewed-by Paul Kocialkowski <[email protected]>

Since your patch has changed significantly, you can no longer include a Reviewed-by that was given on a previous iteration.

It looks like we are still missing bits to have rk3399-u-boot.dtsi included, so this patch does not get my Reviewed-by tag.

It will include rockchip-u-boot.dtsi automatically and I made the receptive changes to include other files in this patch [1] and sure I will ask Philipp to remove the reviewed-by tag, thanks.

Quoted 8 lines

Quoted 3 lines

Most importantly (now that I see the new series), you should certainly have sent that patch as part of your new series because we now have an inter-dependency between both series.

It is not like an inter-dependency the previous rk3399-u-boot.dtsi is not included by these files so they would work as before. and now this series would need this change to include rk3399-u-boot.dtsi since the goal here to add binman node to common for all rk3399 dts files.

Quoted 8 lines

Well, what I mean is that the latest series you sent mentions a dependency on the first one, when it really should be the other way
round: you need the rework to make things in your first series work at all, since that dm-pre-reloc is necessary.

We don't want to merge one broken series and then the fix for it later, even if it would still build in all cases. Here there is a clear logical dependency, in the reverse ordre to the one you are describing.

I don't understand your point, sorry.

This patch [1] will make use of the new boards added on that series it will not effect existing or previous rk3399 boards. in that case why it is broken patch or series could you elaborate? the existing boards are already supported dm-pre-reloc on their respective devicetree files.

Quoted 5 lines

On looks like I still didn't really get what you are trying to do. Let's try and recap the situation:

- Currently, we have rk3399 boards with u-boot,dm-pre-reloc in their shared dtsi;

No, the existing boards don't have shared dtsi that have u-boot,dm-pre-reloc instead they included on respective dts files.

Quoted 2 lines

- Your v3.1 adds rk3399-u-boot.dtsi but keeps the u-boot,dm-pre-reloc in each device since rk3399-u-boot won't be included.

This would keep sdmmc node only which is included by the new boards on that series only.

Quoted 3 lines

- Your new series allows rk3399-u-boot.dtsi to be included automatically, so we can move the per-common-device-dts u-boot,dm-pre- reloc to rk3399-u-boot.dtsi

No, automatically I'm explicit including on respective -u-boot.dtsi

Quoted 3 lines

If that's correct, then it indeed makes sense the way it is proposed. Your commit messages just lack a clear explanation of what is going on here, since it's not quite trivial for anyone but you.

Please don't through stone, explain where it lacks. thanks.

Look like you seems confusing or unclear, here is bit more explanation. The existing boards have u-boot,dm-pre-reloc for sdmmc on their individual dts(i) files, my series add added initial rk3399-u-boot.dtsi by including sdmmc node to use u-boot,dm-pre-reloc which is what in v3.1 and the same included by board dts files which I added on next patches.