ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

PATCH New Bartlomiej Zolnierkiewicz 3 participants 6 messages Aug 20, 2013 – Oct 7, 2013

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2013-08-20 11:22 UTC #0 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one (0x12850000). Fix it by overriding the default PL330 MDMA1 address in exynos4210-universal_c210.dts.

This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent regression caused by conversion to DT-only setup on ARM EXYNOS.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
 1 file changed, 4 insertions(+)

arch/arm/boot/dts/exynos4210-universal_c210.dts +4 -0

index 889cdad..d2e3f5f 100644
@@ -350,3 +350,7 @@
 		status = "okay";
 	};
 };
+
+&mdma1 {
+	reg = <0x12840000 0x1000>;
+};

Signature · 1 line

1.8.2.3

Tomasz Figa

2013-08-20 12:13 UTC #1 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

Hi Bart,

Quoted 21 lines · On Tuesday 20 of August 2013 13:22:45 Bartlomiej Zolnierkiewicz wrote:

Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one (0x12850000). Fix it by overriding the default PL330 MDMA1 address in exynos4210-universal_c210.dts.
This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent regression caused by conversion to DT-only setup on ARM EXYNOS.
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/arch/arm/boot/dts/exynos4210-universal_c210.dts index 889cdad..d2e3f5f 100644

arch/arm/boot/dts/exynos4210-universal_c210.dts line 356

Quoted 7 lines

arch/arm/boot/dts/exynos4210-universal_c210.dts +4 -0

@@ -350,3 +350,7 @@
 		status = "okay";
 	};
 };
+
+&mdma1 {
+	reg = <0x12840000 0x1000>;
+};

Acked-by Tomasz Figa <[email protected]>

As a side note for other reviewers, Universal C210 is the only board based on Exynos4210 rev0, so board-level dts is the right place for such override.

Best regards,
Tomasz

Bartlomiej Zolnierkiewicz

author

2013-09-23 16:01 UTC #2 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

In reply to Bartlomiej Zolnierkiewicz

Hi Kukjin,

Could you please apply this patch?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 27 lines · Bartlomiej Zolnierkiewicz

Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one (0x12850000). Fix it by overriding the default PL330 MDMA1 address in exynos4210-universal_c210.dts.
This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent regression caused by conversion to DT-only setup on ARM EXYNOS.
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/exynos4210-universal_c210.dts +4 -0
index 889cdad..d2e3f5f 100644
@@ -350,3 +350,7 @@
 		status = "okay";
 	};
 };
+
+&mdma1 {
+	reg = <0x12840000 0x1000>;
+};

Kukjin Kim

2013-09-24 10:38 UTC #3 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

Quoted 4 lines · Bartlomiej Zolnierkiewicz

Hi Kukjin,

Hi Bart,

Quoted 2 lines

Could you please apply this patch?

Can you make sure there is no rev1 for universal c210 board?

- Kukjin

Quoted 35 lines

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 9 lines · Bartlomiej Zolnierkiewicz
Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one (0x12850000). Fix it by overriding the default PL330 MDMA1 address in exynos4210-universal_c210.dts.
This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent regression caused by conversion to DT-only setup on ARM EXYNOS.
Review
Quoted 7 lines
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/arch/arm/boot/dts/exynos4210-universal_c210.dts
Quoted 11 lines
index 889cdad..d2e3f5f 100644
arch/arm/boot/dts/exynos4210-universal_c210.dts +4 -0
@@ -350,3 +350,7 @@
 		status = "okay";
 	};
 };
+
+&mdma1 {
+	reg = <0x12840000 0x1000>;
+};

Bartlomiej Zolnierkiewicz

author

2013-09-24 10:41 UTC #4 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

Hi,

Quoted 10 lines · Kukjin Kim

Quoted 4 lines · Bartlomiej Zolnierkiewicz
Hi Kukjin,
Hi Bart,
Quoted 2 lines
Could you please apply this patch?
Can you make sure there is no rev1 for universal c210 board?

Universal C210 always used Exynos4210 rev0.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 37 lines

- Kukjin
Quoted 35 lines
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 9 lines · Bartlomiej Zolnierkiewicz
Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one (0x12850000). Fix it by overriding the default PL330 MDMA1 address in exynos4210-universal_c210.dts.
This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent regression caused by conversion to DT-only setup on ARM EXYNOS.
Review
Quoted 7 lines
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/arch/arm/boot/dts/exynos4210-universal_c210.dts
Quoted 11 lines
index 889cdad..d2e3f5f 100644
arch/arm/boot/dts/exynos4210-universal_c210.dts +4 -0
@@ -350,3 +350,7 @@
 		status = "okay";
 	};
 };
+
+&mdma1 {
+	reg = <0x12840000 0x1000>;
+};

Kukjin Kim

2013-10-07 22:11 UTC #5 lore raw

PATCH 1/1 ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board

Quoted 9 lines · Bartlomiej Zolnierkiewicz

Hi,
Quoted 5 lines · Kukjin Kim
Quoted 4 lines · Bartlomiej Zolnierkiewicz
Hi Kukjin,

Quoted 8 lines

Quoted 5 lines
Hi Bart,
Quoted 2 lines
Could you please apply this patch?
Can you make sure there is no rev1 for universal c210 board?
Universal C210 always used Exynos4210 rev0.

OK, applied.

Thanks,
Kukjin