irqchip: irq-mbigen: Add of_node_put() before return
PATCH 1/1 irqchip: irq-mbigen: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return in three places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/irqchip/irq-mbigen.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/irqchip/irq-mbigen.c +7 -2
@@ -241,12 +241,15 @@ static int mbigen_of_create_domain(struct platform_device *pdev, parent = platform_bus_type.dev_root; child =of_platform_device_create (np,NULL , parent); -if (!child) +if (!child) { +of_node_put (np);return -ENOMEM ; + }if (of_property_read_u32 (child->dev.of_node,"num-pins" , &num_pins) <0 ) {dev_err (&pdev->dev,"No num-pins property\n" ); +of_node_put (np);return -EINVAL ; }
@@ -254,8 +257,10 @@ static int mbigen_of_create_domain(struct platform_device *pdev, mbigen_write_msg, &mbigen_domain_ops, mgn_chip); -if (!domain) +if (!domain) { +of_node_put (np);return -ENOMEM ; + } }return 0 ;
Signature · 1 line
2.19.1
Marc Zyngier
AppliedQuoted 48 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add anof_node_putbefore the return in three places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/irqchip/irq-mbigen.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/irqchip/irq-mbigen.c +7
-2@@ -241,12 +241,15 @@ static int mbigen_of_create_domain(struct platform_device *pdev, parent = platform_bus_type.dev_root; child =of_platform_device_create (np,NULL , parent); -if (!child) +if (!child) { +of_node_put (np);return -ENOMEM ; + }if (of_property_read_u32 (child->dev.of_node,"num-pins" , &num_pins) <0 ) {dev_err (&pdev->dev,"No num-pins property\n" ); +of_node_put (np);return -EINVAL ; }@@ -254,8 +257,10 @@ static int mbigen_of_create_domain(struct platform_device *pdev, mbigen_write_msg, &mbigen_domain_ops, mgn_chip); -if (!domain) +if (!domain) { +of_node_put (np);return -ENOMEM ; + } }return 0 ;Signature · 1 line
2.19.1
Applied, thanks.
M.
Signature · 1 line
Jazz is not dead, it just smells funny.