x86_64: using irq_domain in ioapic_retrigger_irq
PATCH 1/1 x86_64: using irq_domain in ioapic_retrigger_irq
using irq_domain[irq] to get cpu_mask for send_IPI_mask
arch/x86_64/kernel/io_apic.c +0 -0
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
static int ioapic_retrigger_irq(unsigned int irq)
{
cpumask_t mask;- unsigned vector;
+ int vector;
vector = irq_vector[irq]; - cpus_clear(mask); - cpu_set(vector >> 8, mask); + mask = irq_domain[irq];
- send_IPI_mask(mask, vector & 0xff);
+ send_IPI_mask(mask, vector);
return 1; }
arch/x86_64/kernel/io_apic.c +3 -4
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(ustatic int ioapic_retrigger_irq (unsigned int irq) {cpumask_t mask; -unsigned vector; +int vector; vector = irq_vector[irq]; -cpus_clear (mask); -cpu_set (vector >>8 , mask); + mask = irq_domain[irq]; -send_IPI_mask (mask, vector &0xff ); +send_IPI_mask (mask, vector);return 1 ; }
Quoted 1 line · Yinghai Lu
using irq_domain[irq] to get
cpu_maskforsend_IPI_mask
Yep. I missed that one in my last refactoring :(
Eric
Quoted 3 lines · Yinghai Lu
using irq_domain[irq] to get
cpu_maskforsend_IPI_maskSigned-off-by Yinghai Lu <[email protected]>
YH I have to grumble at you, your patch suffers from white space damage and does not apply.
In addition while looking this version is actually broken because for retrigger irq we only ever want to send the irq once and your version has the potential to be broadcast to several cpus. Not what we want.
I will send a fixed version in a minute.
Eric
Quoted 22 lines
arch/x86_64/kernel/io_apic.c +3
-4@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(ustatic int ioapic_retrigger_irq (unsigned int irq) {cpumask_t mask; -unsigned vector; +int vector; vector = irq_vector[irq]; -cpus_clear (mask); -cpu_set (vector >>8 , mask); + mask = irq_domain[irq]; -send_IPI_mask (mask, vector &0xff ); +send_IPI_mask (mask, vector);return 1 ; }