Skip to contentSkip to conversation

UASP: Return -ENODEV instead of -1 on error

PATCH In review Luben Tuikov 1 participant 1 message Dec 8, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/4 UASP: Return -ENODEV instead of -1 on error

Return -ENODEV instead of -1 on configuration
errors when discovering the attached device.

---
 drivers/usb/storage/uasp.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/usb/storage/uasp.c +3 -3
index 40ee5a4..eb8933f 100644
@@ -943,7 +943,7 @@ static int uasp_ep_conf(struct uasp_tport_info *tpinfo)
 	    tpinfo->eps[2] == NULL || tpinfo->eps[3] == NULL) {
 		dev_err(&udev->dev, "%s: one or more endpoints are missing\n",
 			__func__);
-		return -1;
+		return -ENODEV;
 	}
 
 	tpinfo->cmd_pipe = usb_sndbulkpipe(udev,
@@ -968,7 +968,7 @@ static int uasp_ep_conf(struct uasp_tport_info *tpinfo)
 		
 		if (tpinfo->max_streams <= 1) {
 			dev_err(&udev->dev, "%s: no streams\n", __func__);
-			return -1;
+			return -ENODEV;
 		}
 		
 		tpinfo->use_streams = 1;
@@ -985,7 +985,7 @@ static int uasp_ep_conf(struct uasp_tport_info *tpinfo)
 				"%s: Couldn't allocate %d streams (%d)\n",
 				__func__, tpinfo->max_streams,
 				tpinfo->num_streams);
-			return -1;
+			return -ENODEV;
 		}
 
 		uasp_set_max_cmds(tpinfo);
Signature · 1 line
1.7.0.1