Skip to contentSkip to conversation

net: phy: fix issue with loading PHY driver w/o initramfs

PATCH Applied Heiner Kallweit 5 participants 6 messages Jan 19, 2019 – Jan 23, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: fix issue with loading PHY driver w/o initramfs

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")
---
 drivers/net/phy/phy_device.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/phy/phy_device.c +5 -3
index 264312137..1a12acfd9 100644
@@ -552,10 +552,12 @@ static int phy_request_driver_module(struct phy_device *dev, int phy_id)
 
 	ret = request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT,
 			     MDIO_ID_ARGS(phy_id));
-	/* we only check for failures in executing the usermode binary,
-	 * not whether a PHY driver module exists for the PHY ID
+	/* We only check for failures in executing the usermode binary,
+	 * not whether a PHY driver module exists for the PHY ID.
+	 * Accept -ENOENT because this may occur in case no initramfs exists,
+	 * then modprobe isn't available.
 	 */
-	if (IS_ENABLED(CONFIG_MODULES) && ret < 0) {
+	if (IS_ENABLED(CONFIG_MODULES) && ret < 0 && ret != -ENOENT) {
 		phydev_err(dev, "error %d loading PHY driver module for ID 0x%08x\n",
 			   ret, phy_id);
 		return ret;
Signature · 1 line
2.20.1
Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines · Heiner Kallweit

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")

---

Fixes the issue for me, thanks!

Best regards,
Krzysztof

#2 lore raw
In reply to Heiner Kallweit

Hi Heiner,

Quoted 8 lines

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")

Thanks for your patch!

Quoted 9 lines
drivers/net/phy/phy_device.c +0 -2
@@ -552,10 +552,12 @@ static int phy_request_driver_module(struct phy_device *dev, int phy_id)
 
 	ret = request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT,
 			     MDIO_ID_ARGS(phy_id));
-	/* we only check for failures in executing the usermode binary,
-	 * not whether a PHY driver module exists for the PHY ID

drivers/net/phy/phy_device.c static int phy_request_driver_module(struct phy_device *dev, int phy_id) · line 563

Quoted 10 lines
drivers/net/phy/phy_device.c +5 -1
+	/* We only check for failures in executing the usermode binary,
+	 * not whether a PHY driver module exists for the PHY ID.
+	 * Accept -ENOENT because this may occur in case no initramfs exists,
+	 * then modprobe isn't available.
 	 */
-	if (IS_ENABLED(CONFIG_MODULES) && ret < 0) {
+	if (IS_ENABLED(CONFIG_MODULES) && ret < 0 && ret != -ENOENT) {
 		phydev_err(dev, "error %d loading PHY driver module for ID 0x%08x\n",
 			   ret, phy_id);
 		return ret;

While I believe this patch fixes the particular issue I was seeing, I'm not convinced it fixes other possible issues.  There are several different error cases in both the kernel (e.g. -ETIME) and userland that can cause request_module() to fail, without actually having any impact, if the particular PHY driver is builtin or already loaded.

IMHO, if the wanted PHY is available, all errors returned by request_module() should be ignored.

In other subsystems, this is handled like:

    if (driver_is_missing)
        request_module(...);
    if (driver_is_missing)
        return -E...;

Note that most callers of request_module() don't even check the error code it returns: the only thing that matters is if the (possibly loaded) functionality is available afterwards or not.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer Applied
#3 lore raw
In reply to Heiner Kallweit

From: Heiner Kallweit <[email protected]>
Date: Sat, 19 Jan 2019 10:30:21 +0100

Quoted 8 lines

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")

Applied.

However, I agree with Geert that we should adopt the:

	if (module_not_present)
		request_module();
	if (module_not_present)
		goto failed_to_load;

pattern.

author maintainer
#4 lore raw
Quoted 14 lines · David Miller

From: Heiner Kallweit <[email protected]>
Date: Sat, 19 Jan 2019 10:30:21 +0100

Quoted 8 lines

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")

Applied.

Quoted 9 lines

However, I agree with Geert that we should adopt the:

	if (module_not_present)
		request_module();
	if (module_not_present)
		goto failed_to_load;

pattern.

I know this is the standard pattern for request_module(). Unfortunately the situation is a little bit tricky with PHY drivers. We don't know whether there's a module matching the PHY ID and it's a valid use case that there's no such module.
In such a case we bind the genphy driver later, and a lot of PHY's are totally happy with the genphy driver and therefore no dedicated PHY drivers exist.

#5 lore raw
In reply to Heiner Kallweit

From: Geert Uytterhoeven <[email protected]>

Hi Heiner,

Quoted 24 lines · David Miller
Quoted 14 lines

From: Heiner Kallweit <[email protected]>
Date: Sat, 19 Jan 2019 10:30:21 +0100

Quoted 8 lines

It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT.

Fixes 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")

Applied.

Quoted 8 lines

However, I agree with Geert that we should adopt the:

	if (module_not_present)
		request_module();
	if (module_not_present)
		goto failed_to_load;

pattern.

Quoted 7 lines

I know this is the standard pattern for request_module(). Unfortunately the situation is a little bit tricky with PHY drivers. We don't know whether there's a module matching the PHY ID and it's a valid use case that there's no such module.
In such a case we bind the genphy driver later, and a lot of PHY's are totally happy with the genphy driver and therefore no dedicated PHY drivers exist.

Currently, if request_module() fails (for whatever reason, except -ENOENT), you don't bind to the genphy driver, but propagate an error[*], leaving the user without network interface.

Is that better than ignoring the error, and binding to the genphy driver?
When do you expect the phy-specific driver to become available, if ever?

[*] The actual error code returned by request_module(), and not
-EPROBE_DEFER. The latter may sound attractive, as it is meant to cause a retry later, but has its own set of problems with optional drivers that may never become available (e.g. missing drivers for DMA controllers).

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds