HID: N-Trig: Adjustments for ntrig_probe()
Subsystems (2)
cover HID: N-Trig: Adjustments for ntrig_probe()
From: Markus Elfring <[email protected]>
Date: Sat, 3 Feb 2018 21:54:32 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determination
drivers/hid/hid-ntrig.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.16.1
PATCH 1/2 HID: ntrig: Delete an error message for a failed memory allocation in ntrig_probe()
From: Markus Elfring <[email protected]>
Date: Sat, 3 Feb 2018 21:46:20 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
--- drivers/hid/hid-ntrig.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/hid/hid-ntrig.c +1 -3
@@ -905,10 +905,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) | HID_QUIRK_NO_INIT_REPORTS; nd =kmalloc (sizeof (struct ntrig_data ),GFP_KERNEL ); -if (!nd) { -hid_err (hdev,"cannot allocate N-Trig data\n" ); +if (!nd)return -ENOMEM ; - } nd->reading_mt =0 ; nd->min_width =0 ;
Signature · 1 line
2.16.1
PATCH 2/2 HID: ntrig: Improve a size determination in ntrig_probe()
In reply to SF Markus ElfringFrom: Markus Elfring <[email protected]>
Date: Sat, 3 Feb 2018 21:48:39 +0100
Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
--- drivers/hid/hid-ntrig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-ntrig.c +1 -1
@@ -904,7 +904,7 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) hdev->quirks |=HID_QUIRK_MULTI_INPUT |HID_QUIRK_NO_INIT_REPORTS ; - nd =kmalloc (sizeof (struct ntrig_data ),GFP_KERNEL ); + nd =kmalloc (sizeof (*nd),GFP_KERNEL );if (!nd)return -ENOMEM ;
Signature · 1 line
2.16.1