KVM: arm64: free kvm->arch.nested_mmus with kvfree()
PATCH 1/1 KVM: arm64: free kvm->arch.nested_mmus with kvfree()
kvm->arch.nested_mmus is allocated with kvrealloc(), hence free it with kvfree() instead of kfree().
Fixes 4f128f8e1aaa ("KVM: arm64: nv: Support multiple nested Stage-2 mmu structures")
Signed-off-by Danilo Krummrich <[email protected]>
--- arch/arm64/kvm/nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kvm/nested.c +1 -1
@@ -786,7 +786,7 @@ void kvm_arch_flush_shadow_all(struct kvm *kvm)if (!WARN_ON (atomic_read (&mmu->refcnt)))kvm_free_stage2_pgd (mmu); } -kfree (kvm->arch.nested_mmus); +kvfree (kvm->arch.nested_mmus); kvm->arch.nested_mmus =NULL ; kvm->arch.nested_mmus_size =0 ;kvm_uninit_stage2_mmu (kvm);
base-commit: 66ebbdfdeb093e097399b1883390079cd4c3022b
Signature · 1 line
2.45.2
Quoted 16 lines · Danilo Krummrich
kvm->arch.nested_mmusis allocated withkvrealloc(), hence free it withkvfree()instead ofkfree().Fixes 4f128f8e1aaa ("KVM: arm64: nv: Support multiple nested Stage-2 mmu structures")Signed-off-by Danilo Krummrich <[email protected]>--- arch/arm64/kvm/nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/kvm/nested.c +0
-0
arch/arm64/kvm/nested.c void kvm_arch_flush_shadow_all(struct kvm *kvm) · line 792
Quoted 8 lines
arch/arm64/kvm/nested.c +1
-1@@ -786,7 +786,7 @@ void kvm_arch_flush_shadow_all(struct kvm *kvm)if (!WARN_ON (atomic_read (&mmu->refcnt)))kvm_free_stage2_pgd (mmu); } -kfree (kvm->arch.nested_mmus); +kvfree (kvm->arch.nested_mmus); kvm->arch.nested_mmus =NULL ; kvm->arch.nested_mmus_size =0 ;kvm_uninit_stage2_mmu (kvm);
Ah, nice catch. Thanks for fixing it.
Reviewed-by Marc Zyngier <[email protected]>
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Oliver Upton
AppliedQuoted 4 lines · Danilo Krummrich
kvm->arch.nested_mmusis allocated withkvrealloc(), hence free it withkvfree()instead ofkfree().
Vacation + catching a bug while I was out got me waaaaay behind. Sorry I hadn't grabbed this yet.
Applied to kvmarm/fixes, thanks!
[1/1] KVM: arm64: free kvm->arch.nested_mmus with kvfree()
https://git.kernel.org/kvmarm/kvmarm/c/32b9a52f88a5
--
Best,
Oliver