Skip to contentSkip to conversation

arm64: cpucaps: Remove stale comment about keeping capabilities sorted

PATCH Applied Will Deacon 2 participants 3 messages Jul 30 – Aug 2 arm64

lore
Share & tools
lore

Will Deacon

author maintainer
#0 lore raw

PATCH v2 1/1 arm64: cpucaps: Remove stale comment about keeping capabilities sorted

There is no functional requirement to keep the entries in arm64's tools/cpucaps file sorted alphabetically and, in fact, they have fallen out of order over time. Given that only the arm64 tree touches this file and the perceived benefit of sorting was to help with conflicts, just remove the stale comment and accept that we're collectively not very good at the alphabet.

In the limited cases where a specific ordering is important, we enforce it through build-time assertions (e.g. in can_use_gic_priorities()).

Cc Catalin Marinas <[email protected]>
Acked-by Mark Rutland <[email protected]>
Reviewed-by Fuad Tabba <[email protected]>
Reported-by Marc Zyngier <[email protected]>
Signed-off-by Will Deacon <[email protected]>

---

v1: https://lore.kernel.org/r/[email protected]

 arch/arm64/tools/cpucaps | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/tools/cpucaps +1 -1
index 9b85a84f6fd4..3fcac789b0a4 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# Internal CPU capabilities constants, keep this list sorted
+# Internal CPU capabilities constants
 
 ALWAYS_BOOT
 ALWAYS_SYSTEM
Signature · 1 line
2.55.0.508.g3f0d502094-goog
Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Will Deacon

There is no functional requirement to keep the entries in arm64's tools/cpucaps file sorted alphabetically and, in fact, they have fallen out of order over time. Given that only the arm64 tree touches this file and the perceived benefit of sorting was to help with conflicts, just remove the stale comment and accept that we're collectively not very good at the alphabet.

Quoted 8 lines

In the limited cases where a specific ordering is important, we enforce it through build-time assertions (e.g. in can_use_gic_priorities()).

Cc Catalin Marinas <[email protected]>
Acked-by Mark Rutland <[email protected]>
Reviewed-by Fuad Tabba <[email protected]>
Reported-by Marc Zyngier <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>
	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
author maintainer Applied
#2 lore raw
In reply to Will Deacon
Quoted 8 lines · Will Deacon

There is no functional requirement to keep the entries in arm64's tools/cpucaps file sorted alphabetically and, in fact, they have fallen out of order over time. Given that only the arm64 tree touches this file and the perceived benefit of sorting was to help with conflicts, just remove the stale comment and accept that we're collectively not very good at the alphabet.

[...]

Applied to arm64 (for-next/cpufeature), thanks!

[1/1] arm64: cpucaps: Remove stale comment about keeping capabilities sorted

      https://git.kernel.org/arm64/c/6c74dcb1e1b7

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev