Skip to contentSkip to conversation

drivers/msi.c : use devm_ioremap replace ioremap

PATCH In review Lizhe 3 participants 3 messages Jan 21, 2023 – Jan 22, 2023 PCI

lore
Share & tools
lore

Lizhe

author
#0 lore raw

PATCH 1/1 drivers/msi.c : use devm_ioremap replace ioremap

use devm_ioremap replace ioremap

---
 drivers/pci/msi/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/msi/msi.c +1 -1
index 1f716624ca56..184eca85b88b 100644
@@ -566,7 +566,7 @@ static void __iomem *msix_map_region(struct pci_dev *dev,
 	table_offset &= PCI_MSIX_TABLE_OFFSET;
 	phys_addr = pci_resource_start(dev, bir) + table_offset;
 
-	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
+	return devm_ioremap(&dev->dev, phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
 }
 
 /**
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Lizhe

use devm_ioremap replace ioremap

---
 drivers/pci/msi/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/msi/msi.c +0 -0
index 1f716624ca56..184eca85b88b 100644

drivers/pci/msi/msi.c static void __iomem *msix_map_region(struct pci_dev *dev, · line 570

Quoted 6 lines
drivers/pci/msi/msi.c +1 -1
@@ -566,7 +566,7 @@ static void __iomem *msix_map_region(struct pci_dev *dev,
 	table_offset &= PCI_MSIX_TABLE_OFFSET;
 	phys_addr = pci_resource_start(dev, bir) + table_offset;
 
-	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
+	return devm_ioremap(&dev->dev, phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
 }

And where is the unmap dealt with? From what I can see, this will probably explode when the device is removed...

	 M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
#2 lore raw
Quoted 18 lines · Marc Zyngier
Quoted 16 lines · Lizhe

use devm_ioremap replace ioremap

---
 drivers/pci/msi/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/msi/msi.c +0 -0
index 1f716624ca56..184eca85b88b 100644
@@ -566,7 +566,7 @@ static void __iomem *msix_map_region(struct pci_dev *dev,
 	table_offset &= PCI_MSIX_TABLE_OFFSET;
 	phys_addr = pci_resource_start(dev, bir) + table_offset;
 
Quoted 6 lines

drivers/pci/msi/msi.c static void __iomem *msix_map_region(struct pci_dev *dev, · line 570

Quoted 3 lines
drivers/pci/msi/msi.c +1 -1
-	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
+	return devm_ioremap(&dev->dev, phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
 }

And where is the unmap dealt with? From what I can see, this will probably explode when the device is removed...

Right, he/she sends many random patches like this.
https://lore.kernel.org/all/Y8Pt+IdfWBVy8nIA@unreal/

Thanks

Quoted 5 lines
	 M.
Signature · 1 line
Without deviation from the norm, progress is not possible.