OpenRISC gdb port

gdb/features/or1k.xml line 2

Quoted 8 lines · Stafford Horne

gdb/features/or1k.xml new file +2 -0

new file mode 100644
index 0000000..c138a02
@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<!-- Copyright (C) 2016 Free Software Foundation, Inc.

2017.

gdb/features/or1k.xml line 5

Quoted 3 lines

gdb/features/or1k.xml new file +3 -0

+
+  set_gdbarch_print_insn (gdbarch, print_insn_or1k);
+

Don't need to set gdbarch_print_insn, so remove this line. GDB will use the default one, which selects the right disassembler in opcodes.

Otherwise, patch is good to me.

Signature · 1 line

Yao (齐尧)

Quoted 7 lines · Yao Qi

gdb/or1k-tdep.c line 1166

Quoted 2 lines · Stafford Horne

gdb/or1k-tdep.c new file +2 -0

+  set_gdbarch_print_insn (gdbarch, print_insn_or1k);
+

Don't need to set gdbarch_print_insn, so remove this line. GDB will use the default one, which selects the right disassembler in opcodes.

I removed it, but all tests start failing after that. I will look into it a bit more.

I tried to look into this, but it looks liek we do need
set_gdbarch_print_insn (). If not starting gdb hits this error in
gdbarch.c verify_gdbarch().

...
if (gdbarch->print_insn == 0)

    log.puts ("\n\tprint_insn");

...

if (!log.empty ())

    internal_error (__FILE__, __LINE__,
		    _("verify_gdbarch: the following are invalid ...%s"),
		    log.c_str ());

...

Is the automatic selecting of print_insn something new? My patch is based on yesterdays master branch of http://sourceware.org/git/binutils-gdb.git.

Quoted 7 lines · Stafford Horne

I tried to look into this, but it looks liek we do need
set_gdbarch_print_insn (). If not starting gdb hits this error in
gdbarch.c verify_gdbarch().

...
if (gdbarch->print_insn == 0)

    log.puts ("\n\tprint_insn");

These lines were removed by my commit 39503f82427e22ed8e04d986ccdc8562091ec62e (Delegate opcodes to select disassembler in GDB) on May 24th.

(quoted diff) +1 -2

-  if (gdbarch->print_insn == 0)
-    log.puts ("\n\tprint_insn");
+  /* Skip verify of print_insn, invalid_p == 0 */

Quoted 9 lines

...

if (!log.empty ())

    internal_error (__FILE__, __LINE__,
		    _("verify_gdbarch: the following are invalid ...%s"),
		    log.c_str ());

...

Quoted 2 lines

Is the automatic selecting of print_insn something new? My patch is based on yesterdays master branch of http://sourceware.org/git/binutils-gdb.git.

Looks your gdbarch.c is out of date.

2016-05-11 Stafford Horne <[email protected]>

* gdb.base/bp-permanent.c: Define nop of or1k.

gdb/testsuite/ChangeLog:

2017-04-20 Stafford Horne <[email protected]>

* gdb.xml/tdesc-regs.exp: Add or1k support.

* ChangeLog:

2017-02-12 Stafford Horne <[email protected]>

* configure.ac: Remove logic adding gdb to noconfigsdirs for or1k.
* configure: Regenerate.

Cc gcc-patches at gcc.gnu.org

---
 configure    | 7 -------
 configure.ac | 7 -------
 2 files changed, 14 deletions(-)

configure +0 -7

index be9dd89..0bf47fa 100755
@@ -3632,10 +3632,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -3841,9 +3837,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)

configure.ac +0 -8

index 532c5c2..9d16792 100644
@@ -966,10 +966,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -1175,9 +1171,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)
--

2.9.4

Hello,

This patch was sent in May, now everything is in place to commit the OpenRISC gdb port upstream except for the OK from GCC on this patch.

Are there any concerns? Who will commit this to GCC?

Quoted 66 lines · Stafford Horne

* ChangeLog:

2017-02-12 Stafford Horne <[email protected]>

* configure.ac: Remove logic adding gdb to noconfigsdirs for or1k.
* configure: Regenerate.

Cc gcc-patches at gcc.gnu.org

---
 configure    | 7 -------
 configure.ac | 7 -------
 2 files changed, 14 deletions(-)

configure +0 -7

index be9dd89..0bf47fa 100755
@@ -3632,10 +3632,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -3841,9 +3837,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)

configure.ac +0 -8

index 532c5c2..9d16792 100644
@@ -966,10 +966,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -1175,9 +1171,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)
--

2.9.4

Hello,

I brought this up on the #gcc chat room. I was asked to check with Jakub and Richi.

This is a small patch to configure/configure.ac to enable gdb to build for the or1k target. I am working on upstreaming the gdb port and have everything OKed and all copyrights in place for the binutils/gdb/sim projects.

Since binutils copies the configure/configure.ac from the gcc project I would like to get this patch incorporated into gcc before committing the binutils/gdb/sim patches.

Please let me know if there are any questions/concerns.

-Stafford

Quoted 74 lines · Stafford Horne

Hello,

This patch was sent in May, now everything is in place to commit the OpenRISC gdb port upstream except for the OK from GCC on this patch.

Are there any concerns? Who will commit this to GCC?

Quoted 66 lines · Stafford Horne

* ChangeLog:

2017-02-12 Stafford Horne <[email protected]>

* configure.ac: Remove logic adding gdb to noconfigsdirs for or1k.
* configure: Regenerate.

Cc gcc-patches at gcc.gnu.org

---
 configure    | 7 -------
 configure.ac | 7 -------
 2 files changed, 14 deletions(-)

configure +0 -7

index be9dd89..0bf47fa 100755
@@ -3632,10 +3632,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -3841,9 +3837,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)

configure.ac +0 -8

index 532c5c2..9d16792 100644
@@ -966,10 +966,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -1175,9 +1171,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)
--

2.9.4

Quoted 9 lines · Stafford Horne

Hello,

I brought this up on the #gcc chat room. I was asked to check with Jakub and Richi.

This is a small patch to configure/configure.ac to enable gdb to build for the or1k target. I am working on upstreaming the gdb port and have everything OKed and all copyrights in place for the binutils/gdb/sim projects.

Quoted 5 lines

Since binutils copies the configure/configure.ac from the gcc project I would like to get this patch incorporated into gcc before committing the binutils/gdb/sim patches.

Please let me know if there are any questions/concerns.

Ok.

Thanks,
Richard.

Quoted 79 lines

-Stafford

Quoted 74 lines · Stafford Horne

Hello,

This patch was sent in May, now everything is in place to commit the OpenRISC gdb port upstream except for the OK from GCC on this patch.

Are there any concerns? Who will commit this to GCC?

Quoted 66 lines · Stafford Horne

* ChangeLog:

2017-02-12 Stafford Horne <[email protected]>

* configure.ac: Remove logic adding gdb to noconfigsdirs for or1k.
* configure: Regenerate.

Cc gcc-patches at gcc.gnu.org

---
 configure    | 7 -------
 configure.ac | 7 -------
 2 files changed, 14 deletions(-)

configure +0 -7

index be9dd89..0bf47fa 100755
@@ -3632,10 +3632,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -3841,9 +3837,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)

configure.ac +0 -8

index 532c5c2..9d16792 100644
@@ -966,10 +966,6 @@ case "${target}" in
     ;;
   *-*-rtems*)
     noconfigdirs="$noconfigdirs target-libgloss"
-    # this is not caught below because this stanza matches earlier
-    case $target in
-      or1k*-*-*) noconfigdirs="$noconfigdirs gdb" ;;
-    esac
     ;;
     # The tpf target doesn't support gdb yet.
   *-*-tpf*)

@@ -1175,9 +1171,6 @@ case "${target}" in
   nvptx*-*-*)
     noconfigdirs="$noconfigdirs target-libssp target-libstdc++-v3 target-libobjc"
     ;;
-  or1k*-*-*)
-    noconfigdirs="$noconfigdirs gdb"
-    ;;
   sh-*-*)
     case "${target}" in
       sh*-*-elf)
--

2.9.4

Signature · 2 lines

Richard Biener <[email protected]>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)