sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
PATCH 1/1 sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
It is not used anywhere.
--- include/configs/sun7i.h | 1 - 1 file changed, 1 deletion(-)
include/configs/sun7i.h +0 -1
@@ -33,7 +33,6 @@#define CONFIG_ARMV7_VIRT 1#define CONFIG_ARMV7_NONSEC 1#define CONFIG_ARMV7_PSCI 1 -#define CONFIG_ARMV7_PSCI_NR_CPUS 2#define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE#define CONFIG_SYS_CLK_FREQ 24000000
Signature · 1 line
2.1.0
PATCH 1/1 sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
Quoted 1 line · Hans de Goede
It is not used anywhere.
Might this be an oversight because sunxi is the only SoC with psci support so far? Marc, was this added intentionally with a usecase in mind or just a left over from an earlier version of the code?
That said, I'd have expected that an NR_CPUS type setting would want to be part of the relevant PSCI backend, i.e. it would be more SoC specific.
Quoted 18 lines
Signed-off-by Hans de Goede <[email protected]>--- include/configs/sun7i.h | 1 - 1 file changed, 1 deletion(-)include/configs/sun7i.h +0
-1@@ -33,7 +33,6 @@#define CONFIG_ARMV7_VIRT 1#define CONFIG_ARMV7_NONSEC 1#define CONFIG_ARMV7_PSCI 1 -#define CONFIG_ARMV7_PSCI_NR_CPUS 2#define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE#define CONFIG_SYS_CLK_FREQ 24000000
PATCH 1/1 sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
Quoted 10 lines · Ian Campbell
Quoted 1 line · Hans de Goede
It is not used anywhere.
Might this be an oversight because sunxi is the only SoC with psci support so far? Marc, was this added intentionally with a usecase in mind or just a left over from an earlier version of the code?
That said, I'd have expected that an
NR_CPUStype setting would want to be part of the relevant PSCI backend, i.e. it would be more SoC specific.
This was in preparation of a possible reuse of that code for A31 and co, but it should indeed be SoC specific. So thumb up for removal.
Thanks,
M.
Quoted 21 lines
Quoted 18 lines
Signed-off-by Hans de Goede <[email protected]>--- include/configs/sun7i.h | 1 - 1 file changed, 1 deletion(-)include/configs/sun7i.h +0
-1@@ -33,7 +33,6 @@#define CONFIG_ARMV7_VIRT 1#define CONFIG_ARMV7_NONSEC 1#define CONFIG_ARMV7_PSCI 1 -#define CONFIG_ARMV7_PSCI_NR_CPUS 2#define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE#define CONFIG_SYS_CLK_FREQ 24000000
Signature · 1 line
Jazz is not dead. It just smells funny.
PATCH 1/1 sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
Quoted 8 lines · Marc Zyngier
Quoted 7 lines · Ian Campbell
Quoted 1 line · Hans de Goede
It is not used anywhere.
Might this be an oversight because sunxi is the only SoC with psci support so far? Marc, was this added intentionally with a usecase in mind or just a left over from an earlier version of the code?
Quoted 6 lines
Quoted 3 lines
That said, I'd have expected that an
NR_CPUStype setting would want to be part of the relevant PSCI backend, i.e. it would be more SoC specific.This was in preparation of a possible reuse of that code for A31 and co, but it should indeed be SoC specific. So thumb up for removal.
Thanks, in which case: