Skip to contentSkip to conversation

staging: rtl8192u: Remove commented header to improve code style.

PATCH In review Navya Sri Nizamkari 3 participants 9 messages Feb 22, 2015 – Feb 23, 2015 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: rtl8192u: Remove commented header to improve code style.

This patchset improves the code style in files of ieee80211 by removing the header <linux/config.h> which is commented out as it is not used in modern linux system.
This change was suggested by Arnd Bergmann.

Navya Sri Nizamkari (6):
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.

 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c  | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c     | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c         | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c         | 1 -
 6 files changed, 6 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/6 staging: rtl8192u: Remove commented header.

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c +0 -1
index 143b682..95f5fc7 100644
@@ -9,7 +9,6 @@
  * more details.
  */
 
-//#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/6 staging: rtl8192u: Remove commented header.

In reply to Navya Sri Nizamkari

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +0 -1
index fcc90a5..6201712 100644
@@ -9,7 +9,6 @@
  * more details.
  */
 
-//#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/6 staging: rtl8192u: Remove commented header.

In reply to Navya Sri Nizamkari

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c +0 -1
index 8c1bf1f..c43d0fe 100644
@@ -9,7 +9,6 @@
  * more details.
  */
 
-//#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
Signature · 1 line
1.9.1
#4 lore raw

PATCH 4/6 staging: rtl8192u: Remove commented header.

In reply to Navya Sri Nizamkari

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +0 -1
index afbd09d..e58fb28 100644
@@ -31,7 +31,6 @@
 *******************************************************************************/
 
 #include <linux/compiler.h>
-//#include <linux/config.h>
 #include <linux/errno.h>
 #include <linux/if_arp.h>
 #include <linux/in6.h>
Signature · 1 line
1.9.1
#5 lore raw

PATCH 5/6 staging: rtl8192u: Remove commented header.

In reply to Navya Sri Nizamkari

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +0 -1
index d401dbf..286b71d 100644
@@ -22,7 +22,6 @@
 
 
 #include <linux/compiler.h>
-//#include <linux/config.h>
 #include <linux/errno.h>
 #include <linux/if_arp.h>
 #include <linux/in6.h>
Signature · 1 line
1.9.1
#6 lore raw

PATCH 6/6 staging: rtl8192u: Remove commented header.

In reply to Navya Sri Nizamkari

This patch removes the commented header <linux/config.h> as it is not used in modern linux systems.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c +0 -1
index fca73c7..96ab304 100644
@@ -32,7 +32,6 @@
 ******************************************************************************/
 
 #include <linux/compiler.h>
-//#include <linux/config.h>
 #include <linux/errno.h>
 #include <linux/if_arp.h>
 #include <linux/in6.h>
Signature · 1 line
1.9.1
#7 lore raw
In reply to Navya Sri Nizamkari
Quoted 4 lines · Navya Sri Nizamkari

This patchset improves the code style in files of ieee80211 by removing the header <linux/config.h> which is commented out as it is not used in modern linux system.
This change was suggested by Arnd Bergmann.

Nice to get rid of them all at once :)

julia

Quoted 26 lines

Navya Sri Nizamkari (6):
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.
staging: rtl8192u: Remove commented header.

 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c  | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c     | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c         | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c         | 1 -
 6 files changed, 6 deletions(-)

--
1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1424640704.git.navyasri.tech%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Acked-by
#8 lore raw
Quoted 9 lines · On Monday 23 February 2015 10:08:05 Julia Lawall wrote:
Quoted 4 lines · Navya Sri Nizamkari

This patchset improves the code style in files of ieee80211 by removing the header <linux/config.h> which is commented out as it is not used in modern linux system.
This change was suggested by Arnd Bergmann.

Nice to get rid of them all at once

All patches:

Since the changes are all identical and trivial, and all in one driver, I would suggest you do a single combined patch for them, but if Greg wants to take this version, I'm fine with it too.

Arnd