mm/vmscan: fix typos in comments
Subsystems (3)
PATCH 1/1 mm/vmscan: fix typos in comments
From: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/vmscan.c +3 -3
@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
Signature · 1 line
2.34.1
Hi
Quoted 36 lines · Xiang Gao
From: Xiang Gao<[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by gaoxiang17<[email protected]>--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/vmscan.c +2
-2@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */ @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }
mm/vmscan.c static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) · line 7070
Quoted 8 lines
mm/vmscan.c +1
-1@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
LGTM
Reviewed by: Donet Tom<[email protected]>
-Donet
Hi
Quoted 9 lines · Xiang Gao
From: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by gaoxiang17 <[email protected]>
I am seeing below issue with checkpatch.pl
./scripts/checkpatch.pl --strict 0001-mm-vmscan-fix-typos-in-comments.patch
WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao <[email protected]>' != 'Signed-off-by: gaoxiang17 <[email protected]>'
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Quoted 35 lines
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/vmscan.c +3
-3@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */ @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
Hi,
Thanks for catching this. I'll fix the Signed-off-by name mismatch and send a v2.
Best regards,Xiang Gao
________________________________
发件人: Donet Tom <[email protected]>
发送时间: 2026年4月16日 12:40:12
收件人: Xiang Gao; [email protected]; [email protected]; [email protected]; [email protected]
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; 高翔 主题: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments
[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给[email protected]进行反馈
Hi
Quoted 9 lines · Xiang Gao
From: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by gaoxiang17 <[email protected]>
I am seeing below issue with checkpatch.pl
./scripts/checkpatch.pl --strict 0001-mm-vmscan-fix-typos-in-comments.patch
WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao <[email protected]>' != 'Signed-off-by: gaoxiang17 <[email protected]>'
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Quoted 35 lines
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/vmscan.c +3
-3@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */ @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
Quoted 10 lines · Xiang Gao
From: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by gaoxiang17 <[email protected]>
Should be:
Otherwise,
高翔
Reviewed-by Barry SongHi,
Thanks for catching this. I'll fix the Signed-off-by name mismatch and send a v2.
Best regards,Xiang Gao
________________________________
发件人: Barry Song <[email protected]>
发送时间: 2026年4月16日 12:49:46
收件人: Xiang Gao
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; 高翔 主题: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments
[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给[email protected]进行反馈
Quoted 10 lines · Xiang Gao
From: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by gaoxiang17 <[email protected]>
Should be:
Otherwise,
PATCH v2 1/1 mm/vmscan: fix typos in comments
In reply to Xiang GaoFrom: Xiang Gao <[email protected]>
Fix three typos in comments:
- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/vmscan.c +3 -3
@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
Signature · 1 line
2.34.1
Hi
Quoted 12 lines · Xiang Gao
From: Xiang Gao<[email protected]>
Fix three typos in comments:
- Line 112: "
zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)Signed-off-by Xiang Gao<[email protected]>Reviewed-by Barry Song<[email protected]>
It might be better to send v2 as a new series next time —just a suggestion.
LGTM Reviewed by: Donet Tom <[email protected]> -Donet
Quoted 35 lines
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/vmscan.c +3
-3@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */ @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
高翔
Reviewed-by Barry Songok, thanks.
________________________________
发件人: Donet Tom <[email protected]>
发送时间: 2026年4月16日 13:47:29
收件人: Xiang Gao; [email protected]; [email protected]; [email protected]; [email protected]
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; 高翔 主题: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments
[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给[email protected]进行反馈
Hi
On 4/16/26 10:45 AM, Xiang Gao wrote:
From: Xiang Gao <[email protected]><mailto:[email protected]>
Fix three typos in comments:
- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)
It might be better to send v2 as a new series next time —just a suggestion.
LGTM Reviewed by: Donet Tom <[email protected]><mailto:[email protected]> -Donet
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/vmscan.c +3 -3
@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))
高翔
Reviewed-by Barry SongI've sent the updated patches as v3 with your Reviewed-by tag included. Thank you for the review and the suggestion — I'll send v2/v3 as new series going forward.
________________________________
发件人: Donet Tom <[email protected]>
发送时间: 2026年4月16日 13:47:29
收件人: Xiang Gao; [email protected]; [email protected]; [email protected]; [email protected]
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; 高翔 主题: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments
[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给[email protected]进行反馈
Hi
On 4/16/26 10:45 AM, Xiang Gao wrote:
From: Xiang Gao <[email protected]><mailto:[email protected]>
Fix three typos in comments:
- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)
It might be better to send v2 as a new series next time —just a suggestion.
LGTM Reviewed by: Donet Tom <[email protected]><mailto:[email protected]> -Donet
--- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/vmscan.c +3 -3
@@ -109,7 +109,7 @@ struct scan_control {/* zone_reclaim_mode */ unsigned int may_unmap:1; -/* zome_reclaim_mode, boost reclaim, cgroup restrictions */ +/* zone_reclaim_mode, boost reclaim, cgroup restrictions */ unsigned int may_swap:1;/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)if (current_is_kswapd () ||cgroup_reclaim (sc))return ; -/* Throttle if making no progress at high prioities. */ +/* Throttle if making no progress at high priorities. */ if (sc->priority ==1 && !sc->nr_reclaimed)reclaim_throttle (pgdat,VMSCAN_THROTTLE_NOPROGRESS ); }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)/* * There should be no need to raise the scanning priority if -* enough pages are already being scanned that that high +* enough pages are already being scanned that the high * watermark would be met at 100% efficiency. */ if (kswapd_shrink_node (pgdat, &sc))