Skip to contentSkip to conversation

sysfb: correct CONFIG_SYSFB_SIMPLEFB macro name in #endif comment

PATCH In review Ethan Nelson-Moore 3 participants 3 messages Jun 11 DRM driver for firmware framebuffers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysfb: correct CONFIG_SYSFB_SIMPLEFB macro name in #endif comment

A comment in <linux/sysfb.h> incorrectly refers to CONFIG_SYSFB_SIMPLE instead of CONFIG_SYSFB_SIMPLEFB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 include/linux/sysfb.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/sysfb.h +2 -2
index 5226efde9ad4..ed23d6516223 100644
@@ -118,7 +118,7 @@ struct platform_device *sysfb_create_simplefb(const struct screen_info *si,
 					      const struct simplefb_platform_data *mode,
 					      struct device *parent);
 
-#else /* CONFIG_SYSFB_SIMPLE */
+#else /* CONFIG_SYSFB_SIMPLEFB */
 
 static inline bool sysfb_parse_mode(const struct screen_info *si,
 				    struct simplefb_platform_data *mode)
@@ -133,6 +133,6 @@ static inline struct platform_device *sysfb_create_simplefb(const struct screen_
 	return ERR_PTR(-EINVAL);
 }
 
-#endif /* CONFIG_SYSFB_SIMPLE */
+#endif /* CONFIG_SYSFB_SIMPLEFB */
 
 #endif /* _LINUX_SYSFB_H */
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am 10.06.26 um 21:52 schrieb Ethan Nelson-Moore:

Quoted 7 lines

A comment in <linux/sysfb.h> incorrectly refers to CONFIG_SYSFB_SIMPLE instead of CONFIG_SYSFB_SIMPLEFB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Quoted 25 lines
---
  include/linux/sysfb.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/sysfb.h +2 -2
index 5226efde9ad4..ed23d6516223 100644
@@ -118,7 +118,7 @@ struct platform_device *sysfb_create_simplefb(const struct screen_info *si,
  					      const struct simplefb_platform_data *mode,
  					      struct device *parent);
 
-#else /* CONFIG_SYSFB_SIMPLE */
+#else /* CONFIG_SYSFB_SIMPLEFB */
 
  static inline bool sysfb_parse_mode(const struct screen_info *si,
  				    struct simplefb_platform_data *mode)
@@ -133,6 +133,6 @@ static inline struct platform_device *sysfb_create_simplefb(const struct screen_
  	return ERR_PTR(-EINVAL);
  }
 
-#endif /* CONFIG_SYSFB_SIMPLE */
+#endif /* CONFIG_SYSFB_SIMPLEFB */
 
  #endif /* _LINUX_SYSFB_H */
Signature · 6 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Ethan Nelson-Moore

Ethan Nelson-Moore <[email protected]> writes:

Hello Ethan,

Quoted 8 lines

A comment in <linux/sysfb.h> incorrectly refers to CONFIG_SYSFB_SIMPLE instead of CONFIG_SYSFB_SIMPLEFB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat