ALSA: hda: cs35l41: Possible null pointer dereference in cs35l41_hda_unbind()
PATCH 1/1 ALSA: hda: cs35l41: Possible null pointer dereference in cs35l41_hda_unbind()
The cs35l41_hda_unbind() function clears the hda_component entry matching it's index and then dereferences the codec pointer held in the first element of the hda_component array, this is an issue when the device index was 0.
Instead use the codec pointer stashed in the cs35l41_hda structure as it will still be valid.
Fixes 7cf5ce66dfda ("ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda")
Signed-off-by Simon Trimmer <[email protected]>
--- sound/pci/hda/cs35l41_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/cs35l41_hda.c +1 -1
@@ -1495,7 +1495,7 @@ static void cs35l41_hda_unbind(struct device *dev, struct device *master, void *if (comps[cs35l41->index].dev == dev) {memset (&comps[cs35l41->index],0 ,sizeof (*comps)); sleep_flags =lock_system_sleep (); -device_link_remove (&comps->codec->core.dev, cs35l41->dev); +device_link_remove (&cs35l41->codec->core.dev, cs35l41->dev);unlock_system_sleep (sleep_flags); } }
Signature · 1 line
2.34.1
Takashi Iwai
AppliedQuoted 11 lines · Simon Trimmer
The
cs35l41_hda_unbind()function clears thehda_componententry matching it's index and then dereferences the codec pointer held in the first element of thehda_componentarray, this is an issue when the device index was 0.Instead use the codec pointer stashed in the
cs35l41_hdastructure as it will still be valid.Fixes 7cf5ce66dfda ("ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda")Signed-off-by Simon Trimmer <[email protected]>
Thanks, applied now.
Takashi