Skip to contentSkip to conversation

tests/avocado/migration: Remove the malfunctioning s390x tests

PATCH In review Thomas Huth 2 participants 2 messages Jul 21, 2023 – Jul 24, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/avocado/migration: Remove the malfunctioning s390x tests

The tests from tests/avocado/migration.py do not work at all on s390x - the bios shuts down immediately when it cannot find a boot disk, so there is nothing left to migrate here. For doing a proper migration test, we would need a proper payload, but we already do such tests in the migration *qtest*, so it is unnecessary to redo such a test here, thus let's simply remove this test.

---
I'm tempted to remove this file completely - what test coverage do we get here that we don't get by tests/qtest/migration-test.c already?

 tests/avocado/migration.py | 18 ------------------
 1 file changed, 18 deletions(-)
tests/avocado/migration.py +0 -18
index 8b2ec0e3c4..fdc1d234fb 100644
@@ -134,21 +134,3 @@ def test_migration_with_unix(self):
 
     def test_migration_with_exec(self):
         self.migration_with_exec()
-
-
-@skipUnless('s390x' in os.uname()[4], "host != target")
-class S390X(MigrationTest):
-    """
-    :avocado: tags=arch:s390x
-    :avocado: tags=machine:s390-ccw-virtio
-    :avocado: tags=cpu:qemu
-    """
-
-    def test_migration_with_tcp_localhost(self):
-        self.migration_with_tcp_localhost()
-
-    def test_migration_with_unix(self):
-        self.migration_with_unix()
-
-    def test_migration_with_exec(self):
-        self.migration_with_exec()
Signature · 1 line
2.39.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thomas Huth

The tests from tests/avocado/migration.py do not work at all on s390x - the bios shuts down immediately when it cannot find a boot disk, so there is nothing left to migrate here. For doing a proper migration test, we would need a proper payload, but we already do such tests in the migration *qtest*, so it is unnecessary to redo such a test here, thus let's simply remove this test.

Quoted 3 lines

---
I'm tempted to remove this file completely - what test coverage do we get here that we don't get by tests/qtest/migration-test.c already?

Nothing new there, just three small tests. That are included in migration-test.c

I agree we can drop it if we want to.

Later, Juan.