Add driver for MediaTek Wi-Fi 7 devices
Subsystems (2)
Shayne Chen
reviewerv2 cover Add driver for MediaTek Wi-Fi 7 devices
This series adds mt7996, a new mac80211 driver for MediaTek Wi-Fi 7 (802.11be) devices, which currently supports AP, station, mesh, and monitor modes.
mt7996 first supports Filogic 680, which is a Wi-Fi 7 chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and 2.4 GHz with 4x4 antennas on each band. There are several variants that will be added in upcoming patches. For more details, please refer to [1].
mt7996 supports only Wi-Fi 6E at the moment, whereas Wi-Fi 7 and its specific features are work in progress. They will be introduced in further patches.
The driver has had multiple developers listed in the series.
This series is based on the following series and patches:
- wifi: mt76: fix bandwidth 80MHz link fail in 6GHz band
https://patchwork.kernel.org/project/linux-wireless/patch/85b5e8374fc9b86fb955060c1840f3b2a1d187e4.1666614616.git.deren.wu@mediatek.com/
- mt76: move aggr_stats array in mt76_phy
https://patchwork.kernel.org/project/linux-wireless/cover/[email protected]/
v2:
- rebase on top of aggr_stats series to prevent from breaking other drivers
- clean up unused mcu commands
- fix some commands that haven't been changed to unified command format
- update fw path
Shayne Chen (9):
wifi: mt76: connac: rework macros for unified command
wifi: mt76: connac: update struct sta_rec_phy
wifi: mt76: connac: rework fields for larger bandwidth support in
sta_rec_bf
wifi: mt76: connac: add more unified command IDs
wifi: mt76: connac: introduce unified event table
wifi: mt76: connac: add more bss info command tags
wifi: mt76: connac: add more starec command tags
wifi: mt76: connac: introduce helper for mt7996 chipset
wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt76_connac.h | 5 + .../wireless/mediatek/mt76/mt76_connac_mcu.c | 3 +- .../wireless/mediatek/mt76/mt76_connac_mcu.h | 69 +- .../net/wireless/mediatek/mt76/mt7915/mcu.c | 10 +- .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 22 files changed, 12363 insertions(+), 12 deletions(-) create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/regs.h
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 1/9 wifi: mt76: connac: rework macros for unified command
Rework some macros for connac3 unified command. This is a preliminary patch to add mt7996 chipset support.
--- .../wireless/mediatek/mt76/mt76_connac_mcu.h | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +15 -3
@@ -63,7 +63,7 @@ struct mt76_connac2_mcu_txd { } __packed__aligned(4) ;/** -* struct mt76_connac2_mcu_uni_txd - mcu command descriptor for firmware v3 +* struct mt76_connac2_mcu_uni_txd - mcu command descriptor for connac2 and connac3 * @txd: hardware descriptor * @len: total length not including txd * @cid: command identifier
@@ -1074,10 +1074,11 @@ enum {#define MCU_CMD_ACK BIT(0)#define MCU_CMD_UNI BIT(1) -#define MCU_CMD_QUERY BIT(2) +#define MCU_CMD_SET BIT(2)#define MCU_CMD_UNI_EXT_ACK (MCU_CMD_ACK | MCU_CMD_UNI | \ - MCU_CMD_QUERY) + MCU_CMD_SET) +#define MCU_CMD_UNI_QUERY_ACK (MCU_CMD_ACK | MCU_CMD_UNI)#define __MCU_CMD_FIELD_ID GENMASK(7, 0)#define __MCU_CMD_FIELD_EXT_ID GENMASK(15, 8)
@@ -1085,6 +1086,7 @@ enum {#define __MCU_CMD_FIELD_UNI BIT(17)#define __MCU_CMD_FIELD_CE BIT(18)#define __MCU_CMD_FIELD_WA BIT(19) +#define __MCU_CMD_FIELD_WM BIT(20)#define MCU_CMD (_t) FIELD_PREP(__MCU_CMD_FIELD_ID, \ MCU_CMD_##_t)
@@ -1106,6 +1108,16 @@ enum { FIELD_PREP(__MCU_CMD_FIELD_EXT_ID, \ MCU_WA_PARAM_CMD_##_t)) +#define MCU_WM_UNI_CMD (_t) (MCU_UNI_CMD(_t) | \ + __MCU_CMD_FIELD_WM) +#define MCU_WM_UNI_CMD_QUERY (_t) (MCU_UNI_CMD(_t) | \ + __MCU_CMD_FIELD_QUERY | \ + __MCU_CMD_FIELD_WM) +#define MCU_WA_UNI_CMD (_t) (MCU_UNI_CMD(_t) | \ + __MCU_CMD_FIELD_WA) +#define MCU_WMWA_UNI_CMD (_t) (MCU_WM_UNI_CMD(_t) | \ + __MCU_CMD_FIELD_WA) +enum {MCU_EXT_CMD_EFUSE_ACCESS =0x01 ,MCU_EXT_CMD_RF_REG_ACCESS =0x02 ,
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 2/9 wifi: mt76: connac: update struct sta_rec_phy
In reply to Shayne ChenFor connac3 generation, max_ampdu_len should be filled in struct sta_rec_phy.
This is a preliminary patch to add mt7996 chipset support.
--- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +2 -1
@@ -401,7 +401,8 @@ struct sta_rec_phy {u8 ampdu;u8 rts_policy;u8 rcpi; -u8 rsv[2 ]; +u8 max_ampdu_len;/* connac3 */ +u8 rsv[1 ]; } __packed;struct sta_rec_he_6g_capa {
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 3/9 wifi: mt76: connac: rework fields for larger bandwidth support in sta_rec_bf
In reply to Shayne ChenRename nrow_bw160 and ncol_bw160 since channel width 320 MHz will share the same field.
This is a preliminary patch to add mt7996 chipset support.
--- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +2 -2
@@ -463,8 +463,8 @@ struct sta_rec_bf {u8 ibf_dbw;u8 ibf_ncol;u8 ibf_nrow; -u8 nrow_bw160; -u8 ncol_bw160; +u8 nrow_gt_bw80; +u8 ncol_gt_bw80;u8 ru_start_idx;u8 ru_end_idx;
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c +5 -5
@@ -1131,7 +1131,7 @@ mt7915_mcu_sta_bfer_he(struct ieee80211_sta *sta, struct ieee80211_vif *vif, mcs_map =le16_to_cpu (pc->he_mcs_nss_supp.rx_mcs_160); nss_mcs =mt7915_mcu_get_sta_nss (mcs_map); - bf->ncol_bw160 = nss_mcs; + bf->ncol_gt_bw80 = nss_mcs; } if (pe->phy_cap_info[0] &
@@ -1139,10 +1139,10 @@ mt7915_mcu_sta_bfer_he(struct ieee80211_sta *sta, struct ieee80211_vif *vif, mcs_map =le16_to_cpu (pc->he_mcs_nss_supp.rx_mcs_80p80); nss_mcs =mt7915_mcu_get_sta_nss (mcs_map); -if (bf->ncol_bw160) - bf->ncol_bw160 =min_t (u8, bf->ncol_bw160, nss_mcs); +if (bf->ncol_gt_bw80) + bf->ncol_gt_bw80 =min_t (u8, bf->ncol_gt_bw80, nss_mcs);else - bf->ncol_bw160 = nss_mcs; + bf->ncol_gt_bw80 = nss_mcs; } snd_dim = HE_PHY(CAP5_BEAMFORMEE_NUM_SND_DIM_ABOVE_80MHZ_MASK,
@@ -1150,7 +1150,7 @@ mt7915_mcu_sta_bfer_he(struct ieee80211_sta *sta, struct ieee80211_vif *vif, sts =HE_PHY (CAP4_BEAMFORMEE_MAX_STS_ABOVE_80MHZ_MASK , pe->phy_cap_info[4 ]); - bf->nrow_bw160 =min_t (int, snd_dim, sts); + bf->nrow_gt_bw80 =min_t (int, snd_dim, sts); } static void
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 4/9 wifi: mt76: connac: add more unified command IDs
In reply to Shayne ChenAdd more unified command IDs which will be used in new chipset. This is the preliminary patch for mt7996 support.
--- .../wireless/mediatek/mt76/mt76_connac_mcu.h | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +22 -0
@@ -1172,10 +1172,32 @@ enum {MCU_UNI_CMD_DEV_INFO_UPDATE =0x01 ,MCU_UNI_CMD_BSS_INFO_UPDATE =0x02 ,MCU_UNI_CMD_STA_REC_UPDATE =0x03 , +MCU_UNI_CMD_EDCA_UPDATE =0x04 ,MCU_UNI_CMD_SUSPEND =0x05 ,MCU_UNI_CMD_OFFLOAD =0x06 ,MCU_UNI_CMD_HIF_CTRL =0x07 , +MCU_UNI_CMD_BAND_CONFIG =0x08 , +MCU_UNI_CMD_REPT_MUAR =0x09 , +MCU_UNI_CMD_WSYS_CONFIG =0x0b , +MCU_UNI_CMD_REG_ACCESS =0x0d , +MCU_UNI_CMD_POWER_CREL =0x0f , +MCU_UNI_CMD_RX_HDR_TRANS =0x12 , +MCU_UNI_CMD_SER =0x13 , +MCU_UNI_CMD_TWT =0x14 , +MCU_UNI_CMD_RDD_CTRL =0x19 , +MCU_UNI_CMD_GET_MIB_INFO =0x22 ,MCU_UNI_CMD_SNIFFER =0x24 , +MCU_UNI_CMD_SR =0x25 , +MCU_UNI_CMD_TXPOWER =0x2b , +MCU_UNI_CMD_EFUSE_CTRL =0x2d , +MCU_UNI_CMD_RA =0x2f , +MCU_UNI_CMD_MURU =0x31 , +MCU_UNI_CMD_BF =0x33 , +MCU_UNI_CMD_CHANNEL_SWITCH =0x34 , +MCU_UNI_CMD_THERMAL =0x35 , +MCU_UNI_CMD_VOW =0x37 , +MCU_UNI_CMD_RRO =0x57 , + MCU_UNI_CMD_OFFCH_SCAN_CTRL = 0x58, }; enum {
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 5/9 wifi: mt76: connac: introduce unified event table
In reply to Shayne ChenAdd event IDs and related bit fields for unified event support. This is a preliminary patch to add mt7996 chipset support.
--- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +11 -0
@@ -993,6 +993,17 @@ enum { MCU_EXT_EVENT_MURU_CTRL = 0x9f, }; +/* unified event table */ +enum { +MCU_UNI_EVENT_RESULT =0x01 , +MCU_UNI_EVENT_FW_LOG_2_HOST =0x04 , +MCU_UNI_EVENT_IE_COUNTDOWN =0x09 , +MCU_UNI_EVENT_RDD_REPORT =0x11 , +}; + +#define MCU_UNI_CMD_EVENT BIT(1) +#define MCU_UNI_CMD_UNSOLICITED_EVENT BIT(2) +enum {MCU_Q_QUERY ,MCU_Q_SET ,
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 6/9 wifi: mt76: connac: add more bss info command tags
In reply to Shayne ChenAdd bss info tags which will be used in new chipset. This is a preliminary patch to add mt7996 chipset support.
--- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +9 -0
@@ -1258,14 +1258,23 @@ enum {enum {UNI_BSS_INFO_BASIC =0 , +UNI_BSS_INFO_RA =1 ,UNI_BSS_INFO_RLM =2 ,UNI_BSS_INFO_BSS_COLOR =4 ,UNI_BSS_INFO_HE_BASIC =5 ,UNI_BSS_INFO_BCN_CONTENT =7 , +UNI_BSS_INFO_BCN_CSA =8 , +UNI_BSS_INFO_BCN_BCC =9 , +UNI_BSS_INFO_BCN_MBSSID =10 , +UNI_BSS_INFO_RATE =11 ,UNI_BSS_INFO_QBSS =15 , +UNI_BSS_INFO_SEC =16 , +UNI_BSS_INFO_TXCMD =18 ,UNI_BSS_INFO_UAPSD =19 ,UNI_BSS_INFO_PS =21 ,UNI_BSS_INFO_BCNFT =22 , +UNI_BSS_INFO_OFFLOAD =25 , +UNI_BSS_INFO_MLD =26 , };enum {
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 7/9 wifi: mt76: connac: add more starec command tags
In reply to Shayne ChenAdd starec tags which will be used in new chipset. This is a preliminary patch to add mt7996 chipset support.
--- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h +2 -0
@@ -791,6 +791,8 @@ enum {STA_REC_PHY =0x15 ,STA_REC_HE_6G =0x17 ,STA_REC_HE_V2 =0x19 , +STA_REC_HDRT =0x28 , +STA_REC_HDR_TRANS =0x2B , STA_REC_MAX_NUM };
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 8/9 wifi: mt76: connac: introduce helper for mt7996 chipset
In reply to Shayne ChenIntroduce is_mt7996() helper for new chipset. This is a preliminary patch to support mt7996 driver.
--- drivers/net/wireless/mediatek/mt76/mt76_connac.h | 5 +++++ drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt76_connac.h +5 -0
@@ -187,6 +187,11 @@ static inline bool is_mt7986(struct mt76_dev *dev)return mt76_chip (dev) ==0x7986 ; } +static inline bool is_mt7996 (struct mt76_dev *dev) +{ +return mt76_chip (dev) ==0x7990 ; +} +static inline bool is_mt7622 (struct mt76_dev *dev) {if (!IS_ENABLED (CONFIG_MT7622_WMAC ))
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +2 -1
@@ -65,7 +65,8 @@ int mt76_connac_mcu_init_download(struct mt76_dev *dev, u32 addr, u32 len,int cmd;if ((!is_connac_v1 (dev) && addr ==MCU_PATCH_ADDRESS ) || - (is_mt7921 (dev) && addr ==0x900000 )) + (is_mt7921 (dev) && addr ==0x900000 ) || + (is_mt7996 (dev) && addr ==0x900000 )) cmd =MCU_CMD (PATCH_START_REQ );else cmd =MCU_CMD (TARGET_ADDRESS_LEN_REQ );
Signature · 1 line
2.25.1
Shayne Chen
reviewerPATCH v2 9/9 wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
In reply to Shayne ChenAdd MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices. The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7 chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and 2.4 GHz with 4x4 antennas on each band.
Currently, mt7996 only supports tri-band HE or older mode. EHT mode and more variants of Filogic 680 support will be introduced in further patches.
--- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 18 files changed, 12288 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt7996/regs.h
drivers/net/wireless/mediatek/mt76/Kconfig +1 -0
@@ -34,3 +34,4 @@ source "drivers/net/wireless/mediatek/mt76/mt7603/Kconfig" source "drivers/net/wireless/mediatek/mt76/mt7615/Kconfig" source "drivers/net/wireless/mediatek/mt76/mt7915/Kconfig" source "drivers/net/wireless/mediatek/mt76/mt7921/Kconfig" +source "drivers/net/wireless/mediatek/mt76/mt7996/Kconfig"
drivers/net/wireless/mediatek/mt76/Makefile +1 -0
@@ -35,3 +35,4 @@ obj-$(CONFIG_MT7603E) += mt7603/ obj-$(CONFIG_MT7615_COMMON) += mt7615/ obj-$(CONFIG_MT7915E) += mt7915/ obj-$(CONFIG_MT7921_COMMON) += mt7921/ +obj-$(CONFIG_MT7996E) += mt7996/
drivers/net/wireless/mediatek/mt76/mt7996/Kconfig new file +12 -0
@@ -0,0 +1,12 @@ +# SPDX-License-Identifier: ISC +config MT7996E + tristate "MediaTek MT7996 (PCIe) support" + select MT76_CONNAC_LIB + depends on MAC80211 + depends on PCI + help + This adds support for MT7996-based wireless PCIe devices, + which support concurrent tri-band operation at 6GHz, 5GHz, + and 2.4GHz IEEE 802.11be 4x4:4SS 4096-QAM, 320MHz channels. + + To compile this driver as a module, choose M here.
drivers/net/wireless/mediatek/mt76/mt7996/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: ISC + +obj-$(CONFIG_MT7996E) += mt7996e.o + +mt7996e-y := pci.o init.o dma.o eeprom.o main.o mcu.o mac.o \ + debugfs.o mmio.o
drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c new file +851 -0
851 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/dma.c new file +360 -0
360 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/eeprom.c new file +229 -0
229 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/eeprom.h new file +75 -0
75 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/init.c new file +816 -0
816 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mac.c new file +2468 -0
643 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mac.h new file +398 -0
398 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/main.c new file +1325 -0
1,325 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c new file +3428 -0
3,428 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mcu.h new file +662 -0
662 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mmio.c new file +385 -0
385 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h new file +516 -0
516 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/pci.c new file +222 -0
222 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7996/regs.h new file +533 -0
533 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.25.1
Part of the diff is not shown here. View the raw message.
Re: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
Quoted 37 lines · Shayne Chen
Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices. The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7 chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and 2.4 GHz with 4x4 antennas on each band.
Currently, mt7996 only supports tri-band HE or older mode. EHT mode and more variants of Filogic 680 support will be introduced in further patches.
Reviewed-by Ryder Lee <[email protected]>Co-developed-by Peter Chiu <[email protected]>Signed-off-by Peter Chiu <[email protected]>Co-developed-by Bo Jiao <[email protected]>Signed-off-by Bo Jiao <[email protected]>Co-developed-by Howard Hsu <[email protected]>Signed-off-by Howard Hsu <[email protected]>Co-developed-by MeiChia Chiu <[email protected]>Signed-off-by MeiChia Chiu <[email protected]>Co-developed-by StanleyYP Wang <[email protected]>Signed-off-by StanleyYP Wang <[email protected]>Co-developed-by Money Wang <[email protected]>Signed-off-by Money Wang <[email protected]>Co-developed-by Evelyn Tsai <[email protected]>Signed-off-by Evelyn Tsai <[email protected]>Signed-off-by Shayne Chen <[email protected]>--- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++
Quoted 8 lines
.../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 18 files changed, 12288 insertions(+)
This patch is too big, please split it. One patch per file is a good rule of thumb.
I did see some suspicious static variables in pci.c, but otherwise I basically skipped everything.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Ryder Lee
maintainerRe: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
Quoted 53 lines · Kalle Valo
Quoted 42 lines · Shayne Chen
Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices.
The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7
chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and
2.4 GHz with 4x4 antennas on each band.Currently, mt7996 only supports tri-band HE or older mode. EHT mode and more variants of Filogic 680 support will be introduced
in further patches.Reviewed-by Ryder Lee <[email protected]>Co-developed-by Peter Chiu <[email protected]>Signed-off-by Peter Chiu <[email protected]>Co-developed-by Bo Jiao <[email protected]>Signed-off-by Bo Jiao <[email protected]>Co-developed-by Howard Hsu <[email protected]>Signed-off-by Howard Hsu <[email protected]>Co-developed-by MeiChia Chiu <[email protected]>Signed-off-by MeiChia Chiu <[email protected]>Co-developed-by StanleyYP Wang <[email protected]>Signed-off-by StanleyYP Wang <[email protected]>Co-developed-by Money Wang <[email protected]>Signed-off-by Money Wang <[email protected]>Co-developed-by Evelyn Tsai <[email protected]>Signed-off-by Evelyn Tsai <[email protected]>Signed-off-by Shayne Chen <[email protected]>--- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++Quoted 8 lines
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 18 files changed, 12288 insertions(+)
Quoted 3 lines
This patch is too big, please split it. One patch per file is a good rule of thumb.
Hi Kalle,
Thanks for comments.
It's a bit hard to adjugement to us actually. We'd prefer to keeping one topic (wifi7 thing support for this case) one patch. I guess add code that is nor used or does not compile could get other complaints.
Given that the series has been merged to Felix's tree (and couple patches are being applied on top of his tree)... but we will take care of this part next time and split the series by functionality as much as we can. What do you think?
Quoted 2 lines
I did see some suspicious static variables in
pci.c, but otherwise I basically skipped everything.
I guess you means hif2_* which has existed in mt7915 already. These are needed for our specific secondary PCIe bus support. The related changes have been reviewd before IIRC.
Ryder
Re: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
Quoted 58 lines · Ryder Lee
Quoted 53 lines · Kalle Valo
Quoted 42 lines · Shayne Chen
Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices.
The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7
chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and
2.4 GHz with 4x4 antennas on each band.Currently, mt7996 only supports tri-band HE or older mode. EHT mode and more variants of Filogic 680 support will be introduced
in further patches.Reviewed-by Ryder Lee <[email protected]>Co-developed-by Peter Chiu <[email protected]>Signed-off-by Peter Chiu <[email protected]>Co-developed-by Bo Jiao <[email protected]>Signed-off-by Bo Jiao <[email protected]>Co-developed-by Howard Hsu <[email protected]>Signed-off-by Howard Hsu <[email protected]>Co-developed-by MeiChia Chiu <[email protected]>Signed-off-by MeiChia Chiu <[email protected]>Co-developed-by StanleyYP Wang <[email protected]>Signed-off-by StanleyYP Wang <[email protected]>Co-developed-by Money Wang <[email protected]>Signed-off-by Money Wang <[email protected]>Co-developed-by Evelyn Tsai <[email protected]>Signed-off-by Evelyn Tsai <[email protected]>Signed-off-by Shayne Chen <[email protected]>--- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++Quoted 8 lines
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 18 files changed, 12288 insertions(+)Quoted 3 lines
This patch is too big, please split it. One patch per file is a good rule of thumb.
Quoted 7 lines
Hi Kalle,
Thanks for comments.
It's a bit hard to adjugement to us actually. We'd prefer to keeping one topic (wifi7 thing support for this case) one patch. I guess add code that is nor used or does not compile could get other complaints.
Applying it to the git tree as one big commit is fine, but for reviews I always recommend splitting new drivers to one file per patch. I tried to review this huge patch and gave up, it was just too difficult.
Quoted 4 lines
Given that the series has been merged to Felix's tree (and couple patches are being applied on top of his tree)... but we will take care of this part next time and split the series by functionality as much as we can. What do you think?
One option is to send followup patches to handle the issues found during review.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Shayne Chen (陳軒丞)
reviewerRe: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
In reply to Kalle ValoQuoted 53 lines · Kalle Valo
Quoted 42 lines · Shayne Chen
Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices.
The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7
chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and
2.4 GHz with 4x4 antennas on each band.Currently, mt7996 only supports tri-band HE or older mode. EHT mode and more variants of Filogic 680 support will be introduced
in further patches.Reviewed-by Ryder Lee <[email protected]>Co-developed-by Peter Chiu <[email protected]>Signed-off-by Peter Chiu <[email protected]>Co-developed-by Bo Jiao <[email protected]>Signed-off-by Bo Jiao <[email protected]>Co-developed-by Howard Hsu <[email protected]>Signed-off-by Howard Hsu <[email protected]>Co-developed-by MeiChia Chiu <[email protected]>Signed-off-by MeiChia Chiu <[email protected]>Co-developed-by StanleyYP Wang <[email protected]>Signed-off-by StanleyYP Wang <[email protected]>Co-developed-by Money Wang <[email protected]>Signed-off-by Money Wang <[email protected]>Co-developed-by Evelyn Tsai <[email protected]>Signed-off-by Evelyn Tsai <[email protected]>Signed-off-by Shayne Chen <[email protected]>--- drivers/net/wireless/mediatek/mt76/Kconfig | 1 + drivers/net/wireless/mediatek/mt76/Makefile | 1 + .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 + .../wireless/mediatek/mt76/mt7996/Makefile | 6 + .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++ .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++ .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++ .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 + .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++ .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++ .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++Quoted 8 lines
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++ .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++ .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++ .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++ .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++ 18 files changed, 12288 insertions(+)
Quoted 6 lines
This patch is too big, please split it. One patch per file is a good rule of thumb.
I did see some suspicious static variables in
pci.c, but otherwise I basically skipped everything.
Hi Kalle,
Thanks for your reminder.
I've splitted the big patch into smaller patches by functionality for easier review.
Thanks,
Shayne
Re: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
Quoted 5 lines · [email protected] writes:
Quoted 5 lines
Quoted 1 line
18 files changed, 12288 insertions(+)This patch is too big, please split it. One patch per file is a good rule of thumb.
Quoted 7 lines
Quoted 2 lines
I did see some suspicious static variables in
pci.c, but otherwise I basically skipped everything.Thanks for your reminder.
I've splitted the big patch into smaller patches by functionality for easier review.
Nice, thanks Shayne.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches