Skip to contentSkip to conversation

package/systemd: add checklist of upgrade caveats

PATCH Applied Arnout Vandecappelle (Essensium/Mind) 4 participants 5 messages Jan 10, 2022 – Jan 13, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/systemd: add checklist of upgrade caveats

Bumping the version of systemd is a little more complicated than the usual package, and it's easy to forget some of the things that need to be done - and this has happened several times in the past.

Add a checklist of things to worry about when updating systemd.

Note that there are many other complicated packages that also need a lot of attention when upgrading. However, systemd is a really critical package so it's more important that we get that one right than, say, valgrind.

Cc Norbert Lange <[email protected]>
Cc Jérémy ROSEN <[email protected]>
Cc Adam Duskett <[email protected]>
Cc James Hilliard <[email protected]>
---
 package/systemd/systemd.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/systemd/systemd.mk +12 -0
index 3811dbae42..4d82d2ab81 100644
@@ -4,6 +4,18 @@
 #
 ################################################################################
 
+# When updating systemd, take care of the following:
+# - Check if the requirements have changed (see README), in particular
+#   arch and headers
+# - If yes, propagate the dependencies to BR2_INIT_SYSTEMD
+# - If the required kernel options have changed, update the Config.in
+#   help text and the list of KCONFIG_ENABLE_OPT.
+# - Check if there are new meson_options. Make sure all options are set
+#   explicitly (usually to default value).
+# - If there are new services:
+#   - create new options for them (if they really are optional);
+#   - create a new _USER if necessary;
+#   - create new directionry (with _PERMISSIONS) if necessary.
 SYSTEMD_VERSION = 250.1
 SYSTEMD_SITE = $(call github,systemd,systemd-stable,v$(SYSTEMD_VERSION))
 SYSTEMD_LICENSE = \
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Arnout,

Quoted 30 lines · Arnout Vandecappelle (Essensium/Mind)

Bumping the version of systemd is a little more complicated than the usual package, and it's easy to forget some of the things that need to be done - and this has happened several times in the past.

Add a checklist of things to worry about when updating systemd.

Note that there are many other complicated packages that also need a lot of attention when upgrading. However, systemd is a really critical package so it's more important that we get that one right than, say, valgrind.

Cc Norbert Lange <[email protected]>
Cc Jérémy ROSEN <[email protected]>
Cc Adam Duskett <[email protected]>
Cc James Hilliard <[email protected]>
---
 package/systemd/systemd.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/systemd/systemd.mk +2 -0
index 3811dbae42..4d82d2ab81 100644
@@ -4,6 +4,18 @@
 #
 ################################################################################
 
+# When updating systemd, take care of the following:
+# - Check if the requirements have changed (see README), in particular

package/systemd/systemd.mk line 18

Quoted 10 lines
package/systemd/systemd.mk +10 -0
+#   arch and headers
+# - If yes, propagate the dependencies to BR2_INIT_SYSTEMD
+# - If the required kernel options have changed, update the Config.in
+#   help text and the list of KCONFIG_ENABLE_OPT.
+# - Check if there are new meson_options. Make sure all options are set
+#   explicitly (usually to default value).
+# - If there are new services:
+#   - create new options for them (if they really are optional);
+#   - create a new _USER if necessary;
+#   - create new directionry (with _PERMISSIONS) if necessary.

s/directionry/directory/

baruch

Quoted 3 lines
package/systemd/systemd.mk +0 -0
 SYSTEMD_VERSION = 250.1
 SYSTEMD_SITE = $(call github,systemd,systemd-stable,v$(SYSTEMD_VERSION))
 SYSTEMD_LICENSE = \
Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Arnout Vandecappelle (Essensium/Mind)

Hello,

Am Mo., 10. Jan. 2022 um 14:16 Uhr schrieb Arnout Vandecappelle (Essensium/Mind) <[email protected]>:

Quoted 45 lines

Bumping the version of systemd is a little more complicated than the usual package, and it's easy to forget some of the things that need to be done - and this has happened several times in the past.

Add a checklist of things to worry about when updating systemd.

Note that there are many other complicated packages that also need a lot of attention when upgrading. However, systemd is a really critical package so it's more important that we get that one right than, say, valgrind.

Cc Norbert Lange <[email protected]>
Cc Jérémy ROSEN <[email protected]>
Cc Adam Duskett <[email protected]>
Cc James Hilliard <[email protected]>
---
 package/systemd/systemd.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/systemd/systemd.mk +12 -1
index 3811dbae42..4d82d2ab81 100644
@@ -4,6 +4,18 @@
 #
 ################################################################################
 
+# When updating systemd, take care of the following:
+# - Check if the requirements have changed (see README), in particular
+#   arch and headers
+# - If yes, propagate the dependencies to BR2_INIT_SYSTEMD
+# - If the required kernel options have changed, update the Config.in
+#   help text and the list of KCONFIG_ENABLE_OPT.
+# - Check if there are new meson_options. Make sure all options are set
+#   explicitly (usually to default value).
+# - If there are new services:
+#   - create new options for them (if they really are optional);
+#   - create a new _USER if necessary;
+#   - create new directionry (with _PERMISSIONS) if necessary.
 SYSTEMD_VERSION = 250.1
 SYSTEMD_SITE = $(call github,systemd,systemd-stable,v$(SYSTEMD_VERSION))
 SYSTEMD_LICENSE = \
--
Quoted 2 lines

2.31.1

I wouldd add these:

#   -  diff sysusers.d with the previous version
#   -  diff factory/etc/nsswitch.conf with the previous version
#      (details are often sprinkled around in README and manpages)

and, somewhat more cynical:

# - dont bother with x.0 versions

Norbert
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 54 lines · Norbert Lange

Hello,

Am Mo., 10. Jan. 2022 um 14:16 Uhr schrieb Arnout Vandecappelle (Essensium/Mind) <[email protected]>:

Quoted 45 lines

Bumping the version of systemd is a little more complicated than the usual package, and it's easy to forget some of the things that need to be done - and this has happened several times in the past.

Add a checklist of things to worry about when updating systemd.

Note that there are many other complicated packages that also need a lot of attention when upgrading. However, systemd is a really critical package so it's more important that we get that one right than, say, valgrind.

Cc Norbert Lange <[email protected]>
Cc Jérémy ROSEN <[email protected]>
Cc Adam Duskett <[email protected]>
Cc James Hilliard <[email protected]>
---
  package/systemd/systemd.mk | 12 ++++++++++++
  1 file changed, 12 insertions(+)
package/systemd/systemd.mk +12 -1
index 3811dbae42..4d82d2ab81 100644
@@ -4,6 +4,18 @@
  #
  ################################################################################
 
+# When updating systemd, take care of the following:
+# - Check if the requirements have changed (see README), in particular
+#   arch and headers
+# - If yes, propagate the dependencies to BR2_INIT_SYSTEMD
+# - If the required kernel options have changed, update the Config.in
+#   help text and the list of KCONFIG_ENABLE_OPT.
+# - Check if there are new meson_options. Make sure all options are set
+#   explicitly (usually to default value).
+# - If there are new services:
+#   - create new options for them (if they really are optional);
+#   - create a new _USER if necessary;
+#   - create new directionry (with _PERMISSIONS) if necessary.
  SYSTEMD_VERSION = 250.1
  SYSTEMD_SITE = $(call github,systemd,systemd-stable,v$(SYSTEMD_VERSION))
  SYSTEMD_LICENSE = \
--
Quoted 2 lines

2.31.1

I wouldd add these:

Quoted 3 lines
#   -  diff sysusers.d with the previous version
#   -  diff factory/etc/nsswitch.conf with the previous version
#      (details are often sprinkled around in README and manpages)

If you think a patch is good to go with some changes applied, please add
something like:

With those changes applied, you can add my
Reviewed-by: ...

If you reply with just a few comments (or worse, if you don't reply at all),
it's hard to know for us as maintainers if we should consider the patch approved or not.

Regards,
Arnout

Quoted 7 lines

and, somewhat more cynical:

# - dont bother with x.0 versions

Norbert

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 11 lines · On Mon, 10 Jan 2022 14:16:24 +0100 "Arnout Vandecappelle (Essensium/Mind)"…

Bumping the version of systemd is a little more complicated than the usual package, and it's easy to forget some of the things that need to be done - and this has happened several times in the past.

Add a checklist of things to worry about when updating systemd.

Note that there are many other complicated packages that also need a lot of attention when upgrading. However, systemd is a really critical package so it's more important that we get that one right than, say, valgrind.

Quoted 8 lines
Cc Norbert Lange <[email protected]>
Cc Jérémy ROSEN <[email protected]>
Cc Adam Duskett <[email protected]>
Cc James Hilliard <[email protected]>
---
 package/systemd/systemd.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Applied to master after taking into account the comments from Baruch and Norbert.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot