Skip to contentSkip to conversation

package/go: enable ARMv7 optimizations for ARMv8 target

PATCH New Michael Baudino 3 participants 3 messages Dec 18, 2020 – Dec 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/go: enable ARMv7 optimizations for ARMv8 target

Go doesn't support ARMv8 optimizations yet (see this GitHub
issue: https://github.com/golang/go/issues/29373) but can still benefit from ARMv7 optimizations.

A comment is left in go.mk to mention this and avoid any confusion when reading "ifeq ARMv8 ? GOARM = 7".

---
 package/go/go.mk | 2 ++
 1 file changed, 2 insertions(+)
go/go.mk +2 -0
index d9f4905..55964cb 100644
@@ -39,6 +39,8 @@ else ifeq ($(BR2_ARM_CPU_ARMV6),y)
 GO_GOARM = 6
 else ifeq ($(BR2_ARM_CPU_ARMV7A),y)
 GO_GOARM = 7
+else ifeq ($(BR2_ARM_CPU_ARMV8A),y)
+GO_GOARM = 7 # Go doesn't support GOARM=8 yet (see https://github.com/golang/go/issues/29373)
 endif
 else ifeq ($(BR2_aarch64),y)
 GO_GOARCH = arm64

--
2.7.4

#1 lore raw

PATCH 1/1 package/go: enable ARMv7 optimizations for ARMv8 target

Michael, All,

On 2020-12-18 10:00 +0000, Michael Baudino spake thusly:

Quoted 8 lines

Go doesn't support ARMv8 optimizations yet (see this GitHub
issue: https://github.com/golang/go/issues/29373) but can still benefit from ARMv7 optimizations.

A comment is left in go.mk to mention this and avoid any confusion when reading "ifeq ARMv8 ? GOARM = 7".

Applied to master, with a few tweaks:

- move the comment to its own line, expand and reword it a bit
- reword the commit log

Also, see below...

Quoted 9 lines
---
 package/go/go.mk | 2 ++
 1 file changed, 2 insertions(+)
go/go.mk +0 -0
index d9f4905..55964cb 100644

go/go.mk else ifeq ($(BR2_ARM_CPU_ARMV6),y) · line 43

Quoted 5 lines
go/go.mk +2 -0
@@ -39,6 +39,8 @@ else ifeq ($(BR2_ARM_CPU_ARMV6),y)
 GO_GOARM = 6
 else ifeq ($(BR2_ARM_CPU_ARMV7A),y)
 GO_GOARM = 7
+else ifeq ($(BR2_ARM_CPU_ARMV8A),y)
+GO_GOARM = 7 # Go doesn't support GOARM=8 yet (see https://github.com/golang/go/issues/29373)

Adding a comment at the end of a variable assignment can cause quite some surprising behaviours:

    $ cat Makefile
    FOO = 1 # Bleah...
    $(info "$(FOO)")
    all:
        @printf '"%s"\n' "$(FOO)"
    $ make
    "1 "
    "1 "

So I moved the comment to its own line...

Regards,
Yann E. MORIN.

Quoted 9 lines
go/go.mk +0 -1
 endif
 else ifeq ($(BR2_aarch64),y)
 GO_GOARCH = arm64
--

2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/go: enable ARMv7 optimizations for ARMv8 target

In reply to Michael Baudino
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Michael" == Michael Baudino <[email protected]> writes:

Go doesn't support ARMv8 optimizations yet (see this GitHub
issue: https://github.com/golang/go/issues/29373) but can still benefit from ARMv7 optimizations.

A comment is left in go.mk to mention this and avoid any confusion when reading "ifeq ARMv8 ? GOARM = 7".

Committed to 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard