Skip to contentSkip to conversation

riscv: Fixed kernel test robot warning

PATCH In review Souptick Joarder 3 participants 5 messages Dec 8, 2020 – Dec 11, 2020 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: Fixed kernel test robot warning

Kernel test robot throws below warning -

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

This patch should fixed it.

---
 arch/riscv/kernel/asm-offsets.c | 2 ++
 1 file changed, 2 insertions(+)
arch/riscv/kernel/asm-offsets.c +2 -0
index db20344..b79ffa3 100644
@@ -11,6 +11,8 @@
 #include <asm/thread_info.h>
 #include <asm/ptrace.h>
 
+void asm_offsets(void);
+
 void asm_offsets(void)
 {
 	OFFSET(TASK_THREAD_RA, task_struct, thread.ra);
Signature · 7 lines
1.9.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#1 lore raw
Quoted 8 lines · Souptick Joarder

Kernel test robot throws below warning -

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#2 lore raw
Quoted 5 lines · Andreas Schwab
Quoted 2 lines · Souptick Joarder

Kernel test robot throws below warning -

Quoted 8 lines
Quoted 6 lines

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will work straight forward ?
I don't know much about this area of code.

Quoted 7 lines

Andreas.

--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw
Quoted 11 lines · Souptick Joarder
Quoted 10 lines · Andreas Schwab
Quoted 7 lines · Souptick Joarder

Kernel test robot throws below warning -

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will work straight forward ?

Calling it main will suppress the warning, but other than that it is completely irrelevant how you call it.

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer
#4 lore raw
Quoted 15 lines · On Tue, 08 Dec 2020 12:22:46 PST (-0800), [email protected] wrote:
Quoted 13 lines · Souptick Joarder
Quoted 12 lines · Andreas Schwab
Quoted 8 lines · Souptick Joarder

Kernel test robot throws below warning -

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

This patch should fixed it.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will work straight forward ?

Calling it main will suppress the warning, but other than that it is completely irrelevant how you call it.

Ya, I think it doesn't really matter so I'm just going to take this as is. It's on for-next (being a bit paranoid, as we're so late in the cycle).

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv