Skip to contentSkip to conversation

package/qemu: use a system-wide slirp

PATCH New Fabrice Fontaine 2 participants 2 messages Nov 12, 2020 – Nov 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qemu: use a system-wide slirp

Use a system-wide slirp now that we switched to the up to date
https://gitlab.freedesktop.org/slirp/libslirp

qemu already depends on libglib2 so we don't need to add any new dependencies

---
 package/qemu/Config.in | 1 +
 package/qemu/qemu.mk   | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)
package/qemu/Config.in +1 -0
index 33d4cccd7b..391fd5faaf 100644
@@ -58,6 +58,7 @@ comment "Networking options"
 
 config BR2_PACKAGE_QEMU_SLIRP
 	bool "Enable user mode networking (SLIRP)"
+	select BR2_PACKAGE_SLIRP
 	help
 	  Enable user mode network stack, which is the default
 	  networking backend. It requires no administrator privileges
package/qemu/qemu.mk +4 -2
index 69850ec938..2bac96bd66 100644
@@ -51,8 +51,10 @@ endif
 
 endif
 
-# There is no "--enable-slirp"
-ifeq ($(BR2_PACKAGE_QEMU_SLIRP),)
+ifeq ($(BR2_PACKAGE_QEMU_SLIRP),y)
+QEMU_OPTS += --enable-slirp=system
+QEMU_DEPENDENCIES += slirp
+else
 QEMU_OPTS += --disable-slirp
 endif
 
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/qemu: use a system-wide slirp

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Use a system-wide slirp now that we switched to the up to date
https://gitlab.freedesktop.org/slirp/libslirp

qemu already depends on libglib2 so we don't need to add any new dependencies

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard