powerpc: add support for TIF_NOTIFY_SIGNAL
PATCH 1/1 powerpc: add support for TIF_NOTIFY_SIGNAL
Wire up TIF_NOTIFY_SIGNAL handling for powerpc.
---
5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting for details:
https://lore.kernel.org/io-uring/[email protected]/
As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.
arch/powerpc/include/asm/thread_info.h | 5 ++++- arch/powerpc/kernel/signal.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)
arch/powerpc/include/asm/thread_info.h +4 -1
@@ -90,6 +90,7 @@ void arch_setup_new_exec(void);#define TIF_SYSCALL_TRACE 0/* syscall trace active */ #define TIF_SIGPENDING 1/* signal pending */ #define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_NOTIFY_SIGNAL 3/* signal notifications exist */ #define TIF_SYSCALL_EMU 4/* syscall emulation active */ #define TIF_RESTORE_TM 5/* need to restore TM FP/VEC/VSX */ #define TIF_PATCH_PENDING 6/* pending live patching update */
@@ -115,6 +116,7 @@ void arch_setup_new_exec(void);#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED) +#define _TIF_NOTIFY_SIGNAL (1<<TIF_NOTIFY_SIGNAL)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)#define _TIF_32BIT (1<<TIF_32BIT)#define _TIF_RESTORE_TM (1<<TIF_RESTORE_TM)
@@ -136,7 +138,8 @@ void arch_setup_new_exec(void);#define _TIF_USER_WORK_MASK (_TIF_SIGPENDING | _TIF_NEED_RESCHED | \ _TIF_NOTIFY_RESUME | _TIF_UPROBE | \ - _TIF_RESTORE_TM | _TIF_PATCH_PENDING) + _TIF_RESTORE_TM | _TIF_PATCH_PENDING | \ + _TIF_NOTIFY_SIGNAL)#define _TIF_PERSYSCALL_MASK (_TIF_RESTOREALL|_TIF_NOERROR)/* Bits in local_flags */
arch/powerpc/kernel/signal.c +1 -1
@@ -318,7 +318,7 @@ void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)if (thread_info_flags & _TIF_PATCH_PENDING)klp_update_patch_state (current); -if (thread_info_flags & _TIF_SIGPENDING) { +if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) {BUG_ON (regs != current->thread.regs);do_signal (current); }
Signature · 4 lines
2.29.0 -- Jens Axboe
Quoted 9 lines · Jens Axboe
Wire up
TIF_NOTIFY_SIGNALhandling for powerpc.Signed-off-by Jens Axboe <[email protected]>---
5.11 has support queued up for
TIF_NOTIFY_SIGNAL, see this posting for details:
Quoted 6 lines
https://lore.kernel.org/io-uring/[email protected]/
As part of that work, I'm adding
TIF_NOTIFY_SIGNALsupport to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.
Happy for you to take it along with the rest of the series.
cheers
Quoted 48 lines
arch/powerpc/include/asm/thread_info.h +4
-1@@ -90,6 +90,7 @@ void arch_setup_new_exec(void);#define TIF_SYSCALL_TRACE 0/* syscall trace active */ #define TIF_SIGPENDING 1/* signal pending */ #define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_NOTIFY_SIGNAL 3/* signal notifications exist */ #define TIF_SYSCALL_EMU 4/* syscall emulation active */ #define TIF_RESTORE_TM 5/* need to restore TM FP/VEC/VSX */ #define TIF_PATCH_PENDING 6/* pending live patching update */ @@ -115,6 +116,7 @@ void arch_setup_new_exec(void);#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED) +#define _TIF_NOTIFY_SIGNAL (1<<TIF_NOTIFY_SIGNAL)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)#define _TIF_32BIT (1<<TIF_32BIT)#define _TIF_RESTORE_TM (1<<TIF_RESTORE_TM)@@ -136,7 +138,8 @@ void arch_setup_new_exec(void);#define _TIF_USER_WORK_MASK (_TIF_SIGPENDING | _TIF_NEED_RESCHED | \ _TIF_NOTIFY_RESUME | _TIF_UPROBE | \ - _TIF_RESTORE_TM | _TIF_PATCH_PENDING) + _TIF_RESTORE_TM | _TIF_PATCH_PENDING | \ + _TIF_NOTIFY_SIGNAL)#define _TIF_PERSYSCALL_MASK (_TIF_RESTOREALL|_TIF_NOERROR)/* Bits in local_flags */ arch/powerpc/kernel/signal.c +1
-1@@ -318,7 +318,7 @@ void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)if (thread_info_flags & _TIF_PATCH_PENDING)klp_update_patch_state (current); -if (thread_info_flags & _TIF_SIGPENDING) { +if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) {BUG_ON (regs != current->thread.regs);do_signal (current); }Signature · 4 lines
2.29.0 -- Jens Axboe
Quoted 12 lines · Michael Ellerman
Quoted 11 lines · Jens Axboe
Wire up
TIF_NOTIFY_SIGNALhandling for powerpc.Signed-off-by Jens Axboe <[email protected]>---
5.11 has support queued up for
TIF_NOTIFY_SIGNAL, see this posting for details:
Quoted 8 lines
Quoted 4 lines
As part of that work, I'm adding
TIF_NOTIFY_SIGNALsupport to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.Happy for you to take it along with the rest of the series.
Acked-by Michael Ellerman <[email protected]>
Great, thanks Michael! Added.
Signature · 1 line
Jens Axboe