Skip to contentSkip to conversation

serial: qcom_geni_serial: To correct QUP Version detection logic

PATCH Superseded Paras Sharma 3 participants 4 messages Aug 11, 2020 – Aug 28, 2020

Subsystems (2)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 serial: qcom_geni_serial: To correct QUP Version detection logic

The current implementation reduces the sampling rate by half if qup HW version greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Hence by adding the another check for geni SE major version, this problem can be solved.

---
 drivers/tty/serial/qcom_geni_serial.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/qcom_geni_serial.c +2 -1
index 3aa29d2..a9f92d8 100644
@@ -995,7 +995,8 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
 	sampling_rate = UART_OVERSAMPLING;
 	/* Sampling rate is halved for IP versions >= 2.5 */
 	ver = geni_se_get_qup_hw_version(&port->se);
-	if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+	if ((GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+		|| GENI_SE_VERSION_MAJOR(ver) >= 3)
 		sampling_rate /= 2;
 
 	clk_rate = get_clk_div_rate(baud, sampling_rate, &clk_div);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw
Quoted 7 lines · Paras Sharma

The current implementation reduces the sampling rate by half if qup HW version greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Quoted 7 lines

Hence by adding the another check for geni SE major version, this problem can be solved.

---
 drivers/tty/serial/qcom_geni_serial.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Should this go to stable kernels? If so, how far back? What git commit id is this patch fixing? And if so, why not put a Fixes: tag on this as well?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Paras Sharma

The current implementation reduces the sampling rate by half if qup HW version greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Hence by adding the another check for geni SE major version, this problem can be solved.

Quoted 8 lines
Quoted 4 lines
---
 drivers/tty/serial/qcom_geni_serial.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Should this go to stable kernels? If so, how far back? What git commit id is this patch fixing? And if so, why not put a Fixes: tag on this as well?

Dropped from my review queue due to lack of response, please fix up and resend when you wish to have it reviewed again...

greg k-h

#3 lore raw
In reply to Paras Sharma

Hi,

Quoted 2 lines · Paras Sharma

The current implementation reduces the sampling rate by half if qup HW version greater is than 2.5 by checking if the geni

^^^^^^^^^^^^^^^
is greater than

could, possibly, be fixed while applying.

Quoted 18 lines

SE major version is greater than 2 and geni SE minor version is greater than 5.

This implementation fails when the version is 3 or greater.

Hence by adding the another check for geni SE major version, this problem can be solved.

---
 drivers/tty/serial/qcom_geni_serial.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/qcom_geni_serial.c +0 -0
index 3aa29d2..a9f92d8 100644

drivers/tty/serial/qcom_geni_serial.c static void qcom_geni_serial_set_termios(struct uart_port *uport, · line 999

Quoted 6 lines
drivers/tty/serial/qcom_geni_serial.c +2 -1
@@ -995,7 +995,8 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
 	sampling_rate = UART_OVERSAMPLING;
 	/* Sampling rate is halved for IP versions >= 2.5 */
 	ver = geni_se_get_qup_hw_version(&port->se);
-	if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+	if ((GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+		|| GENI_SE_VERSION_MAJOR(ver) >= 3)

it looks like having a single GENI_SE_VERSION() that returns MAJOR and MINOR without STEP would look better here. Then you could use:

	if (GENI_SE_VERSION(ver) >= 0x20050000)

and it would work for any future version. Not a strong opinion, though

Signature · 1 line
balbi