package/qt5xmlpatterns: enable qml module
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
qt5declarative:
- remove unneded dependency on qt5mlpatterns
qt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml files
---
Changes v1 -> v2:
- add Reported-by
- s/=/+=/ for qt5declarative dependency
--- package/qt5/qt5declarative/Config.in | 1 - package/qt5/qt5declarative/qt5declarative.mk | 2 +- package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk | 11 +++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-)
package/qt5/qt5declarative/Config.in +0 -1
@@ -1,7 +1,6 @@ config BR2_PACKAGE_QT5DECLARATIVE bool "qt5declarative" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - select BR2_PACKAGE_QT5XMLPATTERNS select BR2_PACKAGE_QT5BASE select BR2_PACKAGE_QT5BASE_GUI help
package/qt5/qt5declarative/qt5declarative.mk +1 -1
@@ -7,7 +7,7 @@ QT5DECLARATIVE_VERSION = $(QT5_VERSION) QT5DECLARATIVE_SITE = $(QT5_SITE) QT5DECLARATIVE_SOURCE = qtdeclarative-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5DECLARATIVE_VERSION).tar.xz -QT5DECLARATIVE_DEPENDENCIES = qt5base qt5xmlpatterns +QT5DECLARATIVE_DEPENDENCIES = qt5base QT5DECLARATIVE_INSTALL_STAGING = YES ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk +11 -0
@@ -21,6 +21,10 @@ ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) QT5XMLPATTERNS_LICENSE += , BSD-3-Clause (examples) endif +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE),y) +QT5XMLPATTERNS_DEPENDENCIES += qt5declarative +endif + define QT5XMLPATTERNS_CONFIGURE_CMDS (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/bin/qmake) endef
@@ -39,6 +43,12 @@ define QT5XMLPATTERNS_INSTALL_TARGET_LIBS endef endif +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y) +define QT5XMLPATTERNS_INSTALL_TARGET_QMLS + cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick/XmlListModel $(TARGET_DIR)/usr/qml/QtQuick +endef +endif + ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) define QT5XMLPATTERNS_INSTALL_TARGET_EXAMPLES cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/xmlpatterns $(TARGET_DIR)/usr/lib/qt/examples/
@@ -47,6 +57,7 @@ endif define QT5XMLPATTERNS_INSTALL_TARGET_CMDS $(QT5XMLPATTERNS_INSTALL_TARGET_LIBS) + $(QT5XMLPATTERNS_INSTALL_TARGET_QMLS) $(QT5XMLPATTERNS_INSTALL_TARGET_EXAMPLES) endef
Signature · 1 line
2.25.1
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Hello Peter,
Quoted 9 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesReported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>
Will you send a similar patch for master ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 12 lines · Thomas Petazzoni
Hello Peter,
Quoted 7 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml files
Quoted 9 lines
Quoted 2 lines
Reported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Thomas,
Please wait for my Tested-by: :)
Peter,
This is not working for me after using your V2 patch. Perhaps it is my own user error. The patch simply seems to change some dependencies around (which looks correct now) and explicitly copies a XmlListModel folder into $(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even with the qt5declarative and qt5xmlpatterns packages checked. For reference, here is everything mentioning xmllistmodel in the qt5 build directory:
~/Desktop/test_defconfig_output/build$ find . -iname "*xmllistmodel*" ./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png ./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
It seems like the xmllistmodel.pro file there is indeed compiling it as a plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml because again, it doesn't seem to be compiling it. I don't see anything in the xmlpatterns Makefile that explicitly goes into src/imports and compiles it.
Also, in the case there are more imports there in the future, should it not be compiling all the projects in build/qt5xmlpatterns-5.12.7/src/imports/ imports.pro? This would compile all the projects listed in SUBDIRS there, and output the appropriate folder with it's .so, plugins.qmltypes, and qmldir, which then could be copied over.
Let me know if I'm missing something.
Thanks,
Nimai
Quoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200314/a7e06bba/attachment.html>
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Hello Nimai,
Quoted 29 lines · Nimai Mahajan
Quoted 12 lines · Thomas Petazzoni
Hello Peter,
Quoted 7 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesQuoted 9 lines
Quoted 2 lines
Reported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Thomas,
Please wait for my Tested-by: :)
Quoted 8 lines
Peter,
This is not working for me after using your V2 patch. Perhaps it is my own user error. The patch simply seems to change some dependencies around (which looks correct now) and explicitly copies a XmlListModel folder into $(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even with the qt5declarative and qt5xmlpatterns packages checked. For reference, here is everything mentioning xmllistmodel in the qt5 build directory:
In this case your should get a buildroot error for the copy command..., or your .config is wrong..., or you did no re-build of the package?
Quoted 12 lines
~/Desktop/test_defconfig_output/build$ find . -iname "*xmllistmodel*" ./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png ./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 4 lines
It seems like the xmllistmodel.pro file there is indeed compiling it as a plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml because again, it doesn't seem to be compiling it. I don't see anything in the xmlpatterns
Makefilethat explicitly goes into src/imports and compiles it.
The decision is made in the file build/qt5xmlpatterns-5.12.7/src/src.pro:
TEMPLATE = subdirs
SUBDIRS += xmlpatterns
qtHaveModule(qml){
SUBDIRS += imports
imports.depends = xmlpatterns
}
Quoted 8 lines
Also, in the case there are more imports there in the future, should it not be compiling all the projects in build/qt5xmlpatterns-5.12.7/src/imports/ imports.pro? This would compile all the projects listed in SUBDIRS there, and output the appropriate folder with it's .so, plugins.qmltypes, and qmldir, which then could be copied over.
Let me know if I'm missing something.
Try a complete re-build (after make clean)...., in case of failure please provide your .config/defconfig...
Regards,
Peter
Tested locally with the following defconfig:
BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_GCC_VERSION_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
BR2_ROOTFS_POST_SCRIPT_ARGS="--add-miniuart-bt-overlay"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,64d0a9870ac14d5eb5253f67d984ae348eec1393)/linux-64d0a9870ac14d5eb5253f67d984ae348eec1393.tar.gz" BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_EGLFS=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_USERLAND=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
# BR2_TARGET_ROOTFS_TAR is not set
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
$ find . -iname "*xmllistmodel*" ./build/qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png ./build/qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/moc_qqmlxmllistmodel_p.o ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/qqmlxmllistmodel.o ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/moc_qqmlxmllistmodel_p.cpp ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/qqmlxmllistmodel.moc ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp ./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel ./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel ./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./target/usr/qml/QtQuick/XmlListModel ./target/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 11 lines
Thanks,
NimaiQuoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 41 lines · Peter Seiderer
Hello Nimai,
Quoted 25 lines · Nimai Mahajan
Quoted 12 lines · Thomas Petazzoni
Hello Peter,
Quoted 7 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesQuoted 9 lines
Quoted 2 lines
Reported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Quoted 7 lines
Thomas,
Please wait for my Tested-by: :)
Peter,
This is not working for me after using your V2 patch. Perhaps it is my
own
Quoted 2 lines
user error. The patch simply seems to change some dependencies around (which looks correct now) and explicitly copies a XmlListModel folder
into
Quoted 9 lines
Quoted 1 line
$(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even with
the
Quoted 1 line
qt5declarative and qt5xmlpatterns packages checked. For reference, here
is
Quoted 1 line
everything mentioning xmllistmodel in the qt5 build directory:
In this case your should get a buildroot error for the copy command..., or your .config is wrong..., or you did no re-build of the package?
I rebuilt from scratch after patching, so definitely is strange why I did not get output like yours below. But I will wipe out the entire project, re-clone, patch, and try again.
Quoted 25 lines
Quoted 5 lines
~/Desktop/test_defconfig_output/build$ find . -iname "*xmllistmodel*" ./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 6 lines
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro
Quoted 1 line
./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 2 lines
It seems like the xmllistmodel.pro file there is indeed compiling it as
a
Quoted 3 lines
plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml because again, it doesn't seem to be compiling it. I don't see anything in the xmlpatterns
Makefilethat explicitly goes into src/imports and compilesit.
The decision is made in the file build/qt5xmlpatterns-5.12.7/src/src.pro:
Quoted 8 lines
TEMPLATE = subdirs
SUBDIRS += xmlpatternsqtHaveModule(qml){
SUBDIRS += imports
imports.depends = xmlpatterns
}
Ahh I see, thanks!
Quoted 6 lines
Quoted 3 lines
Also, in the case there are more imports there in the future, should it
not
Quoted 2 lines
be compiling all the projects in build/qt5xmlpatterns-5.12.7/src/imports/ imports.pro? This would compile all the projects listed in SUBDIRS
Quoted 9 lines
there,
Quoted 4 lines
and output the appropriate folder with it's .so, plugins.qmltypes, and qmldir, which then could be copied over.
Let me know if I'm missing something.
Try a complete re-build (after make clean)...., in case of failure please provide your .config/defconfig...
Already provided here:
http://buildroot-busybox.2317881.n4.nabble.com/2020-02-Buildroot-Qt-5-12-missing-XmlListModel-tp249854p249918.html
.
Quoted 67 lines
Regards,
PeterTested locally with the following defconfig:
BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_GCC_VERSION_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh" BR2_ROOTFS_POST_SCRIPT_ARGS="--add-miniuart-bt-overlay"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,64d0a9870ac14d5eb5253f67d984ae348eec1393)/linux-64d0a9870ac14d5eb5253f67d984ae348eec1393.tar.gz" BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus
bcm2710-rpi-cm3"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_EGLFS=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_USERLAND=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
#BR2_TARGET_ROOTFS_TARis not set
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y$ find . -iname "*xmllistmodel*"./build/qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
./build/qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/moc_qqmlxmllistmodel_p.o
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/qqmlxmllistmodel.o./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/moc_qqmlxmllistmodel_p.cpp
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/qqmlxmllistmodel.moc ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/ qquickxmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp ./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel
Quoted 20 lines
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./target/usr/qml/QtQuick/XmlListModel ./target/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 11 lines
Thanks,
NimaiQuoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200314/817c4312/attachment.html>
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 103 lines · Nimai Mahajan
Quoted 41 lines · Peter Seiderer
Hello Nimai,
Quoted 25 lines · Nimai Mahajan
Quoted 12 lines · Thomas Petazzoni
Hello Peter,
Quoted 7 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesQuoted 9 lines
Quoted 2 lines
Reported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Quoted 7 lines
Thomas,
Please wait for my Tested-by: :)
Peter,
This is not working for me after using your V2 patch. Perhaps it is my
own
Quoted 2 lines
user error. The patch simply seems to change some dependencies around (which looks correct now) and explicitly copies a XmlListModel folder
into
Quoted 9 lines
Quoted 1 line
$(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even with
the
Quoted 1 line
qt5declarative and qt5xmlpatterns packages checked. For reference, here
is
Quoted 1 line
everything mentioning xmllistmodel in the qt5 build directory:
In this case your should get a buildroot error for the copy command..., or your .config is wrong..., or you did no re-build of the package?
I rebuilt from scratch after patching, so definitely is strange why I did not get output like yours below. But I will wipe out the entire project, re-clone, patch, and try again.
Quoted 25 lines
Quoted 5 lines
~/Desktop/test_defconfig_output/build$ find . -iname "*xmllistmodel*" ./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 6 lines
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro
Quoted 1 line
./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 2 lines
It seems like the xmllistmodel.pro file there is indeed compiling it as
a
Quoted 3 lines
plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml because again, it doesn't seem to be compiling it. I don't see anything in the xmlpatterns
Makefilethat explicitly goes into src/imports and compilesit.
The decision is made in the file build/qt5xmlpatterns-5.12.7/src/src.pro:
Quoted 8 lines
TEMPLATE = subdirs
SUBDIRS += xmlpatternsqtHaveModule(qml){
SUBDIRS += imports
imports.depends = xmlpatterns
}Ahh I see, thanks!
Quoted 10 lines
Quoted 3 lines
Also, in the case there are more imports there in the future, should it
not
Quoted 2 lines
be compiling all the projects in build/qt5xmlpatterns-5.12.7/src/imports/ imports.pro? This would compile all the projects listed in SUBDIRS
there,
Quoted 3 lines
and output the appropriate folder with it's .so, plugins.qmltypes, and qmldir, which then could be copied over.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Let me know if I'm missing something.
Try a complete re-build (after make clean)...., in case of failure please provide your .config/defconfig...
Already provided here:
http://buildroot-busybox.2317881.n4.nabble.com/2020-02-Buildroot-Qt-5-12-missing-XmlListModel-tp249854p249918.html
No plain config,...dependecies to $(BR2_EXTERNAL), and:
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_CONCURRENT=y
BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
BR2_PACKAGE_QT5BASE_LINUXFB=y
BR2_PACKAGE_QT5BASE_XCB=y
BR2_PACKAGE_QT5BASE_DEFAULT_QPA="xcb"
BR2_PACKAGE_QT5BASE_TSLIB=y
BR2_PACKAGE_QT5SERIALBUS=y
BR2_PACKAGE_QT5SVG=y
And the following is not selected:
BR2_PACKAGE_QT5DECLARATIVE=y
BR2_PACKAGE_QT5DECLARATIVE_QUICK=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=y
Try to provide a plain .config against 2020.02..., without externals...
Regards,
Peter
Quoted 89 lines
Quoted 89 lines
Regards,
PeterTested locally with the following defconfig:
BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_GCC_VERSION_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh" BR2_ROOTFS_POST_SCRIPT_ARGS="--add-miniuart-bt-overlay"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,64d0a9870ac14d5eb5253f67d984ae348eec1393)/linux-64d0a9870ac14d5eb5253f67d984ae348eec1393.tar.gz" BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus
bcm2710-rpi-cm3"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_EGLFS=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_USERLAND=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
#BR2_TARGET_ROOTFS_TARis not set
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y$ find . -iname "*xmllistmodel*"./build/qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
./build/qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/moc_qqmlxmllistmodel_p.o
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/qqmlxmllistmodel.o./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/moc_qqmlxmllistmodel_p.cpp
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/qqmlxmllistmodel.moc ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/ qquickxmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp ./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so ./target/usr/qml/QtQuick/XmlListModel ./target/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 11 lines
Thanks,
NimaiQuoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 154 lines · Peter Seiderer
Quoted 1 line · Nimai Mahajan
On Sat, Mar 14, 2020 at 1:53 PM Peter Seiderer <[email protected]>
Quoted 31 lines · wrote:
Quoted 31 lines
Hello Nimai,
Quoted 25 lines · Nimai Mahajan
Quoted 21 lines · Thomas Petazzoni
Hello Peter,
Quoted 9 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesReported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Thomas,
Please wait for my Tested-by: :)
Peter,
This is not working for me after using your V2 patch. Perhaps it is
my
Quoted 5 lines
Quoted 5 lines
own
Quoted 2 lines
user error. The patch simply seems to change some dependencies around (which looks correct now) and explicitly copies a XmlListModel folder
into
Quoted 1 line
$(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even
with
Quoted 2 lines
Quoted 2 lines
the
Quoted 1 line
qt5declarative and qt5xmlpatterns packages checked. For reference,
here
Quoted 4 lines
Quoted 4 lines
is
Quoted 1 line
everything mentioning xmllistmodel in the qt5 build directory:
In this case your should get a buildroot error for the copy
command..., or
Quoted 11 lines
Quoted 2 lines
your .config is wrong..., or you did no re-build of the package?
I rebuilt from scratch after patching, so definitely is strange why I did not get output like yours below. But I will wipe out the entire project, re-clone, patch, and try again.
Quoted 4 lines
Quoted 4 lines
~/Desktop/test_defconfig_output/build$ find . -iname "*xmllistmodel*"
./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.h./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/qquickxmllistmodel.pro
Quoted 1 line
./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
It seems like the xmllistmodel.pro file there is indeed compiling
it as
Quoted 2 lines
Quoted 2 lines
a
Quoted 1 line
plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml
because
Quoted 1 line
Quoted 1 line
Quoted 1 line
again, it doesn't seem to be compiling it. I don't see anything in
the
Quoted 1 line
Quoted 1 line
Quoted 1 line
xmlpatterns
Makefilethat explicitly goes into src/imports andcompiles
Quoted 3 lines
Quoted 3 lines
it.
The decision is made in the file build/qt5xmlpatterns-5.12.7/src/
src.pro:
Quoted 4 lines
Quoted 4 lines
TEMPLATE = subdirs
SUBDIRS += xmlpatternsQuoted 11 lines
Quoted 5 lines
qtHaveModule(qml){
SUBDIRS += imports
imports.depends = xmlpatterns
}Ahh I see, thanks!
Quoted 3 lines
Quoted 3 lines
Also, in the case there are more imports there in the future, should
it
Quoted 2 lines
Quoted 2 lines
not
Quoted 1 line
be compiling all the projects in
build/qt5xmlpatterns-5.12.7/src/imports/
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
imports.pro? This would compile all the projects listed in SUBDIRS
there,
Quoted 1 line
and output the appropriate folder with it's .so, plugins.qmltypes,
and
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
qmldir, which then could be copied over.
Let me know if I'm missing something.
Try a complete re-build (after make clean)...., in case of failure
please
Quoted 5 lines
Quoted 2 lines
provide your .config/defconfig...
Already provided here:
No plain config,...dependecies to $(BR2_EXTERNAL), and:
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_CONCURRENT=y
BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
BR2_PACKAGE_QT5BASE_LINUXFB=y
BR2_PACKAGE_QT5BASE_XCB=y
BR2_PACKAGE_QT5BASE_DEFAULT_QPA="xcb"
BR2_PACKAGE_QT5BASE_TSLIB=y
BR2_PACKAGE_QT5SERIALBUS=y
BR2_PACKAGE_QT5SVG=yAnd the following is not selected:
BR2_PACKAGE_QT5DECLARATIVE=y
BR2_PACKAGE_QT5DECLARATIVE_QUICK=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=y
Quoted 5 lines
Try to provide a plain .config against 2020.02..., without externals...
Regards,
Peter
Thanks for your patience Peter. All is good, my application DOES indeed work. I nuked my previous config, ccache, etc. and started from scratch cloning a fresh copy of BR 2020.02 and redoing my config and now it correctly builds. The module is there and loads with my old import statement.
Quoted 82 lines
Quoted 10 lines
Quoted 10 lines
Regards,
PeterTested locally with the following defconfig:
Quoted 16 lines
Quoted 7 lines
BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_GCC_VERSION_9_X=yQuoted 9 lines
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh" BR2_ROOTFS_POST_SCRIPT_ARGS="--add-miniuart-bt-overlay" BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(callgithub,raspberrypi,linux,64d0a9870ac14d5eb5253f67d984ae348eec1393)/linux-64d0a9870ac14d5eb5253f67d984ae348eec1393.tar.gz"
Quoted 20 lines
Quoted 20 lines
BR2_LINUX_KERNEL_DEFCONFIG="bcm2709" BR2_LINUX_KERNEL_DTS_SUPPORT=y BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_EGLFS=y
BR2_PACKAGE_QT5QUICKCONTROLS=y BR2_PACKAGE_QT5QUICKCONTROLS2=y BR2_PACKAGE_QT5XMLPATTERNS=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_USERLAND=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
#BR2_TARGET_ROOTFS_TARis not set BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=yQuoted 3 lines
Quoted 3 lines
$ find . -iname "*xmllistmodel*"./build/qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
Quoted 2 lines
Quoted 2 lines
./build/qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp
Quoted 1 line
Quoted 1 line
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.hQuoted 1 line
Quoted 1 line
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/
xmllistmodel.pro
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/moc_qqmlxmllistmodel_p.oQuoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/qqmlxmllistmodel.oQuoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/moc_qqmlxmllistmodel_p.cpp
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/qqmlxmllistmodel.moc
Quoted 5 lines
Quoted 5 lines
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/ qquickxmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 3 lines
Quoted 3 lines
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel
Quoted 24 lines
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 1 line
Quoted 1 line
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel
Quoted 2 lines
Quoted 2 lines
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 16 lines
Quoted 16 lines
./target/usr/qml/QtQuick/XmlListModel ./target/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 11 lines
Thanks,
NimaiQuoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200314/9e95ec4d/attachment.html>
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 169 lines · Nimai Mahajan
Quoted 160 lines · Peter Seiderer
Quoted 1 line · Nimai Mahajan
On Sat, Mar 14, 2020 at 1:53 PM Peter Seiderer <[email protected]>
Quoted 31 lines · wrote:
Quoted 31 lines
Hello Nimai,
Quoted 25 lines · Nimai Mahajan
Quoted 21 lines · Thomas Petazzoni
Hello Peter,
Quoted 9 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatternsqt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesReported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Thanks,
Thomas
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Thomas,
Please wait for my Tested-by: :)
Peter,
This is not working for me after using your V2 patch. Perhaps it is
my
Quoted 2 lines
Quoted 2 lines
own
Quoted 1 line
user error. The patch simply seems to change some dependencies
around
Quoted 1 line
Quoted 1 line
Quoted 1 line
(which looks correct now) and explicitly copies a XmlListModel
folder
Quoted 2 lines
Quoted 2 lines
into
Quoted 1 line
$(TARGET_DIR)/usr/qml/QtQuick, but there is nothing to copy, even
with
Quoted 2 lines
Quoted 2 lines
the
Quoted 1 line
qt5declarative and qt5xmlpatterns packages checked. For reference,
here
Quoted 4 lines
Quoted 4 lines
is
Quoted 1 line
everything mentioning xmllistmodel in the qt5 build directory:
In this case your should get a buildroot error for the copy
command..., or
Quoted 4 lines
Quoted 2 lines
your .config is wrong..., or you did no re-build of the package?
I rebuilt from scratch after patching, so definitely is strange why I
did
Quoted 6 lines
not get output like yours below. But I will wipe out the entire project, re-clone, patch, and try again.
Quoted 3 lines
Quoted 3 lines
~/Desktop/test_defconfig_output/build$ find . -iname
"*xmllistmodel*"
Quoted 1 line
Quoted 1 line
Quoted 1 line
./qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
./qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel ./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/xmllistmodel.pro
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.hQuoted 1 line
Quoted 1 line
Quoted 1 line
./qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/
qquickxmllistmodel.pro
Quoted 1 line
./qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
It seems like the xmllistmodel.pro file there is indeed compiling
it as
Quoted 2 lines
Quoted 2 lines
a
Quoted 1 line
plugin, but there is no XmlListModel in $(STAGING_DIR)/usr/qml
because
Quoted 1 line
Quoted 1 line
Quoted 1 line
again, it doesn't seem to be compiling it. I don't see anything in
the
Quoted 1 line
Quoted 1 line
Quoted 1 line
xmlpatterns
Makefilethat explicitly goes into src/imports andcompiles
Quoted 3 lines
Quoted 3 lines
it.
The decision is made in the file build/qt5xmlpatterns-5.12.7/src/
src.pro:
Quoted 4 lines
Quoted 4 lines
TEMPLATE = subdirs
SUBDIRS += xmlpatternsQuoted 11 lines
Quoted 5 lines
qtHaveModule(qml){
SUBDIRS += imports
imports.depends = xmlpatterns
}Ahh I see, thanks!
Quoted 3 lines
Quoted 3 lines
Also, in the case there are more imports there in the future,
should it
Quoted 2 lines
Quoted 2 lines
not
Quoted 1 line
be compiling all the projects in
build/qt5xmlpatterns-5.12.7/src/imports/
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
imports.pro? This would compile all the projects listed in SUBDIRS
there,
Quoted 1 line
and output the appropriate folder with it's .so, plugins.qmltypes,
and
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
qmldir, which then could be copied over.
Let me know if I'm missing something.
Try a complete re-build (after make clean)...., in case of failure
please
Quoted 5 lines
Quoted 2 lines
provide your .config/defconfig...
Already provided here:
No plain config,...dependecies to $(BR2_EXTERNAL), and:
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_CONCURRENT=y
BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
BR2_PACKAGE_QT5BASE_LINUXFB=y
BR2_PACKAGE_QT5BASE_XCB=y
BR2_PACKAGE_QT5BASE_DEFAULT_QPA="xcb"
BR2_PACKAGE_QT5BASE_TSLIB=y
BR2_PACKAGE_QT5SERIALBUS=y
BR2_PACKAGE_QT5SVG=yAnd the following is not selected:
BR2_PACKAGE_QT5DECLARATIVE=y
BR2_PACKAGE_QT5DECLARATIVE_QUICK=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5QUICKCONTROLS2=y
BR2_PACKAGE_QT5XMLPATTERNS=yQuoted 5 lines
Try to provide a plain .config against 2020.02..., without externals...
Regards,
Peter
Quoted 6 lines
Thanks for your patience Peter. All is good, my application DOES indeed work. I nuked my previous config, ccache, etc. and started from scratch cloning a fresh copy of BR 2020.02 and redoing my config and now it correctly builds. The module is there and loads with my old import statement.
Quoted 96 lines
Quoted 96 lines
Quoted 9 lines
Quoted 9 lines
Regards,
PeterTested locally with the following defconfig:
Quoted 16 lines
Quoted 7 lines
BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_GCC_VERSION_9_X=yQuoted 9 lines
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh" BR2_ROOTFS_POST_SCRIPT_ARGS="--add-miniuart-bt-overlay" BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(callgithub,raspberrypi,linux,64d0a9870ac14d5eb5253f67d984ae348eec1393)/linux-64d0a9870ac14d5eb5253f67d984ae348eec1393.tar.gz"
Quoted 20 lines
Quoted 20 lines
BR2_LINUX_KERNEL_DEFCONFIG="bcm2709" BR2_LINUX_KERNEL_DTS_SUPPORT=y BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_EGLFS=y
BR2_PACKAGE_QT5QUICKCONTROLS=y BR2_PACKAGE_QT5QUICKCONTROLS2=y BR2_PACKAGE_QT5XMLPATTERNS=y
BR2_PACKAGE_RPI_FIRMWARE=y
BR2_PACKAGE_RPI_USERLAND=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
#BR2_TARGET_ROOTFS_TARis not set BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=yQuoted 3 lines
Quoted 3 lines
$ find . -iname "*xmllistmodel*"./build/qt5declarative-5.12.7/src/quick/doc/images/qml-xmllistmodel-example.png
Quoted 2 lines
Quoted 2 lines
./build/qt5declarative-5.12.7/tests/testapplications/elements/content/XmlListModelElement.qml
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel.cpp
Quoted 1 line
Quoted 1 line
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/qqmlxmllistmodel_p.hQuoted 1 line
Quoted 1 line
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/
xmllistmodel.pro
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/moc_qqmlxmllistmodel_p.oQuoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.obj/qqmlxmllistmodel.oQuoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/moc_qqmlxmllistmodel_p.cpp
Quoted 2 lines
Quoted 2 lines
./build/qt5xmlpatterns-5.12.7/src/imports/xmllistmodel/.moc/qqmlxmllistmodel.moc
Quoted 5 lines
Quoted 5 lines
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel ./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/ qquickxmllistmodel.pro
./build/qt5xmlpatterns-5.12.7/tests/auto/qquickxmllistmodel/tst_qquickxmllistmodel.cpp
Quoted 3 lines
Quoted 3 lines
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel
./build/qt5xmlpatterns-5.12.7/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 1 line
Quoted 1 line
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel
Quoted 2 lines
Quoted 2 lines
./host/arm-buildroot-linux-gnueabihf/sysroot/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 9 lines
Quoted 9 lines
./target/usr/qml/QtQuick/XmlListModel ./target/usr/qml/QtQuick/XmlListModel/libqmlxmllistmodelplugin.so
Quoted 6 lines
Thanks,
Nimai
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200314/0c8d5a6d/attachment.html>
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
In reply to Nimai MahajanHello Nimai,
Quoted 7 lines · Nimai Mahajan
Thanks for your patience Peter. All is good, my application DOES indeed work. I nuked my previous config, ccache, etc. and started from scratch cloning a fresh copy of BR 2020.02 and redoing my config and now it correctly builds. The module is there and loads with my old import statement.
That's good news, and many thanks back to you for your patience to re-test ;-)
Regards,
Peter
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Seiderer <[email protected]> writes:
Hello Nimai,
Quoted 1 line · Nimai Mahajan
Quoted 8 lines
Quoted 6 lines
Thanks for your patience Peter. All is good, my application DOES indeed work. I nuked my previous config, ccache, etc. and started from scratch cloning a fresh copy of BR 2020.02 and redoing my config and now it correctly builds. The module is there and loads with my old import statement.
That's good news, and many thanks back to you for your patience to re-test ;-)
Committed to 2020.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 package/qt5xmlpatterns: enable qml module
In reply to Thomas PetazzoniHello Thomas,
Quoted 8 lines · Thomas Petazzoni
Hello Peter,
Quoted 3 lines · On Fri, 13 Mar 2020 21:44:15 +0100 Peter Seiderer <[email protected]> wrote:
qt5declarative:
- remove unneded dependency on qt5mlpatterns
Quoted 8 lines
Quoted 6 lines
qt5xmlpatterns:
- add optional dependency on qt5declarative
- add target install step of the optional qml filesReported-by Nimai Mahajan <[email protected]>Signed-off-by Peter Seiderer <[email protected]>Will you send a similar patch for master ?
Yes, already prepared...., will send it out soon ;-)
Regards,
Peter
Quoted 4 lines
Thanks,
Thomas