Skip to contentSkip to conversation

package/lirc-tools: use single quote with SETUPTOOLS_ENV

PATCH New Ryan Barnett 2 participants 3 messages Dec 9, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV

With the change to pkg-python to use TARGET_CONFIGURE_OPTS in PKG_PYTHON_SETUPTOOLS_ENV in commit 1745fcde74, the LIRC_TOOLS_MAKE_ENV is incorrect as it sets the SETUPTOOLS_ENV using double quotes. This causes issues because the PKG_PYTHON_SETUPTOOLS_ENV contain double quotes as well. This causes a build error such as:

/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory

Fix this by using single quotes with PKG_PYTHON_SETUPTOOLS_ENV instead of double quotes.

Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8

---
 package/lirc-tools/lirc-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/lirc-tools/lirc-tools.mk +1 -1
index e468f2a25d..d66f4e9925 100644
@@ -47,7 +47,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_PYTHON3),y)
 LIRC_TOOLS_DEPENDENCIES += python3 host-python3-setuptools
-LIRC_TOOLS_MAKE_ENV += SETUPTOOLS_ENV="$(PKG_PYTHON_SETUPTOOLS_ENV)"
+LIRC_TOOLS_MAKE_ENV += SETUPTOOLS_ENV='$(PKG_PYTHON_SETUPTOOLS_ENV)'
 endif
 
 define LIRC_TOOLS_INSTALL_INIT_SYSV
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ryan" == Ryan Barnett <[email protected]> writes:

With the change to pkg-python to use TARGET_CONFIGURE_OPTS in PKG_PYTHON_SETUPTOOLS_ENV in commit 1745fcde74, the LIRC_TOOLS_MAKE_ENV is incorrect as it sets the SETUPTOOLS_ENV using double quotes. This causes issues because the PKG_PYTHON_SETUPTOOLS_ENV contain double quotes as well. This causes a build error such as:

/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory

Quoted 7 lines

Fix this by using single quotes with PKG_PYTHON_SETUPTOOLS_ENV instead of double quotes.

Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV

In reply to Ryan Barnett
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ryan" == Ryan Barnett <[email protected]> writes:

With the change to pkg-python to use TARGET_CONFIGURE_OPTS in PKG_PYTHON_SETUPTOOLS_ENV in commit 1745fcde74, the LIRC_TOOLS_MAKE_ENV is incorrect as it sets the SETUPTOOLS_ENV using double quotes. This causes issues because the PKG_PYTHON_SETUPTOOLS_ENV contain double quotes as well. This causes a build error such as:

/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory

Quoted 7 lines

Fix this by using single quotes with PKG_PYTHON_SETUPTOOLS_ENV instead of double quotes.

Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard