package/lirc-tools: use single quote with SETUPTOOLS_ENV
PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV
With the change to pkg-python to use TARGET_CONFIGURE_OPTS in PKG_PYTHON_SETUPTOOLS_ENV in commit 1745fcde74, the LIRC_TOOLS_MAKE_ENV is incorrect as it sets the SETUPTOOLS_ENV using double quotes. This causes issues because the PKG_PYTHON_SETUPTOOLS_ENV contain double quotes as well. This causes a build error such as:
/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory
Fix this by using single quotes with PKG_PYTHON_SETUPTOOLS_ENV instead of double quotes.
Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8
--- package/lirc-tools/lirc-tools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/lirc-tools/lirc-tools.mk +1 -1
@@ -47,7 +47,7 @@ endif ifeq ($(BR2_PACKAGE_PYTHON3),y) LIRC_TOOLS_DEPENDENCIES += python3 host-python3-setuptools -LIRC_TOOLS_MAKE_ENV += SETUPTOOLS_ENV="$(PKG_PYTHON_SETUPTOOLS_ENV)" +LIRC_TOOLS_MAKE_ENV += SETUPTOOLS_ENV='$(PKG_PYTHON_SETUPTOOLS_ENV)' endif define LIRC_TOOLS_INSTALL_INIT_SYSV
Signature · 1 line
2.17.1
PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ryan" == Ryan Barnett <[email protected]> writes:
With the change to pkg-python to use
TARGET_CONFIGURE_OPTSinPKG_PYTHON_SETUPTOOLS_ENVin commit1745fcde74, theLIRC_TOOLS_MAKE_ENVis incorrect as it sets theSETUPTOOLS_ENVusing double quotes. This causes issues because thePKG_PYTHON_SETUPTOOLS_ENVcontain double quotes as well. This causes a build error such as:
/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory
Quoted 7 lines
Fix this by using single quotes with
PKG_PYTHON_SETUPTOOLS_ENVinstead of double quotes.Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8Signed-off-by Ryan Barnett <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/lirc-tools: use single quote with SETUPTOOLS_ENV
In reply to Ryan BarnettQuoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ryan" == Ryan Barnett <[email protected]> writes:
With the change to pkg-python to use
TARGET_CONFIGURE_OPTSinPKG_PYTHON_SETUPTOOLS_ENVin commit1745fcde74, theLIRC_TOOLS_MAKE_ENVis incorrect as it sets theSETUPTOOLS_ENVusing double quotes. This causes issues because thePKG_PYTHON_SETUPTOOLS_ENVcontain double quotes as well. This causes a build error such as:
/bin/sh: -I/home/naourr/work/instance-0/output-1/host/include
CXXFLAGS_FOR_BUILD=-O2: No such file or directory
Quoted 7 lines
Fix this by using single quotes with
PKG_PYTHON_SETUPTOOLS_ENVinstead of double quotes.Fixes:
http://autobuild.buildroot.net/results/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8Signed-off-by Ryan Barnett <[email protected]>
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard