Skip to contentSkip to conversation

netsnmp: fix static build with openssl

PATCH New Fabrice Fontaine 4 participants 11 messages Sep 9, 2018 – Oct 11, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

- Add a patch to add crypto and zlib when statically linking
- Add AUTORECONF=YES
- Remove "hack" of setting -lz in mk as it is now done in patch

Fixes:
- http://autobuild.buildroot.org/results/1b30f9813a4605056963bfe4532374f725830fda

---
 .../0001-fix-static-build-with-openssl.patch  | 67 +++++++++++++++++++
 package/netsnmp/netsnmp.mk                    |  6 +-
 2 files changed, 69 insertions(+), 4 deletions(-)
 create mode 100644 package/netsnmp/0001-fix-static-build-with-openssl.patch
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +67 -0
new file mode 100644
index 0000000000..e73175e6af
@@ -0,0 +1,67 @@
+From 2675e97b76d20780a685ff4fa645d672a5513954 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Sun, 9 Sep 2018 10:00:13 +0200
+Subject: [PATCH] fix static build with openssl
+
+When checking for crypto functions such as EVP_sha224, it is needed to
+link with zlib otherwise static build fails:
+
+configure:24665: checking for EVP_sha224
+configure:24665: /home/naourr/work/instance-3/output/host/bin/xtensa-buildroot-linux-uclibc-gcc -o conftest -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -DNETSNMP_REMOVE_U64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -mlongcalls -mauto-litpools -Os -static -Ulinux -Dlinux=linux -I/home/naourr/work/instance-3/output/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/include/libnl3   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static conftest.c -lcrypto >&5
+/home/naourr/work/instance-3/output/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(c_zlib.o): In function `zlib_stateful_expand_block':
+c_zlib.c:(.text+0x30): undefined reference to `inflate'
+/home/naourr/work/instance-3/output/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(c_zlib.o): In function `zlib_stateful_compress_block':
+c_zlib.c:(.text+0x78): undefined reference to `deflate'
+
+Also when checking for ssl functions such as DTLSv1_method, it is needed
+to link also with crypto (and zlib) otherwise static build fails:
+
+configure:24717: checking for DTLSv1_method
+configure:24717: /home/naourr/work/instance-3/output/host/bin/xtensa-buildroot-linux-uclibc-gcc -o conftest -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -DNETSNMP_REMOVE_U64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -mlongcalls -mauto-litpools -Os -static -Ulinux -Dlinux=linux -I/home/naourr/work/instance-3/output/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/include/libnl3   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static conftest.c -lssl >&5
+/home/naourr/work/instance-3/output/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a(d1_srvr.o):(.text+0x4): undefined reference to `RAND_add'
+/home/naourr/work/instance-3/output/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a(d1_srvr.o):(.text+0x8): undefined reference to `ERR_clear_error'
+/home/naourr/work/instance-3/output/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a(d1_srvr.o): In function `dtls1_accept':
+d1_srvr.c:(.text+0x23c): undefined reference to `ERR_put_error'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/1b30f9813a4605056963bfe4532374f725830fda
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status:
+https://sourceforge.net/p/net-snmp/code/merge-requests/17]
+---
+ configure.d/config_os_libs2 | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/configure.d/config_os_libs2 b/configure.d/config_os_libs2
+index 74bed6bf7..84ebb77f5 100644
+--- a/configure.d/config_os_libs2
++++ b/configure.d/config_os_libs2
+@@ -309,13 +309,13 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+         LIBS="$netsnmp_save_LIBS"
+ 
+         if test x$CRYPTO = x; then
+-            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"])
++            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"], [], -lz)
+         fi
+ 
+         if test x$CRYPTO != x; then
+             AC_DEFINE(HAVE_LIBCRYPTO, 1,
+                 [Define to 1 if you have the OpenSSL library (-lcrypto or -leay32).])
+-            LIBCRYPTO="-l${CRYPTO}"
++            LIBCRYPTO="-l${CRYPTO} -lz"
+             netsnmp_save_LIBS="$LIBS"
+             LIBS="$LIBCRYPTO"
+             AC_CHECK_FUNCS([AES_cfb128_encrypt]dnl
+@@ -345,7 +345,7 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+             LIBS="$netsnmp_save_LIBS"
+         fi
+         netsnmp_save_LIBS="$LIBS"
+-        LIBS="-lssl"
++        LIBS="-lssl $LIBCRYPTO"
+         AC_CHECK_FUNCS([TLS_method TLSv1_method DTLS_method DTLSv1_method]dnl
+                        [SSL_library_init SSL_load_error_strings])
+         LIBS="$netsnmp_save_LIBS"
+-- 
+2.17.1
+
package/netsnmp/netsnmp.mk +2 -4
index 6c712ae075..acf6ecdc27 100644
@@ -36,6 +36,8 @@ NETSNMP_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) LIB_LDCONFIG_CMD=true inst
 NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true install
 NETSNMP_MAKE = $(MAKE1)
 NETSNMP_CONFIG_SCRIPTS = net-snmp-config
+# We're patching configure.d/config_os_libs2
+NETSNMP_AUTORECONF = YES
 
 ifeq ($(BR2_ENDIAN),"BIG")
 NETSNMP_CONF_OPTS += --with-endianness=big
@@ -57,10 +59,6 @@ NETSNMP_CONF_OPTS += \
 	--with-openssl=$(STAGING_DIR)/usr/include/openssl \
 	--with-security-modules="tsm,usm" \
 	--with-transports="DTLSUDP,TLSTCP"
-ifeq ($(BR2_STATIC_LIBS),y)
-# openssl uses zlib, so we need to explicitly link with it when static
-NETSNMP_CONF_ENV += LIBS=-lz
-endif
 else ifeq ($(BR2_PACKAGE_NETSNMP_OPENSSL_INTERNAL),y)
 NETSNMP_CONF_OPTS += --with-openssl=internal
 else
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

Hello Fabrice,

Thanks for working on this!

Quoted 19 lines · Fabrice Fontaine
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +19 -0
+diff --git a/configure.d/config_os_libs2 b/configure.d/config_os_libs2
+index 74bed6bf7..84ebb77f5 100644
+--- a/configure.d/config_os_libs2
++++ b/configure.d/config_os_libs2
+@@ -309,13 +309,13 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+         LIBS="$netsnmp_save_LIBS"
+ 
+         if test x$CRYPTO = x; then
+-            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"])
++            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"], [], -lz)
+         fi
+ 
+         if test x$CRYPTO != x; then
+             AC_DEFINE(HAVE_LIBCRYPTO, 1,
+                 [Define to 1 if you have the OpenSSL library (-lcrypto or -leay32).])
+-            LIBCRYPTO="-l${CRYPTO}"
++            LIBCRYPTO="-l${CRYPTO} -lz"
+             netsnmp_save_LIBS="$LIBS"
+             LIBS="$LIBCRYPTO"

package/netsnmp/0001-fix-static-build-with-openssl.patch line 64

Quoted 10 lines
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +10 -0
+             AC_CHECK_FUNCS([AES_cfb128_encrypt]dnl
+@@ -345,7 +345,7 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+             LIBS="$netsnmp_save_LIBS"
+         fi
+         netsnmp_save_LIBS="$LIBS"
+-        LIBS="-lssl"
++        LIBS="-lssl $LIBCRYPTO"
+         AC_CHECK_FUNCS([TLS_method TLSv1_method DTLS_method DTLSv1_method]dnl
+                        [SSL_library_init SSL_load_error_strings])
+         LIBS="$netsnmp_save_LIBS"

If you're patching the configure.ac stuff, what about doing the right thing, and use pkg-config ? :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

Dear Thomas,

Le dim. 9 sept. 2018 ? 14:16, Thomas Petazzoni <[email protected]> a ?crit :

Quoted 37 lines

Hello Fabrice,

Thanks for working on this!

package/netsnmp/0001-fix-static-build-with-openssl.patch

Quoted 5 lines · Fabrice Fontaine
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +5 -0
+diff --git a/configure.d/config_os_libs2 b/configure.d/config_os_libs2
+index 74bed6bf7..84ebb77f5 100644
+--- a/configure.d/config_os_libs2
++++ b/configure.d/config_os_libs2
+@@ -309,13 +309,13 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl"

!= "xinternal"; then

package/netsnmp/0001-fix-static-build-with-openssl.patch

Quoted 5 lines
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +5 -0
+         LIBS="$netsnmp_save_LIBS"
+
+         if test x$CRYPTO = x; then
+-            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"])
++            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"], [],

-lz)

package/netsnmp/0001-fix-static-build-with-openssl.patch

Quoted 5 lines
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +5 -0
+         fi
+
+         if test x$CRYPTO != x; then
+             AC_DEFINE(HAVE_LIBCRYPTO, 1,
+                 [Define to 1 if you have the OpenSSL library (-lcrypto

or -leay32).])

package/netsnmp/0001-fix-static-build-with-openssl.patch

Quoted 6 lines
+-            LIBCRYPTO="-l${CRYPTO}"
++            LIBCRYPTO="-l${CRYPTO} -lz"
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +4 -0
+             netsnmp_save_LIBS="$LIBS"
+             LIBS="$LIBCRYPTO"
+             AC_CHECK_FUNCS([AES_cfb128_encrypt]dnl
+@@ -345,7 +345,7 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl"

!= "xinternal"; then

package/netsnmp/0001-fix-static-build-with-openssl.patch

Quoted 6 lines
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +6 -0
+             LIBS="$netsnmp_save_LIBS"
+         fi
+         netsnmp_save_LIBS="$LIBS"
+-        LIBS="-lssl"
++        LIBS="-lssl $LIBCRYPTO"
+         AC_CHECK_FUNCS([TLS_method TLSv1_method DTLS_method
Quoted 7 lines

DTLSv1_method]dnl

package/netsnmp/0001-fix-static-build-with-openssl.patch line 64

Quoted 2 lines
package/netsnmp/0001-fix-static-build-with-openssl.patch new file +2 -0
+                        [SSL_library_init SSL_load_error_strings])
+         LIBS="$netsnmp_save_LIBS"

If you're patching the configure.ac stuff, what about doing the right thing, and use pkg-config ? :-)

Because the last time I tried to use pkg-config, the upstream project decided to refuse the merge request and use ac_search_libs instead:
https://gitlab.com/muttmua/mutt/merge_requests/25 :-(
I know that netsnmp is already using pkg-config, but only for libnl perhaps they would agree to use it also for ssl. I'll ask them and if they agree I'll update my patch.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180909/d3951079/attachment.html>

#3 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

Hello,

Quoted 3 lines · Fabrice Fontaine

Because the last time I tried to use pkg-config, the upstream project decided to refuse the merge request and use ac_search_libs instead:
https://gitlab.com/muttmua/mutt/merge_requests/25 :-(

I think in such cases, we should propose a patch that uses pkg-config if available, and if not falls back to AC_CHECK_LIB or other macros. If pkg-config is available, then static linking will work, if not, it will continue to fail like it used to.

Quoted 3 lines

I know that netsnmp is already using pkg-config, but only for libnl perhaps they would agree to use it also for ssl. I'll ask them and if they agree I'll update my patch.

Sure. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

Hello Fabrice, all,

Il 09/09/2018 15:09, Thomas Petazzoni ha scritto:

Quoted 13 lines

Hello,

Quoted 3 lines · Fabrice Fontaine

Because the last time I tried to use pkg-config, the upstream project decided to refuse the merge request and use ac_search_libs instead:
https://gitlab.com/muttmua/mutt/merge_requests/25 :-(

I think in such cases, we should propose a patch that uses pkg-config if available, and if not falls back to AC_CHECK_LIB or other macros. If pkg-config is available, then static linking will work, if not, it will continue to fail like it used to.

Quoted 8 lines
Quoted 3 lines

I know that netsnmp is already using pkg-config, but only for libnl perhaps they would agree to use it also for ssl. I'll ask them and if they agree I'll update my patch.

Sure. Thanks!

Thomas

During this day I've submit a patch to net-snmp upstream, then they've corrected it.
After they committed another patch.
And now I'm waiting for Merge Request to be accepted to fix this bug.

It was a mixture of problem:
- lack of -lssl in checking during configure(mainly DTLS support)
- lack of -lz in checking during configure for a bunch of functions

I'm going to take over and send BR patch I've done in-reply-to this.

Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#5 lore raw

PATCH 1/1 netsnmp: fix static build failure due to missing -lssl and -lz

During configure some checking needing -lssl and -lz don't have them appended to linker tail. Since we are building static this leads to configure failure because of mandatory functions lack produces:
"configure: error: The DTLS based transports require the libssl library from OpenSSL to be available and support DTLS"

- Add 1 patch to fix -lssl lack in configure and .ac modules:
upstreamed: https://sourceforge.net/p/net-snmp/code/ci/bd59be8e4e339870a1400f6866a7b73ca11f6460/
- Add 2 patches to fix -lz lack in configure and .ac modules:
1 upstreamed: https://sourceforge.net/p/net-snmp/code/ci/13da2bcde8e22dd0127a668374fdf79bed04d353/
1 in Merge Request: https://sourceforge.net/p/net-snmp/code/merge-requests/19/
- Add NETSNMP_AUTORECONF = YES

Fixes:
http://autobuild.buildroot.net/results/ece/ece7af756c910f65f618c1d04a5de70cc574b5f4/
http://autobuild.buildroot.net/results/2a7/2a7020de6a4095cf9991d09fbe8f6e364783f63b/
http://autobuild.buildroot.net/results/e27/e2787d15f72949cbb347e8a1d344f5f80b4d7697/
http://autobuild.buildroot.net/results/439/4393ce8ddee294f91bdc3e6fb53e08d56fe52184/
http://autobuild.buildroot.net/results/da6/da6bbbbb3a8d8193ec1389b9d976164181e88ae2/
http://autobuild.buildroot.net/results/cf5/cf57686e7620cc0ec361631a9ff906aa0123fdb4/
http://autobuild.buildroot.net/results/104/1043a958314529240627005d1bf21a76f4e6fcf5/
http://autobuild.buildroot.net/results/885/8855545bd09388e0da451a3cb53b312e13b29c2c/
http://autobuild.buildroot.net/results/a3d/a3dab9618a7ed88f94597418a5892c87adc23c66/
http://autobuild.buildroot.net/results/18e/18e70b88c9bcb3b8ede7308e54bba9417d1fd3fb/
http://autobuild.buildroot.net/results/ee3/ee34f65f26da20c0f2fdb9e86bcbddd389f59a29/
http://autobuild.buildroot.net/results/a1e/a1eb848079080ddf7cf2fc9e554cdd63ade0e9aa/
http://autobuild.buildroot.net/results/4dc/4dc8b53ff9f504c0a3dfc2d72c2609ad4d34559b/
http://autobuild.buildroot.net/results/9cc/9cc19e481de20ea0b4b5163e45c5aee525b81229/
http://autobuild.buildroot.net/results/f15/f15c22e0257d7498456049d8aae195ed6a265d2e/
http://autobuild.buildroot.net/results/1b3/1b30f9813a4605056963bfe4532374f725830fda/
http://autobuild.buildroot.net/results/d02/d02afc174ac4c9888f0a2cf725820cc1f05fc4bf/
http://autobuild.buildroot.net/results/57b/57b3f4663058d728987ef848e4b346656cae21d4/
http://autobuild.buildroot.net/results/ed4/ed4c27bdffccc4374ab7f951c30baba8171d30e1/

---
 ...figure-static-linking-Fix-SSL-checks.patch | 142 ++++++++++++++++++
 .../0002-configure-Fix-lcrypto-lz-test.patch  |  41 +++++
 ...-AC_CHECK_LIB-EVP_md5-.-without-lz-w.patch |  41 +++++
 package/netsnmp/netsnmp.mk                    |   1 +
 4 files changed, 225 insertions(+)
 create mode 100644 package/netsnmp/0001-configure-static-linking-Fix-SSL-checks.patch
 create mode 100644 package/netsnmp/0002-configure-Fix-lcrypto-lz-test.patch
 create mode 100644 package/netsnmp/0003-configure-Invert-AC_CHECK_LIB-EVP_md5-.-without-lz-w.patch
package/netsnmp/0001-configure-static-linking-Fix-SSL-checks.patch new file +142 -0
new file mode 100644
index 0000000000..8431d46868
@@ -0,0 +1,142 @@
+From bd59be8e4e339870a1400f6866a7b73ca11f6460 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <[email protected]>
+Date: Wed, 12 Sep 2018 20:16:39 +0200
+Subject: [PATCH 1/3] configure, static linking: Fix SSL checks
+
+During checking of DTLS_method, the stub program is linked only with -ssl
+libssl.a lacks some function from -lcrypto:
+RAND_*()
+ERR_*()
+BUF_MEM_*()
+etc.
+and -lz:
+- inflate()
+- deflate()
+
+Append -lcrypto and -lz to LIBS variable when checking DTLS_method.
+
+See also https://sourceforge.net/p/net-snmp/patches/1374/.
+
+Signed-off-by: Giulio Benetti <[email protected]>
+[bvanassche: Edited subject / rewrote this patch]
+---
+ configure                   | 52 ++++++++++++++++++++++++++++++++++---
+ configure.d/config_os_libs2 | 14 +++++++---
+ 2 files changed, 58 insertions(+), 8 deletions(-)
+
+diff --git a/configure b/configure
+index 6504a8e58..1116cecaa 100755
+--- a/configure
++++ b/configure
+@@ -23228,16 +23228,60 @@ fi
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_crypto_EVP_md5" >&5
+ $as_echo "$ac_cv_lib_crypto_EVP_md5" >&6; }
+ if test "x$ac_cv_lib_crypto_EVP_md5" = xyes; then :
+-  CRYPTO="crypto"
++  CRYPTO="crypto"; LIBCRYPTO="-lcrypto"
++else
++
++		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for EVP_md5 in -lcrypto" >&5
++$as_echo_n "checking for EVP_md5 in -lcrypto... " >&6; }
++if ${ac_cv_lib_crypto_EVP_md5+:} false; then :
++  $as_echo_n "(cached) " >&6
++else
++  ac_check_lib_save_LIBS=$LIBS
++LIBS="-lcrypto -lz $LIBS"
++cat confdefs.h - <<_ACEOF >conftest.$ac_ext
++/* end confdefs.h.  */
++
++/* Override any GCC internal prototype to avoid an error.
++   Use char because int might match the return type of a GCC
++   builtin and then its argument prototype would still apply.  */
++#ifdef __cplusplus
++extern "C"
++#endif
++char EVP_md5 ();
++int
++main ()
++{
++return EVP_md5 ();
++  ;
++  return 0;
++}
++_ACEOF
++if ac_fn_c_try_link "$LINENO"; then :
++  ac_cv_lib_crypto_EVP_md5=yes
++else
++  ac_cv_lib_crypto_EVP_md5=no
++fi
++rm -f core conftest.err conftest.$ac_objext \
++    conftest$ac_exeext conftest.$ac_ext
++LIBS=$ac_check_lib_save_LIBS
++fi
++{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_crypto_EVP_md5" >&5
++$as_echo "$ac_cv_lib_crypto_EVP_md5" >&6; }
++if test "x$ac_cv_lib_crypto_EVP_md5" = xyes; then :
++  CRYPTO="crypto"; LIBCRYPTO="-lcrypto -lz"
+ fi
+ 
+-        fi
++
++fi
++
++	else
++	    LIBCRYPTO="-l${CRYPTO}"
++	fi
+ 
+         if test x$CRYPTO != x; then
+ 
+ $as_echo "#define HAVE_LIBCRYPTO 1" >>confdefs.h
+ 
+-            LIBCRYPTO="-l${CRYPTO}"
+             netsnmp_save_LIBS="$LIBS"
+             LIBS="$LIBCRYPTO"
+             for ac_func in AES_cfb128_encrypt                           EVP_sha224        EVP_sha384                                   EVP_MD_CTX_create EVP_MD_CTX_destroy                           EVP_MD_CTX_new    EVP_MD_CTX_free                              DH_set0_pqg DH_get0_pqg DH_get0_key                           ASN1_STRING_get0_data X509_NAME_ENTRY_get_object                           X509_NAME_ENTRY_get_data X509_get_signature_nid
+@@ -23291,7 +23335,7 @@ _ACEOF
+             LIBS="$netsnmp_save_LIBS"
+         fi
+         netsnmp_save_LIBS="$LIBS"
+-        LIBS="-lssl"
++        LIBS="-lssl $LIBCRYPTO"
+         for ac_func in TLS_method TLSv1_method DTLS_method DTLSv1_method                       SSL_library_init SSL_load_error_strings
+ do :
+   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
+diff --git a/configure.d/config_os_libs2 b/configure.d/config_os_libs2
+index 4a1ad1551..75214cfff 100644
+--- a/configure.d/config_os_libs2
++++ b/configure.d/config_os_libs2
+@@ -306,13 +306,19 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+         LIBS="$netsnmp_save_LIBS"
+ 
+         if test x$CRYPTO = x; then
+-            AC_CHECK_LIB([crypto], [EVP_md5], [CRYPTO="crypto"])
+-        fi
++            AC_CHECK_LIB([crypto], [EVP_md5],
++			 [CRYPTO="crypto"; LIBCRYPTO="-lcrypto"], [
++		AC_CHECK_LIB([crypto], [EVP_md5],
++			     [CRYPTO="crypto"; LIBCRYPTO="-lcrypto -lz"], [],
++			     [-lz])
++	    ])
++	else
++	    LIBCRYPTO="-l${CRYPTO}"
++	fi
+ 
+         if test x$CRYPTO != x; then
+             AC_DEFINE(HAVE_LIBCRYPTO, 1,
+                 [Define to 1 if you have the OpenSSL library (-lcrypto or -leay32).])
+-            LIBCRYPTO="-l${CRYPTO}"
+             netsnmp_save_LIBS="$LIBS"
+             LIBS="$LIBCRYPTO"
+             AC_CHECK_FUNCS([AES_cfb128_encrypt]dnl
+@@ -342,7 +348,7 @@ if test "x$tryopenssl" != "xno" -a "x$tryopenssl" != "xinternal"; then
+             LIBS="$netsnmp_save_LIBS"
+         fi
+         netsnmp_save_LIBS="$LIBS"
+-        LIBS="-lssl"
++        LIBS="-lssl $LIBCRYPTO"
+         AC_CHECK_FUNCS([TLS_method TLSv1_method DTLS_method DTLSv1_method]dnl
+                        [SSL_library_init SSL_load_error_strings])
+         LIBS="$netsnmp_save_LIBS"
+-- 
+2.17.1
+
package/netsnmp/0002-configure-Fix-lcrypto-lz-test.patch new file +41 -0

41 lines not on this page · raw message

package/netsnmp/0003-configure-Invert-AC_CHECK_LIB-EVP_md5-.-without-lz-w.patch new file +41 -0

41 lines not on this page · raw message

package/netsnmp/netsnmp.mk +1 -0
index 6c712ae075..65a3f16a4d 100644
@@ -36,6 +36,7 @@ NETSNMP_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) LIB_LDCONFIG_CMD=true inst
 NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true install
 NETSNMP_MAKE = $(MAKE1)
 NETSNMP_CONFIG_SCRIPTS = net-snmp-config
+NETSNMP_AUTORECONF = YES
 
 ifeq ($(BR2_ENDIAN),"BIG")
 NETSNMP_CONF_OPTS += --with-endianness=big
Signature · 1 line
2.17.1
#6 lore raw

PATCH 1/1 netsnmp: fix static build failure due to missing -lssl and -lz

Quoted 36 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

During configure some checking needing -lssl and -lz don't have them appended to linker tail. Since we are building static this leads to configure failure because of mandatory functions lack produces:
"configure: error: The DTLS based transports require the libssl library from OpenSSL to be available and support DTLS"

- Add 1 patch to fix -lssl lack in configure and .ac modules:
upstreamed: https://sourceforge.net/p/net-snmp/code/ci/bd59be8e4e339870a1400f6866a7b73ca11f6460/
- Add 2 patches to fix -lz lack in configure and .ac modules:
1 upstreamed: https://sourceforge.net/p/net-snmp/code/ci/13da2bcde8e22dd0127a668374fdf79bed04d353/
1 in Merge Request: https://sourceforge.net/p/net-snmp/code/merge-requests/19/
- Add NETSNMP_AUTORECONF = YES

Fixes:
http://autobuild.buildroot.net/results/ece/ece7af756c910f65f618c1d04a5de70cc574b5f4/
http://autobuild.buildroot.net/results/2a7/2a7020de6a4095cf9991d09fbe8f6e364783f63b/
http://autobuild.buildroot.net/results/e27/e2787d15f72949cbb347e8a1d344f5f80b4d7697/
http://autobuild.buildroot.net/results/439/4393ce8ddee294f91bdc3e6fb53e08d56fe52184/
http://autobuild.buildroot.net/results/da6/da6bbbbb3a8d8193ec1389b9d976164181e88ae2/
http://autobuild.buildroot.net/results/cf5/cf57686e7620cc0ec361631a9ff906aa0123fdb4/
http://autobuild.buildroot.net/results/104/1043a958314529240627005d1bf21a76f4e6fcf5/
http://autobuild.buildroot.net/results/885/8855545bd09388e0da451a3cb53b312e13b29c2c/
http://autobuild.buildroot.net/results/a3d/a3dab9618a7ed88f94597418a5892c87adc23c66/
http://autobuild.buildroot.net/results/18e/18e70b88c9bcb3b8ede7308e54bba9417d1fd3fb/
http://autobuild.buildroot.net/results/ee3/ee34f65f26da20c0f2fdb9e86bcbddd389f59a29/
http://autobuild.buildroot.net/results/a1e/a1eb848079080ddf7cf2fc9e554cdd63ade0e9aa/
http://autobuild.buildroot.net/results/4dc/4dc8b53ff9f504c0a3dfc2d72c2609ad4d34559b/
http://autobuild.buildroot.net/results/9cc/9cc19e481de20ea0b4b5163e45c5aee525b81229/
http://autobuild.buildroot.net/results/f15/f15c22e0257d7498456049d8aae195ed6a265d2e/
http://autobuild.buildroot.net/results/1b3/1b30f9813a4605056963bfe4532374f725830fda/
http://autobuild.buildroot.net/results/d02/d02afc174ac4c9888f0a2cf725820cc1f05fc4bf/
http://autobuild.buildroot.net/results/57b/57b3f4663058d728987ef848e4b346656cae21d4/
http://autobuild.buildroot.net/results/ed4/ed4c27bdffccc4374ab7f951c30baba8171d30e1/

Quoted 3 lines
---
 ...figure-static-linking-Fix-SSL-checks.patch | 142 ++++++++++++++++++

Having the configure part AND doing a autoreconf is a bit stupid, but I guess you just wanted to include the upstream commit as is.

Committed, thanks!

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 netsnmp: fix static build failure due to missing -lssl and -lz

Hi Peter,

Il 11/10/2018 22:46, Peter Korsgaard ha scritto:

Quoted 36 lines
Quoted 35 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

During configure some checking needing -lssl and -lz don't have them appended to linker tail. Since we are building static this leads to configure failure because of mandatory functions lack produces:
"configure: error: The DTLS based transports require the libssl library from OpenSSL to be available and support DTLS"

- Add 1 patch to fix -lssl lack in configure and .ac modules:
upstreamed: https://sourceforge.net/p/net-snmp/code/ci/bd59be8e4e339870a1400f6866a7b73ca11f6460/
- Add 2 patches to fix -lz lack in configure and .ac modules:
1 upstreamed: https://sourceforge.net/p/net-snmp/code/ci/13da2bcde8e22dd0127a668374fdf79bed04d353/
1 in Merge Request: https://sourceforge.net/p/net-snmp/code/merge-requests/19/
- Add NETSNMP_AUTORECONF = YES

Fixes:
http://autobuild.buildroot.net/results/ece/ece7af756c910f65f618c1d04a5de70cc574b5f4/
http://autobuild.buildroot.net/results/2a7/2a7020de6a4095cf9991d09fbe8f6e364783f63b/
http://autobuild.buildroot.net/results/e27/e2787d15f72949cbb347e8a1d344f5f80b4d7697/
http://autobuild.buildroot.net/results/439/4393ce8ddee294f91bdc3e6fb53e08d56fe52184/
http://autobuild.buildroot.net/results/da6/da6bbbbb3a8d8193ec1389b9d976164181e88ae2/
http://autobuild.buildroot.net/results/cf5/cf57686e7620cc0ec361631a9ff906aa0123fdb4/
http://autobuild.buildroot.net/results/104/1043a958314529240627005d1bf21a76f4e6fcf5/
http://autobuild.buildroot.net/results/885/8855545bd09388e0da451a3cb53b312e13b29c2c/
http://autobuild.buildroot.net/results/a3d/a3dab9618a7ed88f94597418a5892c87adc23c66/
http://autobuild.buildroot.net/results/18e/18e70b88c9bcb3b8ede7308e54bba9417d1fd3fb/
http://autobuild.buildroot.net/results/ee3/ee34f65f26da20c0f2fdb9e86bcbddd389f59a29/
http://autobuild.buildroot.net/results/a1e/a1eb848079080ddf7cf2fc9e554cdd63ade0e9aa/
http://autobuild.buildroot.net/results/4dc/4dc8b53ff9f504c0a3dfc2d72c2609ad4d34559b/
http://autobuild.buildroot.net/results/9cc/9cc19e481de20ea0b4b5163e45c5aee525b81229/
http://autobuild.buildroot.net/results/f15/f15c22e0257d7498456049d8aae195ed6a265d2e/
http://autobuild.buildroot.net/results/1b3/1b30f9813a4605056963bfe4532374f725830fda/
http://autobuild.buildroot.net/results/d02/d02afc174ac4c9888f0a2cf725820cc1f05fc4bf/
http://autobuild.buildroot.net/results/57b/57b3f4663058d728987ef848e4b346656cae21d4/
http://autobuild.buildroot.net/results/ed4/ed4c27bdffccc4374ab7f951c30baba8171d30e1/

Quoted 6 lines
Quoted 3 lines
---
 ...figure-static-linking-Fix-SSL-checks.patch | 142 ++++++++++++++++++

Having the configure part AND doing a autoreconf is a bit stupid, but I guess you just wanted to include the upstream commit as is.

As I've tested, need to autoreconf to pick up new autotools rules applied with patches.
So if call only ./configure after appliyng patches it wouldn't work as configure file is not re-created by autotools.

Maybe I have to suggest to netsnmp upstream as Issue to update "configure" file?

Quoted 1 line

Committed, thanks!

Thank you!
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#8 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

In reply to Giulio Benetti

Dear Giulio,

Le lun. 17 sept. 2018 ? 22:37, Giulio Benetti <
[email protected]> a ?crit :

Quoted 31 lines

Hello Fabrice, all,

Il 09/09/2018 15:09, Thomas Petazzoni ha scritto:

Quoted 4 lines

Hello,

On Sun, 9 Sep 2018 14:43:41 +0200, Fabrice Fontaine wrote:

Quoted 10 lines
Quoted 3 lines

Because the last time I tried to use pkg-config, the upstream project decided to refuse the merge request and use ac_search_libs instead:
https://gitlab.com/muttmua/mutt/merge_requests/25 :-(

I think in such cases, we should propose a patch that uses pkg-config if available, and if not falls back to AC_CHECK_LIB or other macros. If pkg-config is available, then static linking will work, if not, it will continue to fail like it used to.

Quoted 1 line

I know that netsnmp is already using pkg-config, but only for libnl

perhaps

Quoted 7 lines
Quoted 2 lines

they would agree to use it also for ssl. I'll ask them and if they agree I'll update my patch.

Sure. Thanks!

Thomas

During this day I've submit a patch to net-snmp upstream, then they've corrected it.
After they committed another patch.
And now I'm waiting for Merge Request to be accepted to fix this bug.

Quoted 6 lines

It was a mixture of problem:
- lack of -lssl in checking during configure(mainly DTLS support)
- lack of -lz in checking during configure for a bunch of functions

I'm going to take over and send BR patch I've done in-reply-to this.

OK, thanks for taking over :-)

Quoted 6 lines

Best regards
--
Giulio Benetti
CTO

Quoted 8 lines

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180917/43147111/attachment.html>

#9 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

In reply to Giulio Benetti

Hello,

Quoted 10 lines · Giulio Benetti

During this day I've submit a patch to net-snmp upstream, then they've corrected it.
After they committed another patch.
And now I'm waiting for Merge Request to be accepted to fix this bug.

It was a mixture of problem:
- lack of -lssl in checking during configure(mainly DTLS support)
- lack of -lz in checking during configure for a bunch of functions

I'm going to take over and send BR patch I've done in-reply-to this.

And they still don't want to use pkg-config instead of this mess of checking transitive dependencies manually ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#10 lore raw

PATCH 1/1 netsnmp: fix static build with openssl

Hello,

Il 17/09/2018 23:22, Thomas Petazzoni ha scritto:

Quoted 9 lines

Hello,

Quoted 5 lines · Giulio Benetti

During this day I've submit a patch to net-snmp upstream, then they've corrected it.
After they committed another patch.
And now I'm waiting for Merge Request to be accepted to fix this bug.

Quoted 8 lines
Quoted 5 lines

It was a mixture of problem:
- lack of -lssl in checking during configure(mainly DTLS support)
- lack of -lz in checking during configure for a bunch of functions

I'm going to take over and send BR patch I've done in-reply-to this.

And they still don't want to use pkg-config instead of this mess of checking transitive dependencies manually ?

Judging from their master branch and checking the other branches it seems not.

If they use pkg-config for libnl as Fabrice mentioned maybe they would consider the idea.
Maybe they only need some help from someone else(sure more experienced than me).

I could open a "Feature Request" on Source Forge after this bug is solved also for them and upstream my last patch. I've seen they are responsive today.
What do you think?

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642