ARM: dts: clearfog: fix sdhci supply property name
PATCH 1/1 ARM: dts: clearfog: fix sdhci supply property name
The vmmc phandle, like all power supply property names, must have the '-supply' suffix.
--- arch/arm/boot/dts/armada-388-clearfog.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/armada-388-clearfog.dtsi +1 -1
@@ -48,7 +48,7 @@ &clearfog_sdhci_cd_pins>; pinctrl-names = "default"; status = "okay"; - vmmc = <®_3p3v>; + vmmc-supply = <®_3p3v>; wp-inverted; };
Signature · 1 line
2.18.0
PATCH 1/1 ARM: dts: clearfog: fix sdhci supply property name
Hi Baruch,
Quoted 3 lines · Baruch Siach
The vmmc phandle, like all power supply property names, must have the '-supply' suffix.
I also noticed it a few months ago and then I forgot. However, does it add any value to have this regulator?
Now that I found my note, I considered to just remove this line as well as the regulator node.
What do you think ?
Gregory
Quoted 26 lines
Signed-off-by Baruch Siach <[email protected]>--- arch/arm/boot/dts/armada-388-clearfog.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/armada-388-clearfog.dtsi +1
-1@@ -48,7 +48,7 @@ &clearfog_sdhci_cd_pins>; pinctrl-names = "default"; status = "okay"; - vmmc = <®_3p3v>; + vmmc-supply = <®_3p3v>; wp-inverted; };Signature · 7 lines
2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
PATCH 1/1 ARM: dts: clearfog: fix sdhci supply property name
Quoted 8 lines · Gregory CLEMENT
Hi Baruch,
Quoted 3 lines · Baruch Siach
The vmmc phandle, like all power supply property names, must have the '-supply' suffix.
Quoted 5 lines
I also noticed it a few months ago and then I forgot. However, does it add any value to have this regulator?
Now that I found my note, I considered to just remove this line as well as the regulator node.
The "value" is it's a fuller description of the hardware, and DT is a hardware description, not a description of what the software requires. So, imho, it's completely correct to specify the vmmc. As maintainer for the Clearfog DT, I'd like it to stay (and be fixed). Thanks.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up
PATCH 1/1 ARM: dts: clearfog: fix sdhci supply property name
Hi Russell King,
Quoted 12 lines · Russell King - ARM Linux
Quoted 11 lines · Gregory CLEMENT
Hi Baruch,
Quoted 3 lines · Baruch Siach
The vmmc phandle, like all power supply property names, must have the '-supply' suffix.
I also noticed it a few months ago and then I forgot. However, does it add any value to have this regulator?
Quoted 7 lines
Quoted 2 lines
Now that I found my note, I considered to just remove this line as well as the regulator node.
The "value" is it's a fuller description of the hardware, and DT is a hardware description, not a description of what the software requires. So, imho, it's completely correct to specify the vmmc. As maintainer for the Clearfog DT, I'd like it to stay (and be fixed). Thanks.
OK so: applied on mvebu/dt
Thanks,
Gregory
Quoted 5 lines
Signature · 4 lines
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com