Skip to contentSkip to conversation

ath6kl: mark expected switch fall-throughs

PATCH Superseded Gustavo A. R. Silva 3 participants 6 messages May 24, 2018 – May 25, 2018

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath6kl: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath6kl/cfg80211.c +3 -3
index 2ba8cf3..29e32cd 100644
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
 	wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
 	switch (ar->hw.cap) {
 	case WMI_11AN_CAP:
-		ht = true;
+		ht = true; /* fall through */
 	case WMI_11A_CAP:
 		band_5gig = true;
 		break;
 	case WMI_11GN_CAP:
-		ht = true;
+		ht = true; /* fall through */
 	case WMI_11G_CAP:
 		band_2gig = true;
 		break;
 	case WMI_11AGN_CAP:
-		ht = true;
+		ht = true; /* fall through */
 	case WMI_11AG_CAP:
 		band_2gig = true;
 		band_5gig = true;
Signature · 1 line
2.7.4
#1 lore raw

Hello!

Quoted 23 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

---
  drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath6kl/cfg80211.c +1 -2
index 2ba8cf3..29e32cd 100644
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
  	wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
  	switch (ar->hw.cap) {
  	case WMI_11AN_CAP:
-		ht = true;
+		ht = true; /* fall through */
  	case WMI_11A_CAP:
  		band_5gig = true;
  		break;
  	case WMI_11GN_CAP:
-		ht = true;

drivers/net/wireless/ath/ath6kl/cfg80211.c int ath6kl_cfg80211_init(struct ath6kl *ar) · line 3914

Quoted 10 lines
drivers/net/wireless/ath/ath6kl/cfg80211.c +2 -1
+		ht = true; /* fall through */
  	case WMI_11G_CAP:
  		band_2gig = true;
  		break;
  	case WMI_11AGN_CAP:
-		ht = true;
+		ht = true; /* fall through */
  	case WMI_11AG_CAP:
  		band_2gig = true;
  		band_5gig = true;

Hm, typically such comments are done on a line of their own, have never
seen this style...

MBR, Sergei

#2 lore raw
Quoted 30 lines · Sergei Shtylyov
Quoted 28 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

---
  drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath6kl/cfg80211.c +2 -2
index 2ba8cf3..29e32cd 100644
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
  	wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
  	switch (ar->hw.cap) {
  	case WMI_11AN_CAP:
-		ht = true;
+		ht = true; /* fall through */
  	case WMI_11A_CAP:
  		band_5gig = true;
  		break;
  	case WMI_11GN_CAP:
-		ht = true;
+		ht = true; /* fall through */
  	case WMI_11G_CAP:
  		band_2gig = true;
  		break;
  	case WMI_11AGN_CAP:
Quoted 8 lines

drivers/net/wireless/ath/ath6kl/cfg80211.c int ath6kl_cfg80211_init(struct ath6kl *ar) · line 3914

Quoted 5 lines
drivers/net/wireless/ath/ath6kl/cfg80211.c +1 -1
-		ht = true;
+		ht = true; /* fall through */
  	case WMI_11AG_CAP:
  		band_2gig = true;
  		band_5gig = true;

Hm, typically such comments are done on a line of their own, have
never seen this style...

Yeah, I was wondering the same. Was there a particular reason for this?

Signature · 1 line
Kalle Valo
#3 lore raw
Quoted 41 lines · Kalle Valo
Quoted 30 lines · Sergei Shtylyov
Quoted 28 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

---
   drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath6kl/cfg80211.c +2 -2
index 2ba8cf3..29e32cd 100644
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
   	wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
   	switch (ar->hw.cap) {
   	case WMI_11AN_CAP:
-		ht = true;
+		ht = true; /* fall through */
   	case WMI_11A_CAP:
   		band_5gig = true;
   		break;
   	case WMI_11GN_CAP:
-		ht = true;
+		ht = true; /* fall through */
   	case WMI_11G_CAP:
   		band_2gig = true;
   		break;
   	case WMI_11AGN_CAP:
Quoted 8 lines

drivers/net/wireless/ath/ath6kl/cfg80211.c int ath6kl_cfg80211_init(struct ath6kl *ar) · line 3914

Quoted 5 lines
drivers/net/wireless/ath/ath6kl/cfg80211.c +1 -1
-		ht = true;
+		ht = true; /* fall through */
   	case WMI_11AG_CAP:
   		band_2gig = true;
   		band_5gig = true;

Hm, typically such comments are done on a line of their own, have
never seen this style...

Quoted 2 lines

Yeah, I was wondering the same. Was there a particular reason for this?

Sometimes people use this style for a one-line code block.

I can change it to the traditional style. No problem.

Thanks
--
Gustavo

#4 lore raw
Quoted 42 lines · Gustavo A. R. Silva
Quoted 41 lines · Kalle Valo
Quoted 38 lines · Sergei Shtylyov
Quoted 23 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

---
   drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath6kl/cfg80211.c +1 -2
index 2ba8cf3..29e32cd 100644
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
   	wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
   	switch (ar->hw.cap) {
   	case WMI_11AN_CAP:
-		ht = true;
+		ht = true; /* fall through */
   	case WMI_11A_CAP:
   		band_5gig = true;
   		break;
   	case WMI_11GN_CAP:
-		ht = true;

drivers/net/wireless/ath/ath6kl/cfg80211.c int ath6kl_cfg80211_init(struct ath6kl *ar) · line 3914

Quoted 10 lines
drivers/net/wireless/ath/ath6kl/cfg80211.c +2 -1
+		ht = true; /* fall through */
   	case WMI_11G_CAP:
   		band_2gig = true;
   		break;
   	case WMI_11AGN_CAP:
-		ht = true;
+		ht = true; /* fall through */
   	case WMI_11AG_CAP:
   		band_2gig = true;
   		band_5gig = true;

Hm, typically such comments are done on a line of their own, have
never seen this style...

Quoted 6 lines
Quoted 2 lines

Yeah, I was wondering the same. Was there a particular reason for this?

Sometimes people use this style for a one-line code block.

I can change it to the traditional style. No problem.

I would prefer that. So if you can send v2 that would be great.

Signature · 1 line
Kalle Valo
#5 lore raw
Quoted 9 lines · Kalle Valo
Quoted 6 lines
Quoted 2 lines

Yeah, I was wondering the same. Was there a particular reason for this?

Sometimes people use this style for a one-line code block.

I can change it to the traditional style. No problem.

I would prefer that. So if you can send v2 that would be great.

Yep. No problem. I'll send it shortly.

Thanks
--
Gustavo