USB regression in next-20171108 with hub spamming

DISCUSSION Tony Lindgren 3 participants 7 messages Nov 8, 2017 – Nov 9, 2017 6 messages not in the archive USB

Share & tools

Tony Lindgren

author

2017-11-08 23:05 UTC #0 lore raw

Hi Felipe & Greg,

Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").

Any ideas? See the log below.

Regards,

Tony

8< ------------------------------
ohci-platform 4a064800.ohci: Generic Platform OHCI controller ohci-platform 4a064800.ohci: new USB bus registered, assigned bus number 1 ohci-platform 4a064800.ohci: irq 146, io mem 0x4a064800
usb usb1: New USB device found, idVendor=1d6b, idProduct=0001 usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 usb usb1: Product: Generic Platform OHCI controller
usb usb1: Manufacturer: Linux 4.14.0-rc8-next-20171108+ ohci_hcd usb usb1: SerialNumber: 4a064800.ohci
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 3 ports detected
hub 1-0:1.0: config failed, can't get hub status (err 2)
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
hub 1-0:1.0: activate --> -22
...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg Kroah-Hartman

2017-11-09 08:00 UTC #2 lore raw

Quoted 7 lines · Tony Lindgren

Hi Felipe & Greg,
Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").
Any ideas? See the log below.

Any chance you can run 'git bisect'?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Felipe Balbi

2017-11-09 10:25 UTC #4 lore raw

Hi,

Quoted 10 lines · Greg Kroah-Hartman

Quoted 7 lines · Tony Lindgren
Hi Felipe & Greg,
Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").
Any ideas? See the log below.
Any chance you can run 'git bisect'?

I wonder if it was caused by the usb_get_std_status() changes. We didn't catch this in our testing, though. I left the patches in intel's validation for a few days before sending out.

Let me compile that very tag and try it with one of our machines.

Tony, a bisection would be useful, indeed.

Signature · 1 line

balbi

A message that is not in the archive (sent off-list or not yet received): 871sl7sq9i.fsf-VuQAYsv1563Yd54FQh9/[email protected]

Felipe Balbi

2017-11-09 10:44 UTC #6 lore raw

Quoted 14 lines · Felipe Balbi

Hi,
Quoted 10 lines · Greg Kroah-Hartman
Quoted 7 lines · Tony Lindgren
Hi Felipe & Greg,
Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").
Any ideas? See the log below.
Any chance you can run 'git bisect'?

Quoted 7 lines

I wonder if it was caused by the usb_get_std_status() changes. We didn't catch this in our testing, though. I left the patches in intel's validation for a few days before sending out.
Let me compile that very tag and try it with one of our machines.
Tony, a bisection would be useful, indeed.

reproduced. Digging to figure out what's going on.

Signature · 1 line

balbi

A message that is not in the archive (sent off-list or not yet received): 87wp2zrasg.fsf-VuQAYsv1563Yd54FQh9/[email protected]

Felipe Balbi

2017-11-09 10:49 UTC #8 lore raw

Quoted 20 lines · Felipe Balbi

Quoted 18 lines · Felipe Balbi
Hi,
Quoted 10 lines · Greg Kroah-Hartman
Quoted 7 lines · Tony Lindgren
Hi Felipe & Greg,
Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").
Any ideas? See the log below.
Any chance you can run 'git bisect'?
I wonder if it was caused by the usb_get_std_status() changes. We didn't catch this in our testing, though. I left the patches in intel's validation for a few days before sending out.

Quoted 5 lines

Quoted 3 lines
Let me compile that very tag and try it with one of our machines.
Tony, a bisection would be useful, indeed.
reproduced. Digging to figure out what's going on.

Okay, found it. Testing a patch.

Signature · 1 line

balbi

A message that is not in the archive (sent off-list or not yet received): 87shdnrak7.fsf-VuQAYsv1563Yd54FQh9/[email protected]

Felipe Balbi

2017-11-09 10:59 UTC #10 lore raw

Hi,

Quoted 22 lines · Felipe Balbi

Quoted 20 lines · Felipe Balbi
Quoted 18 lines · Felipe Balbi
Hi,
Quoted 10 lines · Greg Kroah-Hartman
Quoted 7 lines · Tony Lindgren
Hi Felipe & Greg,
Looks like in next-20171108 USB hub is spamming console about once a second after commit 7dfd74fd128 ("Merge remote-tracking branch 'usb/usb-next'").
Any ideas? See the log below.
Any chance you can run 'git bisect'?
I wonder if it was caused by the usb_get_std_status() changes. We didn't catch this in our testing, though. I left the patches in intel's validation for a few days before sending out.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Let me compile that very tag and try it with one of our machines.
Tony, a bisection would be useful, indeed.
reproduced. Digging to figure out what's going on.
Okay, found it. Testing a patch.

Here's the patch, I'll send it formally shortly.

drivers/usb/core/message.c +2 -0

index 0cdc463c9509..c15fbf76f8f7 100644
@@ -975,6 +975,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
 		}
 
 		*(u32 *) data = le32_to_cpu(*(__le32 *) status);
+		ret = 0;
 		break;
 	case 2:
 		if (type != USB_STATUS_TYPE_STANDARD) {

@@ -983,6 +984,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
 		}
 
 		*(u16 *) data = le16_to_cpu(*(__le16 *) status);
+		ret = 0;
 		break;
 	default:
 		ret = -EIO;

Signature · 5 lines

2.14.2.642.g20fed7cad4


-- 
balbi

A message that is not in the archive (sent off-list or not yet received): 87po8rra42.fsf-VuQAYsv1563Yd54FQh9/[email protected]

Tony Lindgren

author

2017-11-09 14:39 UTC #12 lore raw

Quoted 4 lines · Felipe Balbi

Quoted 1 line · Felipe Balbi
Okay, found it. Testing a patch.
Here's the patch, I'll send it formally shortly.

Thanks yeah that fixes the issue for me, replied to your formal patch with a tested by.

Regards,

Tony

Quoted 26 lines

drivers/usb/core/message.c +2 -0

index 0cdc463c9509..c15fbf76f8f7 100644
@@ -975,6 +975,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
 		}
 
 		*(u32 *) data = le32_to_cpu(*(__le32 *) status);
+		ret = 0;
 		break;
 	case 2:
 		if (type != USB_STATUS_TYPE_STANDARD) {

@@ -983,6 +984,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target,
 		}
 
 		*(u16 *) data = le16_to_cpu(*(__le16 *) status);
+		ret = 0;
 		break;
 	default:
 		ret = -EIO;

Signature · 5 lines

2.14.2.642.g20fed7cad4


-- 
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html