Skip to contentSkip to conversation

odroid-c2: enable MMC as boot target

PATCH New Heinrich Schuchardt 4 participants 8 messages Apr 14, 2017 – May 1, 2017 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Heinrich Schuchardt

author
#0 lore raw

PATCH v2 1/1 odroid-c2: enable MMC as boot target

To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2:
Enhance commit message to clearly indicate how the
boot targets are sequenced.
v1:
This is a resubmission of
https://lists.denx.de/pipermail/u-boot/2017-April/287315.html
where this patch was part of patch series which was no longer applicable.

---
 include/configs/meson-gxbb-common.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/meson-gxbb-common.h +2 -0
index cc2b5b6..388f239 100644
@@ -39,6 +39,8 @@
 #include <config_distro_defaults.h>
 
 #define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
+	func(MMC, mmc, 1) \
 	func(DHCP, dhcp, na)
 
 #include <config_distro_bootcmd.h>
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/1 odroid-c2: enable MMC as boot target

Am 14.04.2017 um 16:33 schrieb Heinrich Schuchardt:

Quoted 6 lines

To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Quoted 6 lines
Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2:
Enhance commit message to clearly indicate how the boot targets are sequenced.

Reviewed-by Andreas Färber <[email protected]>

Thanks,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
#2 lore raw

PATCH v2 1/1 odroid-c2: enable MMC as boot target

Am 14.04.2017 um 16:35 schrieb Andreas Färber:

Quoted 7 lines

Am 14.04.2017 um 16:33 schrieb Heinrich Schuchardt:

Quoted 6 lines

To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Quoted 8 lines
Quoted 6 lines
Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2:
Enhance commit message to clearly indicate how the boot targets are sequenced.

Reviewed-by Andreas Färber <[email protected]>

As pointed out by Heiner, while this works for the Odroid-C2, hardcoding these two devices for GXBB blocks booting from eMMC where that shows up as mmc2. So either this should be defined on the odroid-c2 level, so that we can have board-specific device lists, or include mmc2 here as well. There might also be devices with only one.

Regards,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
author
#3 lore raw

PATCH v3 1/1 meson: gxbb: enable MMC as boot target

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v3:
Adjust patch title to reflect that this patch applies to all gxbb boards.
Vega S95 Telos has 3 MMC devices.
So add MMC 2.
v2:
odroid-c2: enable MMC as boot target
https://lists.denx.de/pipermail/u-boot/2017-April/287358.html
Enhance commit message to clearly indicate how the
boot targets are sequenced.
v1:
This is a resubmission of
https://lists.denx.de/pipermail/u-boot/2017-April/287315.html
where this patch was part of patch series which was no longer applicable.

---
 include/configs/meson-gxbb-common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/meson-gxbb-common.h +3 -0
index cc2b5b61d4..997ce2df19 100644
@@ -39,6 +39,9 @@
 #include <config_distro_defaults.h>
 
 #define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
+	func(MMC, mmc, 1) \
+	func(MMC, mmc, 2) \
 	func(DHCP, dhcp, na)
 
 #include <config_distro_bootcmd.h>
Signature · 1 line
2.11.0
#4 lore raw

PATCH v3 1/1 meson: gxbb: enable MMC as boot target

Quoted 8 lines · xypron.glpk at gmx.de

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

Tested booting from microSD on an odroid-c2.

Tested-by Vagrant Cascadian <[email protected]>

live well,
vagrant

Quoted 24 lines

---
v3:
Adjust patch title to reflect that this patch applies to all gxbb boards.
Vega S95 Telos has 3 MMC devices.
So add MMC 2.
v2:
odroid-c2: enable MMC as boot target
https://lists.denx.de/pipermail/u-boot/2017-April/287358.html
Enhance commit message to clearly indicate how the
boot targets are sequenced.
v1:
This is a resubmission of
https://lists.denx.de/pipermail/u-boot/2017-April/287315.html
where this patch was part of patch series which was no longer applicable.

---
 include/configs/meson-gxbb-common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/meson-gxbb-common.h +0 -0
index cc2b5b61d4..997ce2df19 100644

include/configs/meson-gxbb-common.h line 47

Quoted 9 lines
include/configs/meson-gxbb-common.h +3 -0
@@ -39,6 +39,9 @@
 #include <config_distro_defaults.h>
 
 #define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
+	func(MMC, mmc, 1) \
+	func(MMC, mmc, 2) \
 	func(DHCP, dhcp, na)
 
 #include <config_distro_bootcmd.h>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170417/47ba207e/attachment.sig>

#5 lore raw

PATCH v3 1/1 meson: gxbb: enable MMC as boot target

In reply to Heinrich Schuchardt

Am 15.04.2017 um 21:30 schrieb Heinrich Schuchardt:

Quoted 8 lines

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Andreas Färber <[email protected]>

The issues with SDIO mmc 0 are being investigated at a different level, so I think it is okay to merge this generalized version for -rc3.

Once done, Vagrant's PXE addition can be rebased.

Thanks,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
#6 lore raw

PATCH v3 1/1 meson: gxbb: enable MMC as boot target

Am 19.04.2017 um 07:12 schrieb Andreas Färber:

Quoted 7 lines

Am 15.04.2017 um 21:30 schrieb Heinrich Schuchardt:

Quoted 6 lines

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Quoted 7 lines
Quoted 2 lines
Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Andreas Färber <[email protected]>

The issues with SDIO mmc 0 are being investigated at a different level, so I think it is okay to merge this generalized version for -rc3.

Ping?

In case it helps, I can by now also add a second

Tested-by Andreas Färber <[email protected]>

Regards,
Andreas

Quoted 4 lines

Once done, Vagrant's PXE addition can be rebased.

Thanks,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
#7 lore raw

PATCH v3 1/1 meson: gxbb: enable MMC as boot target

In reply to Heinrich Schuchardt
Quoted 11 lines · xypron.glpk at gmx.de

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES.

Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Tested-by Vagrant Cascadian <[email protected]>
Reviewed-by Andreas Färber <[email protected]>
Tested-by Andreas Färber <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170501/ffae0965/attachment.sig>