Skip to contentSkip to conversation

imlib2: uses dlopen(), not available in static cases

PATCH New Thomas Petazzoni 3 participants 3 messages Apr 29, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imlib2: uses dlopen(), not available in static cases

According to the imlib2 people, if you don't support dlopen(), you have a "crap box":

image.h:16:4: warning: #warning "your crap box doesn't define RTLD_LOCAL !?"

So, let's disable imlib2 when doing static linking.

Fixes:

http://autobuild.buildroot.net/results/b5e/b5ee859409cd626b769e8a159026e60ec6f29180/

---
 package/directfb/Config.in | 4 ++++
 package/giblib/Config.in   | 4 ++++
 package/imlib2/Config.in   | 4 ++++
 3 files changed, 12 insertions(+)
package/directfb/Config.in +4 -0
index 59e2580..e3c93a1 100644
@@ -110,6 +110,10 @@ config BR2_PACKAGE_DIRECTFB_GIF
 config BR2_PACKAGE_DIRECTFB_IMLIB2
 	bool "enable IMLIB2 support"
 	select BR2_PACKAGE_IMLIB2
+	depends on !BR2_PREFER_STATIC_LIB
+
+comment "imlib2 support needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
 
 config BR2_PACKAGE_DIRECTFB_JPEG
 	bool "enable JPEG support"
package/giblib/Config.in +4 -0
index 7eb3da8..7b8f038 100644
@@ -1,9 +1,13 @@
 config BR2_PACKAGE_GIBLIB
 	bool "giblib"
 	depends on BR2_PACKAGE_XORG7
+	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_PACKAGE_IMLIB2
 	select BR2_PACKAGE_IMLIB2_X
 	help
 	  Giblib is a simple library which wraps imlib2.
 
 	  http://linuxbrit.co.uk/giblib/
+
+comment "giblib support needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
package/imlib2/Config.in +4 -0
index 16a94d6..1fef7e3 100644
@@ -1,6 +1,10 @@
+comment "imlib2 needs toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
+
 config BR2_PACKAGE_IMLIB2
 	bool "imlib2"
 	select BR2_PACKAGE_FREETYPE
+	depends on !BR2_PREFER_STATIC_LIB # dlopen()
 	help
 	  Imlib 2 is the successor to Imlib. This library provides
 	  routines to load, save and render images in various formats.
Signature · 1 line
1.9.2
#1 lore raw

PATCH 1/1 imlib2: uses dlopen(), not available in static cases

Quoted 56 lines · Thomas Petazzoni

According to the imlib2 people, if you don't support dlopen(), you have a "crap box":

image.h:16:4: warning: #warning "your crap box doesn't define RTLD_LOCAL !?"

So, let's disable imlib2 when doing static linking.

Fixes:

http://autobuild.buildroot.net/results/b5e/b5ee859409cd626b769e8a159026e60ec6f29180/

---
 package/directfb/Config.in | 4 ++++
 package/giblib/Config.in   | 4 ++++
 package/imlib2/Config.in   | 4 ++++
 3 files changed, 12 insertions(+)
package/directfb/Config.in +4 -0
index 59e2580..e3c93a1 100644
@@ -110,6 +110,10 @@ config BR2_PACKAGE_DIRECTFB_GIF
 config BR2_PACKAGE_DIRECTFB_IMLIB2
        bool "enable IMLIB2 support"
        select BR2_PACKAGE_IMLIB2
+       depends on !BR2_PREFER_STATIC_LIB
+
+comment "imlib2 support needs a toolchain w/ dynamic library"
+       depends on BR2_PREFER_STATIC_LIB
 
 config BR2_PACKAGE_DIRECTFB_JPEG
        bool "enable JPEG support"
package/giblib/Config.in +4 -0
index 7eb3da8..7b8f038 100644
@@ -1,9 +1,13 @@
 config BR2_PACKAGE_GIBLIB
        bool "giblib"
        depends on BR2_PACKAGE_XORG7
+       depends on !BR2_PREFER_STATIC_LIB
        select BR2_PACKAGE_IMLIB2
        select BR2_PACKAGE_IMLIB2_X
        help
          Giblib is a simple library which wraps imlib2.
 
          http://linuxbrit.co.uk/giblib/
+
+comment "giblib support needs a toolchain w/ dynamic library"
+       depends on BR2_PREFER_STATIC_LIB
package/imlib2/Config.in +0 -0
index 16a94d6..1fef7e3 100644

package/imlib2/Config.in line 2

Quoted 2 lines
package/imlib2/Config.in +2 -0
@@ -1,6 +1,10 @@
+comment "imlib2 needs toolchain w/ dynamic library"
+       depends on BR2_PREFER_STATIC_LIB

This should be 'needs a toolchain' (a)

Best regards,
Thomas

#2 lore raw

PATCH 1/1 imlib2: uses dlopen(), not available in static cases

In reply to Thomas Petazzoni
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

According to the imlib2 people, if you don't support dlopen(), you have a "crap box":

Quoted 7 lines

image.h:16:4: warning: #warning "your crap box doesn't define RTLD_LOCAL !?"

So, let's disable imlib2 when doing static linking.

Fixes:

http://autobuild.buildroot.net/results/b5e/b5ee859409cd626b769e8a159026e60ec6f29180/

Committed with the missing 'a' added, thanks.

Signature · 1 line
Bye, Peter Korsgaard