Skip to contentSkip to conversation

pcsc-lite: not available for static builds

PATCH New Vicente Olivert Riera 2 participants 4 messages Mar 10, 2014 – Mar 12, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcsc-lite: not available for static builds

This package requires dlopen and checks for it in the configure phase. If it's not present, then the build process is stopped.

Fixes:
http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/

---
 package/pcsc-lite/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
package/pcsc-lite/Config.in +4 -0
index aab42e8..24981bd 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
 	bool "pcsc-lite"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  Middleware to access smart card using SCard API (PC/SC).
 
@@ -31,3 +32,6 @@ endif
 comment "pcsc-lite needs a toolchain w/ threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "pcsc-lite needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 pcsc-lite: not available for static builds

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

This package requires dlopen and checks for it in the configure phase. If it's not present, then the build process is stopped.

Fixes:

   http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
---
 package/pcsc-lite/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
package/pcsc-lite/Config.in +0 -0
index aab42e8..24981bd 100644

package/pcsc-lite/Config.in config BR2_PACKAGE_PCSC_LITE · line 5

Quoted 4 lines
package/pcsc-lite/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
 	bool "pcsc-lite"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB

This dependency should also be propagated to the reverse dependencies of pcsc-lite.

package/pcsc-lite/Config.in endif · line 37

Quoted 10 lines
package/pcsc-lite/Config.in +3 -0
 	help
 	  Middleware to access smart card using SCard API (PC/SC).
 
@@ -31,3 +32,6 @@ endif
 comment "pcsc-lite needs a toolchain w/ threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "pcsc-lite needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB

We normally merge all the toolchain dependency options together, E.G.:

comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB

Committed with these changes, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 pcsc-lite: not available for static builds

Quoted 13 lines · Peter Korsgaard
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

This package requires dlopen and checks for it in the configure phase. If it's not present, then the build process is stopped.

Fixes:

   http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
---
 package/pcsc-lite/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Quoted 11 lines

package/pcsc-lite/Config.in config BR2_PACKAGE_PCSC_LITE · line 5

Quoted 9 lines
package/pcsc-lite/Config.in +1 -0
index aab42e8..24981bd 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
 	bool "pcsc-lite"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB

This dependency should also be propagated to the reverse dependencies of pcsc-lite.

Have you done this, or do you want I submit patches for it?

Quoted 19 lines

package/pcsc-lite/Config.in endif · line 37

Quoted 10 lines
package/pcsc-lite/Config.in +3 -0
 	help
 	  Middleware to access smart card using SCard API (PC/SC).
 
@@ -31,3 +32,6 @@ endif
 comment "pcsc-lite needs a toolchain w/ threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "pcsc-lite needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB

We normally merge all the toolchain dependency options together, E.G.:

comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB

Committed with these changes, thanks.

Signature · 1 line
Vincent
#3 lore raw

PATCH 1/1 pcsc-lite: not available for static builds

Quoted 29 lines · Vicente Olivert Riera
Quoted 28 lines · Peter Korsgaard
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

This package requires dlopen and checks for it in the configure

phase.

Quoted 4 lines

If it's not present, then the build process is stopped.

Fixes:

http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/

Review

Quoted 6 lines
---
 package/pcsc-lite/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/package/pcsc-lite/Config.in

Quoted 8 lines

index aab42e8..24981bd 100644

package/pcsc-lite/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
     bool "pcsc-lite"
     depends on BR2_TOOLCHAIN_HAS_THREADS
     depends on BR2_USE_MMU # fork()
+    depends on !BR2_PREFER_STATIC_LIB
Quoted 4 lines
Quoted 2 lines

This dependency should also be propagated to the reverse dependencies of pcsc-lite.

Have you done this, or do you want I submit patches for it?

Forget it, I have seen the commit.

Quoted 22 lines
Quoted 20 lines

package/pcsc-lite/Config.in endif · line 37

Quoted 11 lines
package/pcsc-lite/Config.in +3 -0
     help
       Middleware to access smart card using SCard API (PC/SC).
 
@@ -31,3 +32,6 @@ endif
 comment "pcsc-lite needs a toolchain w/ threads"
     depends on BR2_USE_MMU
     depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "pcsc-lite needs a toolchain w/ dynamic library"
+    depends on BR2_PREFER_STATIC_LIB

We normally merge all the toolchain dependency options together, E.G.:

comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB

Committed with these changes, thanks.

Signature · 1 line
Vincent