Skip to contentSkip to conversation

dropbear: add vfork fix

PATCH New Gustavo Zacarias 2 participants 4 messages Apr 2, 2013 – Apr 3, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dropbear: add vfork fix

Causes scp to fail badly.

---
 package/dropbear/dropbear-fix-vfork-logic.patch | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/dropbear/dropbear-fix-vfork-logic.patch
package/dropbear/dropbear-fix-vfork-logic.patch new file +21 -0
new file mode 100644
index 0000000..2706bc8
@@ -0,0 +1,21 @@
+
+# HG changeset patch
+# User Matt Johnston <[email protected]>
+# Date 1364743743 -28800
+# Node ID fedfb8ede1fdebad5d19df7bd4d452c3264d9545
+# Parent  f27058078d61a8c3a057530d3ddcd19bd5062569
+Fix incorrect logic for USE_VFORK and calling arg_setup()
+
+diff -r f27058078d61 -r fedfb8ede1fd scp.c
+--- a/scp.c	Sun Mar 31 23:15:35 2013 +0800
++++ b/scp.c	Sun Mar 31 23:29:03 2013 +0800
+@@ -230,7 +230,7 @@
+ 		close(pin[0]);
+ 		close(pout[1]);
+ 
+-#ifdef USE_VFORK
++#ifndef USE_VFORK
+ 		arg_setup(host, remuser, cmd);
+ #endif
+ 
+
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 dropbear: add vfork fix

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Causes scp to fail badly.

Committed, thanks.

Do we need the /dev/urandom write fix as well?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 dropbear: add vfork fix

Quoted 1 line · Peter Korsgaard

Do we need the /dev/urandom write fix as well?

I don't think so, we default to 0666 for it in the device table... Regards.

#3 lore raw

PATCH 1/1 dropbear: add vfork fix

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Quoted 1 line · Peter Korsgaard
Quoted 1 line

Do we need the /dev/urandom write fix as well?

Gustavo> I don't think so, we default to 0666 for it in the device table... Gustavo> Regards.

Ok, great.

Signature · 1 line
Bye, Peter Korsgaard