vim: Add post-install hook to remove documentation from target
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
From: Markos Chandras <[email protected]>
--- package/vim/vim.mk | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
package/vim/vim.mk +8 -0
@@ -36,8 +36,16 @@ define VIM_INSTALL_RUNTIME_CMDS $(MAKE) DESTDIR=$(TARGET_DIR) installmacros endef +define VIM_REMOVE_DOCS + find $(TARGET_DIR)/usr/share/vim -type f -name "*.txt" -delete +endef + ifeq ($(BR2_PACKAGE_VIM_RUNTIME),y) VIM_POST_INSTALL_TARGET_HOOKS += VIM_INSTALL_RUNTIME_CMDS endif +ifneq ($(BR2_HAVE_DOCUMENTATION),y) +VIM_POST_INSTALL_TARGET_HOOKS += VIM_REMOVE_DOCS +endif + $(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Dear Markos Chandras,
Quoted 3 lines · Markos Chandras
From: Markos Chandras <[email protected]>
Signed-off-by Markos Chandras <[email protected]>
We often try to keep the define ... endef block within the ifneq condition, since there is no reason for the VIM_REMOVE_DOCS variable to be defined if it is useless. But it's not something that has been done systematically in the entire code base (for example, the VIM_INSTALL_RUNTIME_CMDS just above your patch, doesn't follow this rule).
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Quoted 16 lines · Thomas Petazzoni
Dear Markos Chandras,
Quoted 3 lines · Markos Chandras
From: Markos Chandras <[email protected]>
Signed-off-by Markos Chandras <[email protected]>Reviewed-by Thomas Petazzoni <[email protected]>We often try to keep the define ... endef block within the ifneq condition, since there is no reason for the
VIM_REMOVE_DOCSvariable to be defined if it is useless. But it's not something that has been done systematically in the entire code base (for example, theVIM_INSTALL_RUNTIME_CMDSjust above your patch, doesn't follow this rule).
Quoted 6 lines
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Hi Thomas,
I agree but seeing how the VIM_INSTALL_RUMTIME_CMDS is implemented, I figured this was the recommended practice.
If you need me to submit a new patch please let me know.
Signature · 2 lines
Regards, Markos Chandras
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Dear Markos Chandras,
Quoted 3 lines · Markos Chandras
I agree but seeing how the
VIM_INSTALL_RUMTIME_CMDSis implemented, I figured this was the recommended practice.
If you need me to submit a new patch please let me know.
For me, the patch is fine as is, since it's a rule we haven't been enforcing everywhere.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Quoted 11 lines · Thomas Petazzoni
Dear Markos Chandras,
Quoted 3 lines · Markos Chandras
I agree but seeing how the
VIM_INSTALL_RUMTIME_CMDSis implemented, I figured this was the recommended practice.
If you need me to submit a new patch please let me know.For me, the patch is fine as is, since it's a rule we haven't been enforcing everywhere.
Quoted 6 lines
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Friendly reminder, just making sure this fix will be included in the 2013.02 release.
Signature · 2 lines
Regards, Markos Chandras
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
In reply to Markos ChandrasQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markos" == Markos Chandras <[email protected]> writes:
Markos> From: Markos Chandras <[email protected]> Markos> Signed-off-by: Markos Chandras <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
"Peter" == Peter Korsgaard <[email protected]> writes:
"Markos" == Markos Chandras <[email protected]> writes:
Markos> From: Markos Chandras <[email protected]> Markos> Signed-off-by: Markos Chandras <[email protected]>
Peter> Committed, thanks.
Hmm, I take that back:
http://autobuild.buildroot.net/results/adc3e2f876f83a4011574e03bceb0007d7e891a2/build-end.log
Seems like it perhaps only should be done if BR2_PACKAGE_VIM_RUNTIME is enabled?
Care to fix that?
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 vim: Add post-install hook to remove documentation from target
Quoted 12 lines · Peter Korsgaard
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
"Peter" == Peter Korsgaard <[email protected]> writes:
"Markos" == Markos Chandras <[email protected]> writes:
Markos> From: Markos Chandras <[email protected]> Markos> Signed-off-by: Markos Chandras <[email protected]>
Peter> Committed, thanks.
Hmm, I take that back:
http://autobuild.buildroot.net/results/adc3e2f876f83a4011574e03bceb0007d7e891a2/build-end.log
Quoted 7 lines
Seems like it perhaps only should be done if
BR2_PACKAGE_VIM_RUNTIMEis enabled?Care to fix that?
--
Bye, Peter Korsgaard
Hi Peter,
Yes I will have a look.
Signature · 2 lines
Regards, Markos Chandras